"Form" is not a constructor

Hi Thomas,

is

currentForm = document.getElementById("formName");

really the code at line 105 in your js file?

Can you try to produce a minimal html/js reproducing the problem?

Marc.

Thomas Robbs wrote:


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Htmlunit-user mailing list
Htmlunit-user@...
https://lists.sourceforge.net/lists/listinfo/htmlunit-user

I've also experienced this problem before. Unfortunantly, I was unable to isolate the problematic code from the application under test. If you're using "prototype.js" (a standard javascript library it seems) I've found that a simple modification to that JS file solved my problem.

I havn't been able to fully investigate the problem, but it does seem to have something to do with class prototyping in JavaScript confusing HTMLUnit. Unfortunantly, I think Marc was having a bad day that day, and I didn't get much help here. If you want to see where exactly I modified the file, I'll be happy to show you.

Thanks,

Ben Kyrlach -- Operations Intern.

-----Original Message-----
From: htmlunit-user-admin@...
[mailto:htmlunit-user-admin@...]On Behalf Of Marc
Guillemot
Sent: Monday, December 12, 2005 5:10 AM
To: htmlunit-user@...
Subject: [Htmlunit-user] Re: "Form" is not a constructor


Hi Thomas,

is

currentForm = document.getElementById("formName");

really the code at line 105 in your js file?

Can you try to produce a minimal html/js reproducing the problem?

Marc.

Thomas Robbs wrote:


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Htmlunit-user mailing list
Htmlunit-user@...
https://lists.sourceforge.net/lists/listinfo/htmlunit-user


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id865&op=click
_______________________________________________
Htmlunit-user mailing list
Htmlunit-user@...
https://lists.sourceforge.net/lists/listinfo/htmlunit-user

Ben Kyrlach wrote:

I've also experienced this problem before. Unfortunantly, I was unable to isolate the problematic code from the application under test. If you're using "prototype.js" (a standard javascript library it seems) I've found that a simple modification to that JS file solved my problem.

Please provide the patch for prototype.js as I'm having the same issue on my project.

Thanks,

Matt

Matt,
when you (or someone else) is able to provide an example of the failing
code, perhaps could we fix it in htmlunit itself...

Marc.

mraible (sent by Nabble.com) wrote:


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Htmlunit-user mailing list
Htmlunit-user@...
https://lists.sourceforge.net/lists/listinfo/htmlunit-user

-----Original Message-----
From: htmlunit-user-admin@... [mailto:htmlunit-user-admin@...]On Behalf Of mraible (sent by Nabble.com)
Sent: Wednesday, January 04, 2006 6:09 PM
To: htmlunit-user@...
Subject: [Htmlunit-user] RE: Re: "Form" is not a constructor

Ben Kyrlach wrote:

I've also experienced this problem before. Unfortunantly, I was unable to isolate the problematic code from the application under test. If you're using "prototype.js" (a standard javascript library it seems) I've found that a simple modification to that JS file solved my problem.

Please provide the patch for prototype.js as I'm having the same issue on my project.

Thanks,

Matt

---

View this message in context: RE: Re: "Form" is not a constructor
Sent from the HtmlUnit - General forum at Nabble.com.

Index: prototype.js
===================================================================
RCS file: /usr/local/cvsroot/hobsons2.0/tim/TIMConfig/prototype.js,v
retrieving revision 1.1
diff -u -r1.1 prototype.js
--- prototype.js 5 Jan 2006 19:19:30 -0000 1.1
+++ prototype.js 5 Jan 2006 19:22:12 -0000
@@ -581,13 +581,13 @@
 
 /*--------------------------------------------------------------------------*/
 
-var Form = {
+var Form1 = {
   serialize: function(form) {
-    var elements = Form.getElements($(form));
+    var elements = Form1.getElements($(form));
     var queryComponents = new Array();
     
     for (var i = 0; i < elements.length; i++) {
-      var queryComponent = Form.Element.serialize(elements[i]);
+      var queryComponent = Form1.Element.serialize(elements[i]);
       if (queryComponent)
         queryComponents.push(queryComponent);
     }
@@ -599,7 +599,7 @@
     var form = $(form);
     var elements = new Array();
 
-    for (tagName in Form.Element.Serializers) {
+    for (tagName in Form1.Element.Serializers) {
       var tagElements = form.getElementsByTagName(tagName);
       for (var j = 0; j < tagElements.length; j++)
         elements.push(tagElements[j]);
@@ -627,7 +627,7 @@
   },
 
   disable: function(form) {
-    var elements = Form.getElements(form);
+    var elements = Form1.getElements(form);
     for (var i = 0; i < elements.length; i++) {
       var element = elements[i];
       element.blur();
@@ -636,7 +636,7 @@
   },
 
   enable: function(form) {
-    var elements = Form.getElements(form);
+    var elements = Form1.getElements(form);
     for (var i = 0; i < elements.length; i++) {
       var element = elements[i];
       element.disabled = '';
@@ -645,7 +645,7 @@
 
   focusFirstElement: function(form) {
     var form = $(form);
-    var elements = Form.getElements(form);
+    var elements = Form1.getElements(form);
     for (var i = 0; i < elements.length; i++) {
       var element = elements[i];
       if (element.type != 'hidden' && !element.disabled) {
@@ -660,11 +660,11 @@
   }
 }
 
-Form.Element = {
+Form1.Element = {
   serialize: function(element) {
     var element = $(element);
     var method = element.tagName.toLowerCase();
-    var parameter = Form.Element.Serializers[method](element);
+    var parameter = Form1.Element.Serializers[method](element);
     
     if (parameter)
       return encodeURIComponent(parameter[0]) + '=' +
@@ -674,24 +674,24 @@
   getValue: function(element) {
     var element = $(element);
     var method = element.tagName.toLowerCase();
-    var parameter = Form.Element.Serializers[method](element);
+    var parameter = Form1.Element.Serializers[method](element);
     
     if (parameter)
       return parameter[1];
   }
 }
 
-Form.Element.Serializers = {
+Form1.Element.Serializers = {
   input: function(element) {
     switch (element.type.toLowerCase()) {
       case 'submit':
       case 'hidden':
       case 'password':
       case 'text':
-        return Form.Element.Serializers.textarea(element);
+        return Form1.Element.Serializers.textarea(element);
       case 'checkbox':  
       case 'radio':
-        return Form.Element.Serializers.inputSelector(element);
+        return Form1.Element.Serializers.inputSelector(element);
     }
     return false;
   },
@@ -725,7 +725,7 @@
 
 /*--------------------------------------------------------------------------*/
 
-var $F = Form.Element.getValue;
+var $F = Form1.Element.getValue;
 
 /*--------------------------------------------------------------------------*/
 
@@ -753,17 +753,17 @@
   }
 }
 
-Form.Element.Observer = Class.create();
-Form.Element.Observer.prototype = (new Abstract.TimedObserver()).extend({
+Form1.Element.Observer = Class.create();
+Form1.Element.Observer.prototype = (new Abstract.TimedObserver()).extend({
   getValue: function() {
-    return Form.Element.getValue(this.element);
+    return Form1.Element.getValue(this.element);
   }
 });
 
-Form.Observer = Class.create();
-Form.Observer.prototype = (new Abstract.TimedObserver()).extend({
+Form1.Observer = Class.create();
+Form1.Observer.prototype = (new Abstract.TimedObserver()).extend({
   getValue: function() {
-    return Form.serialize(this.element);
+    return Form1.serialize(this.element);
   }
 });
 
@@ -791,7 +791,7 @@
   },
   
   registerFormCallbacks: function() {
-    var elements = Form.getElements(this.element);
+    var elements = Form1.getElements(this.element);
     for (var i = 0; i < elements.length; i++)
       this.registerCallback(elements[i]);
   },
@@ -825,17 +825,17 @@
   }
 }
 
-Form.Element.EventObserver = Class.create();
-Form.Element.EventObserver.prototype = (new Abstract.EventObserver()).extend({
+Form1.Element.EventObserver = Class.create();
+Form1.Element.EventObserver.prototype = (new Abstract.EventObserver()).extend({
   getValue: function() {
-    return Form.Element.getValue(this.element);
+    return Form1.Element.getValue(this.element);
   }
 });
 
-Form.EventObserver = Class.create();
-Form.EventObserver.prototype = (new Abstract.EventObserver()).extend({
+Form1.EventObserver = Class.create();
+Form1.EventObserver.prototype = (new Abstract.EventObserver()).extend({
   getValue: function() {
-    return Form.serialize(this.element);
+    return Form1.serialize(this.element);
   }
 });
 
@@ -1033,6 +1033,4 @@
     target.style.top    = offsets[1] + 'px';
     target.style.left   = offsets[0] + 'px';
     target.style.width  = source.offsetWidth + 'px';
-    target.style.height = source.offsetHeight + 'px';
-  }
-}
+    target.style.height = source.off
\ No newline at end of file

Here is a file which exhibits the error - just click on the button - change Form to Form1 in 2 places and it no longer breaks:

<html>
<head>
<script type="text/javascript">
<!--
var Form = {
  getElements: function(form) {
    form = $(form);
    var elements = new Array();
    for (tagName in Form.Element.Serializers) {
      var tagElements = form.getElementsByTagName(tagName);
      for (var j = 0; j < tagElements.length; j++)
        elements.push(tagElements[j]);
    }
    return elements;
  }
}
function validate() {
    currentForm = document.getElementById('formId');
    currentForm.field1.value="fred";
    return false;
}
// -->
</script>
</head>
<body>
   <form id='formId' name='formName'>
     <input type="text" name="field1" value="barney">
     <input type="button" type="submit" id="submit" onClick="validate()">
   </form>
</body>
</html>

If it helps, here is a WebTest script for clicking the link:

    <target name="main">
        <property name="testfile" location="checkJavaScript.html"/>
        <webtest name="prototype.js bug">
            <config
                    summary="true"
                    saveresponse="true"
                    showhtmlparseroutput="false"/>
            <steps>
                <invoke url="file:///${testfile}"/>
                <clickButton htmlId="submit" />
                <verifyInputField name="field1" value="fred"/>
            </steps>
        </webtest>
    </target>

Ok, I've understood the problem: Form is newly defined and when we want to
create the JS object for the form trying to call our JS host object through its
constructor, it has been replaced by the local "Form" object.

This will be quite simple to fix, just using an other name for the internal use
of the object. I guess that the problem occurs with other of htmlunit's host
classes and I will try to check them all.

Marc.



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Htmlunit-user mailing list
Htmlunit-user@...
https://lists.sourceforge.net/lists/listinfo/htmlunit-user

Please let me know when this is fixed in CVS - I'd be more than happy to test.

mraible (sent by Nabble.com) wrote:
> Please let me know when this is fixed in CVS - I'd be more than happy to
> test.

sure.
I thought that I could fix it this evening but it is a bit more
complicated as I thougt, I will post a message when it is fixed (I hope
this week).

Marc.


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Htmlunit-user mailing list
Htmlunit-user@...
https://lists.sourceforge.net/lists/listinfo/htmlunit-user

Matt,

this should now work for Form.

The work needs to be extended to definitely avoid name conflicts. I
won't ship a new htmlunit jar to webtest until this is done but you can
already build one by yourself from htmlunit's public CVS and use it in
place of the provided one in the latest webtest build.

Marc.

mraible (sent by Nabble.com) wrote:
> Please let me know when this is fixed in CVS - I'd be more than happy to
> test.
> ------------------------------------------------------------------------
> View this message in context: Re: "Form" is not a constructor
> <http://www.nabble.com/%22Form%22-is-not-a-constructor-t716240.html#a2279743>
> Sent from the HtmlUnit - General
> <http://www.nabble.com/HtmlUnit---General-f2599.html> forum at Nabble.com.



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Htmlunit-user mailing list
Htmlunit-user@...
https://lists.sourceforge.net/lists/listinfo/htmlunit-user

I checked out and built from CVS, but no luck - the error is still there.  I suspect SF's anonymous CVS hasn't synchronized yet? Is there anyway to post a snapshot or send me the JAR? mraible AT Gmail.

Thanks,

Matt

mraible (sent by Nabble.com <lists <at> nabble.com> writes:

>
>
> I checked out and built from CVS, but no luck - the error is still there.  I
suspect SF's anonymous CVS hasn't synchronized yet? Is there anyway to post a
snapshot or send me the JAR? mraible AT Gmail.
> Thanks,
> Matt
>
> View this message in context: Re: "Form" is not a constructor
> Sent from the HtmlUnit - General forum at Nabble.com.
>


I've checked through the public ViewCVS and the change seems now to be
available.

Generally you can use the diff that is automatically posted to the dev mailing
list after each commit and apply it locally when you don't want to wait for the
public CVS to be updated.

Marc.



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Htmlunit-user mailing list
Htmlunit-user@...
https://lists.sourceforge.net/lists/listinfo/htmlunit-user

Thanks Marc - works great!

I am running into this same problem and am wondering if the newest version of HtmlUnit (1.8 released in February) had this fix.  I even tried building from CVS (now a 1.9 prerelease) with no luck.  If possible, however, is there some modifications that I can do myself so that I can still use HtmlUnit 1.7?  I have a bunch of other test cases that have now deprecated methods and would like to avoid a refactor.

Hi,

if you want to delay your refactoring work, you have to avoid the use of a js variable named Form... or backport the fix for this problem to htmunit 1.7. Nevertheless I guess that it is less work to upgrade to htmlunit 1.8 and this makes you ready to benefit from the next fix that you will need ;-)

Marc.