<AWT Dev> Review request #0: 6402325 (Swing toolbars vs native toolbars on Windows)

[Anthony Petrov]

Hello AWT team,

Please review a preliminary version of the fix for RFE:

6402325 (Swing toolbars vs native toolbars on Windows)
http://bugs.sun.com/view_bug.do?bug_id=6402325

The webrev:
http://cr.openjdk.java.net/~anthony/7-33-utilityWindows-6402325.0/

Notes regarding implementation:

1. As suggested by Mike Swingler, setting the type is only possible
while the window has not been made displayable.

2. To reduce the complexity of the implementation, I decided we do not
need to deal with the focusability of utility windows. If a developer
needs an unfocusable utility window, they can use existing Java API to
achieve that.

3. The title-bar of an utility window is not made persistently active:
the focused state depends on whether the window has focus or not.
Implementing that feature on Windows would require hacking the
WM_NCACTIVATE/WM_NCPAINT message handlers which, actually, can easily be
broken when running with DWM enabled on Vista, and is a hack anyway. On
X11 I've no idea if that is even possible at all: there's no tips in the
EWMH specification, and besides that, everything depends on the theme of
a window manager. So I don't think we're able to implement this
consistently.

--
best regards,
Anthony

[Anton V. Tarasov]

Hi Anthony,

Just a little concern. In awt_Window.h you define:

369     Type windowType;

Could you please follow the tradition of using "m" prefix for non-static fields in AWT?
This would be consistent with the rest of the code, and would allow to quickly distinguish
class fields from locally defined variables when you're investigating the code.
Please! =)

Thanks,
Anton.


Anthony Petrov wrote:

> Hello AWT team,
>
> Please review a preliminary version of the fix for RFE:
>
> 6402325 (Swing toolbars vs native toolbars on Windows)
> http://bugs.sun.com/view_bug.do?bug_id=6402325
>
> The webrev:
> http://cr.openjdk.java.net/~anthony/7-33-utilityWindows-6402325.0/
>
> Notes regarding implementation:
>
> 1. As suggested by Mike Swingler, setting the type is only possible
> while the window has not been made displayable.
>
> 2. To reduce the complexity of the implementation, I decided we do not
> need to deal with the focusability of utility windows. If a developer
> needs an unfocusable utility window, they can use existing Java API to
> achieve that.
>
> 3. The title-bar of an utility window is not made persistently active:
> the focused state depends on whether the window has focus or not.
> Implementing that feature on Windows would require hacking the
> WM_NCACTIVATE/WM_NCPAINT message handlers which, actually, can easily be
> broken when running with DWM enabled on Vista, and is a hack anyway. On
> X11 I've no idea if that is even possible at all: there's no tips in the
> EWMH specification, and besides that, everything depends on the theme of
> a window manager. So I don't think we're able to implement this
> consistently.
>
> --
> best regards,
> Anthony
>

[Anthony Petrov]

Hi Anton,

On 10/21/2009 10:25 AM, Anton V. Tarasov wrote:
> 369     Type windowType;
>
> Could you please follow the tradition of using "m" prefix for non-static
> fields in AWT?
> This would be consistent with the rest of the code, and would allow to
> quickly distinguish
> class fields from locally defined variables when you're investigating
> the code.
> Please! =)

Sure! :)
Thanks for reviewing.

--
best regards,
Anthony