<Beans Dev> 6899147: java.beans.MetaData should not require JDBC to be present

View: New views
2 Messages — Rating Filter:   Alert me  

<Beans Dev> 6899147: java.beans.MetaData should not require JDBC to be present

by Alan Bateman :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Sergey,

As we discussed today, the persistent delegate for java.sql.Timestamp in
java.beans.Metadata creates an undesirable dependency on JDBC. I'd like
to change this to use reflection so as to eliminate the static
dependency. This doesn't change anything at runtime in that this
persistent delegate will only be loaded if the type is a Timestamp. I've
put the webrev with the change here:
  http://cr.openjdk.java.net/~alanb/6899147/webrev.00/

For testing, I've run the tests in test/java/beans/XMLEncoder - the
java_sql_Timestamp.java test in particular, provides good coverage.

Thanks,

-Alan.


<Beans Dev> Approved: 6899147: java.beans.MetaData should not require JDBC to be present

by sergey.malenkov :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Alan,

The fix looks good for me.
I approve.

Thanks,
SAM

Alan Bateman wrote:

> Sergey,
>
> As we discussed today, the persistent delegate for java.sql.Timestamp in
> java.beans.Metadata creates an undesirable dependency on JDBC. I'd like
> to change this to use reflection so as to eliminate the static
> dependency. This doesn't change anything at runtime in that this
> persistent delegate will only be loaded if the type is a Timestamp. I've
> put the webrev with the change here:
>  http://cr.openjdk.java.net/~alanb/6899147/webrev.00/
>
> For testing, I've run the tests in test/java/beans/XMLEncoder - the
> java_sql_Timestamp.java test in particular, provides good coverage.
>
> Thanks,
>
> -Alan.
>