[!] We need to check all our games with Qt 4.6

[Dmitry Suzdalev-2]

Hello guys!

It is the second time I find that some game is not working with 4.6.
I just started konquest and it simply segfaults on start (endless loop).
I have the patch ready for that, will put it to review soon.

First one was KAtomic (fixed now).

In the KAtomic's case this was a bug in Qt, in the Konquest case i'm not sure  
should I classify this as a bug in Qt or in Konquest :)

But anyway, the message is the following:

Those of us who are using trunk and Qt 4.6 (which was upgraded yesterday in
kde-qt git repo, btw) really should team up and ensure that all our games are
playable.
I guess not by simply starting them, but by starting and playing at least for
a minute :)

Dunno if this should be orgainized somehow (quick works/notworks status page
on a wiki?), but i really feel we should spare us some future bugs and sad
users :)

Cheers,
Dmitry.
_______________________________________________
kde-games-devel mailing list
kde-games-devel@...
https://mail.kde.org/mailman/listinfo/kde-games-devel

[Parker Coates]

On Thu, Nov 5, 2009 at 10:09, Dmitry Suzdalev wrote:

> Hello guys!
>
> It is the second time I find that some game is not working with 4.6.
> I just started konquest and it simply segfaults on start (endless loop).
> I have the patch ready for that, will put it to review soon.
>
> First one was KAtomic (fixed now).
>
> In the KAtomic's case this was a bug in Qt, in the Konquest case i'm not sure
> should I classify this as a bug in Qt or in Konquest :)
>
> But anyway, the message is the following:
>
> Those of us who are using trunk and Qt 4.6 (which was upgraded yesterday in
> kde-qt git repo, btw) really should team up and ensure that all our games are
> playable.
> I guess not by simply starting them, but by starting and playing at least for
> a minute :)
>
> Dunno if this should be orgainized somehow (quick works/notworks status page
> on a wiki?), but i really feel we should spare us some future bugs and sad
> users :)

Qt4.6 broke some painting in Killbots.
(http://websvn.kde.org/?view=revision&revision=1043545)

In that particular case, something was being painted without
transparency when it should have been. So keep in mind that the
regressions might be a bit more subtle.

I'd be willing to help out with this effort, but probably only after
the feature freeze.

Parker
_______________________________________________
kde-games-devel mailing list
kde-games-devel@...
https://mail.kde.org/mailman/listinfo/kde-games-devel

[Dmitry Suzdalev-2]

On Thursday 05 November 2009 18:23:09 Parker Coates wrote:
> I'd be willing to help out with this effort, but probably only after
> the feature freeze.
Yeah, I'm asked here mostly for two reasons:

- I might not have time to check all the games myself
- More testing hands is many times better than single pair of 'em

I just fixed one bug in konquest and found another one - cached background for
some reason is drawn as a black square. Didn't find why yet...

Dmitry.
_______________________________________________
kde-games-devel mailing list
kde-games-devel@...
https://mail.kde.org/mailman/listinfo/kde-games-devel

[Parker Coates]

On Thu, Nov 5, 2009 at 10:32, Dmitry Suzdalev <dimsuzkde@...> wrote:

> On Thursday 05 November 2009 18:23:09 Parker Coates wrote:
>> I'd be willing to help out with this effort, but probably only after
>> the feature freeze.
> Yeah, I'm asked here mostly for two reasons:
>
> - I might not have time to check all the games myself
> - More testing hands is many times better than single pair of 'em
>
> I just fixed one bug in konquest and found another one - cached background for
> some reason is drawn as a black square. Didn't find why yet...

The scene background painting with black instead of transparency is
exactly the issue I had in Killbots. You might want to see if the
commit above will work there.

Parker
_______________________________________________
kde-games-devel mailing list
kde-games-devel@...
https://mail.kde.org/mailman/listinfo/kde-games-devel

[Dmitry Suzdalev-2]

On Thursday 05 November 2009 18:43:18 Parker Coates wrote:
> The scene background painting with black instead of transparency is
> exactly the issue I had in Killbots. You might want to see if the
> commit above will work there.
Great! This works. But still this is a workaround. I think we should report it
to Qt guys :)

I updated the review, please someone take a look at it :)

Cheers,
Dmitry.
_______________________________________________
kde-games-devel mailing list
kde-games-devel@...
https://mail.kde.org/mailman/listinfo/kde-games-devel

[Olivier Goffart]

Le Thursday 05 November 2009, Dmitry Suzdalev a écrit :
> Hello guys!
>
> It is the second time I find that some game is not working with 4.6.
> I just started konquest and it simply segfaults on start (endless loop).
> I have the patch ready for that, will put it to review soon.

Please report any regression in Qt to Nokia
--> http://bugreports.qt.nokia.com
(indicate in your report that it is a regression)

It is maybe a bit late to have bug fixed for Qt 4.6.0 now (unless this is a
crash or a severe regression).  But reported regression are likely to be fixed
in Qt 4.6.1

--
Gof
_______________________________________________
kde-games-devel mailing list
kde-games-devel@...
https://mail.kde.org/mailman/listinfo/kde-games-devel

On Friday 06 November 2009 00:47:29 Olivier Goffart wrote:

> Please report any regression in Qt to Nokia
> --> http://bugreports.qt.nokia.com
> (indicate in your report that it is a regression)
>
> It is maybe a bit late to have bug fixed for Qt 4.6.0 now (unless this is a
> crash or a severe regression).  But reported regression are likely to be
>  fixed in Qt 4.6.1
Yeah, Parker tries to come up with a minimal example which reproduces
drawBackground issue as we speak :)

OTOH when speaking about the issue that calling scene().width() from
Item::boundingRect() cases infinite loop i'm not sure if that's a regression
or if it's something that app shouldn't do and Qt just doesn't support such
calls. Though it did support them in 4.5 :)

I think I'll ask darktears/bibr on irc before reporting this. Or are you a QGV
guy too now, Olivier? :)

Cheers,
Dmitry.
_______________________________________________
kde-games-devel mailing list
kde-games-devel@...
https://mail.kde.org/mailman/listinfo/kde-games-devel