[ 1288590 ] Potion of hallucination cannot be identified by drinking

[likeyou dontknow]

I was working on this (http://sourceforge.net/tracker/index.php?func=detail&aid=1288590&group_id=9746&atid=109746) bug, and I think I've got it working. Here are my changes:

--- ../../slashem-0.0.8E0/src/potion.c  2005-07-02 00:31:37.000000000 -0700
+++ src/potion.c        2006-11-28 01:49:14.000000000 -0800
@@ -479,9 +479,12 @@
                break;
        case POT_HALLUCINATION:
                if (Hallucination || Halluc_resistance) nothing++;
-               (void) make_hallucinated(itimeout_incr(HHallucination,
+               else {
+                       makeknown(otmp->otyp);
+                       (void) make_hallucinated(itimeout_incr(HHallucination,
                                           rn1(200, 600 - 300 * bcsign(otmp))),
                                  TRUE, 0L);
+               }
                break;
        case POT_AMNESIA:
                pline(Hallucination? "This tastes like champagne!" :


pretty much just added an else and had it run the makeknown (thanks to Ali for the suggestion, I would have been caught up on trying to add another variable to the function for hours). I tried it out, the potion didn't identify if I were already hallucinating, though would print "you have a normal feeling" then ask me what I wanted to call it...maybe it shouldn't do that? Drinking a the potion while not hallucinating identifies it. Also the potion did not identify if I was hallucination resistant (and didn't ask me what I wanted to call it).


And now I am going to bed because it is late.

Cheers,
Michael DiPietro

---

Cheap Talk? Check out Yahoo! Messenger's low PC-to-Phone call rates.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Slashem-devel mailing list
Slashem-devel@...
https://lists.sourceforge.net/lists/listinfo/slashem-devel

[J. Ali Harlow-2]

On 2006-11-28 10:04:59 AM, likeyou dontknow wrote:
> I was working on this  
> (http://sourceforge.net/tracker/index.php?func=detail&aid=1288590&group_id=9746&atid=109746)
> bug, and I think I've got it working. Here are my changes:

[snip]

This isn't quite right. Moving the make_hallucinated() call into the  
if-case removes the intended effect of stacking hallucination (quaffing  
a potion of hallucination when you're already hallucinating will make  
you hallucinate for longer).

> I tried it out, the potion didn't identify if I were already  
> hallucinating, though would print "you have a normal feeling" then  
> ask me what I wanted to call it...maybe it shouldn't do that?  
> Drinking a the potion while not hallucinating identifies it. Also the  
> potion did not identify if I was hallucination resistant (and didn't  
> ask me what I wanted to call it).

This looks right to me. Thanks for testing, I've now committed this fix.

Cheers,

Ali.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Slashem-devel mailing list
Slashem-devel@...
https://lists.sourceforge.net/lists/listinfo/slashem-devel