[ 1546379 ] Fedora & charisma

[likeyou dontknow]

Houdy, I was working on this (http://sourceforge.net/tracker/index.php?func=detail&aid=1546379&group_id=9746&atid=109746) Bug, and it looks like silasd had the fix of adding "flags.botl = 1;" to the correct lines, while I can't figure out what that is actually doing it does seem to work (I think that it is defining "botl" to equal "1" in the structure flags. but I can't figure out where flags is defined (or if I'm even right about the structure thing). It does appear to show up everywhere that a vairable changes in the visible set, so I assume it is called somewhere just to refresh that section of the window.) Anyways, I didn't find any referance to this big in the devel list so I figured I would send it along.

--- ../../slashem-0.0.8E0/src/do_wear.c 2005-07-02 00:31:37.000000000 -0700
+++ ./src/do_wear.c     2006-12-01 17:23:02.000000000 -0800
@@ -308,6 +308,7 @@
     switch(uarmh->otyp) {
        case FEDORA:
                set_moreluck();
+               flags.botl = 1;
                break;
        case HELMET:
        case DENTED_POT:
@@ -372,6 +373,7 @@
        case FEDORA:
            setworn((struct obj *)0, W_ARMH);
            set_moreluck();
+           flags.botl = 1;
            return 0;
        case HELMET:
        case DENTED_POT:


I tested it out and it does seem to work (Charsma does update when the fedora is put on or taken off.) though I don't know the inner workings of what is going on, so it may just be a giant problem waiting to happen. I figured other more knowledgeable people would notice if it was.

Thanks,
Michael DiPietro

---

Access over 1 million songs - Yahoo! Music Unlimited.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Slashem-devel mailing list
Slashem-devel@...
https://lists.sourceforge.net/lists/listinfo/slashem-devel

[J. Ali Harlow-2]

On 2006-12-02 01:54:50 AM, likeyou dontknow wrote:

> Houdy, I was working on this  
> (http://sourceforge.net/tracker/index.php?func=detail&aid=1546379&group_id=9746&atid=109746)
> Bug, and it looks like silasd had the fix of adding "flags.botl = 1;"
> to the correct lines, while I can't figure out what that is actually
> doing it does seem to work (I think that it is defining "botl" to
> equal "1" in the structure flags. but I can't figure out where flags
> is defined (or if I'm even right about the structure thing). It does
> appear to show up everywhere that a vairable changes in the visible
> set, so I assume it is called somewhere just to refresh that section
> of the window.) Anyways, I didn't find any referance to this big in
> the devel list so I figured I would send it along.

flags (like almost all global variables) is defined in decl.h.

flags.botl = 1 is just an assignment. It's not really any different to  
a simpler assignment such as flags_botl = 1, it's just that we ask the  
compiler to keep a group of variables together since that makes it  
easier to think about.

The effect of setting this flag is that it causes moveloop() to call  
bot() to update the bottom line (see allmain.c around line 375).

Thanks for the fix.

Ali.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Slashem-devel mailing list
Slashem-devel@...
https://lists.sourceforge.net/lists/listinfo/slashem-devel