[ 1708141 ] "the" in "the Rat King" uncapitalized when eating corpse

View: New views
2 Messages — Rating Filter:   Alert me  

[ 1708141 ] "the" in "the Rat King" uncapitalized when eating corpse

by likeyou dontknow :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

just a missing capital in the title.

--- src/monst.c 2007-04-26 10:40:27.000000000 -0700
+++ /home/michael/slashem_static/slashem-0.0.8E0F1/src/monst.c  2006-12-30 05:04:53.000000000 -0800
@@ -1473,7 +1473,7 @@
        SIZ(20, 12, 0, MS_SQEEK, MZ_TINY), MR_FIRE, MR_FIRE,
        M1_ANIMAL|M1_NOHANDS|M1_CARNIVORE,
        M2_HOSTILE, M3_INFRAVISIBLE, CLR_RED),
-    MON("The Rat King", S_RODENT,
+    MON("the Rat King", S_RODENT,
        LVL(12, 15, 7, 0, 0), (G_UNIQ|1),
        A(ATTK(AT_WEAP, AD_PHYS, 2, 4), ATTK(AT_BITE, AD_PHYS, 2, 3),
          NO_ATTK, NO_ATTK, NO_ATTK, NO_ATTK),

cheers,
Michael


Ahhh...imagining that irresistible "new car" smell?
Check out new cars at Yahoo! Autos.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Slashem-devel mailing list
Slashem-devel@...
https://lists.sourceforge.net/lists/listinfo/slashem-devel

Re: [ 1708141 ] "the" in "the Rat King" uncapitalized when eating corpse

by J. Ali Harlow-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 2007-04-26 06:55:16 PM, likeyou dontknow wrote:

> just a missing capital in the title.
>
> --- src/monst.c 2007-04-26 10:40:27.000000000 -0700
> +++ /home/michael/slashem_static/slashem-0.0.8E0F1/src/monst.c
> 2006-12-30 05:04:53.000000000 -0800
> @@ -1473,7 +1473,7 @@
>         SIZ(20, 12, 0, MS_SQEEK, MZ_TINY), MR_FIRE, MR_FIRE,
>         M1_ANIMAL|M1_NOHANDS|M1_CARNIVORE,
>         M2_HOSTILE, M3_INFRAVISIBLE, CLR_RED),
> -    MON("The Rat King", S_RODENT,
> +    MON("the Rat King", S_RODENT,
>         LVL(12, 15, 7, 0, 0), (G_UNIQ|1),
>         A(ATTK(AT_WEAP, AD_PHYS, 2, 4), ATTK(AT_BITE, AD_PHYS, 2, 3),
>
>           NO_ATTK, NO_ATTK, NO_ATTK, NO_ATTK),

Your patches are still coming out back-to-front. The above says to  
remove (-) a line with a capital letter and add (+) a line with a lower  
case letter which is the opposite of what you mean. Try calling diff  
with the arguments in the other order. Ie., you need to say:

% diff -Naurd <old> <new>

The reason we don't use "The" in monst.c is that messages such as "You  
hit the Rat King!" (when verbose is on) look better without (standard  
capitalisation rules say that articles, conjunctions and prepositions  
of three or fewer letters should only be capitalised at the start of a  
sentence). The proper fix is rather more difficult, I'm afraid. You'd  
need to modify the call to food_xname() in eat.c around line 1620 so  
that in the problem case (uniq && type_is_pname) it gets capitalised.  
That probably means adding a Food_xname() similar to Monnam() et. al.

Cheers,

Ali.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Slashem-devel mailing list
Slashem-devel@...
https://lists.sourceforge.net/lists/listinfo/slashem-devel