[ cdk-Patches-2816660 ] ILoggingTool patch to make log4j optional

[SourceForge.net]

Patches item #2816660, was opened at 2009-07-04 13:37
Message generated for change (Comment added) made by rajarshi
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2816660&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Needs Review
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Egon Willighagen (egonw)
Assigned to: Nobody/Anonymous (nobody)
Summary: ILoggingTool patch to make log4j optional

Initial Comment:
This patch introduces a new LoggingTool framework, making the log4j-based implementation optional. It:

* introduces ILoggingTool
* introduces a LoggingToolFactory to instantiate a logger
* makes the log4j LoggingTool optional, and now available from the log4j module
* introduces a SystemOutLoggingTool for logging to STDOUT
* allows registration of custom ILoggingTool implementation with the LoggingToolFactory, with an example in the unit test class

The patch was written against master, and can be applied with 'git am'.

----------------------------------------------------------------------

>Comment By: Rajarshi Guha (rajarshi)
Date: 2009-11-01 23:15

Message:
Patch 1 worked fine, but patch 2 fails on latest master

....
import java.util.List;
error: patch failed: build.xml:985
error: build.xml: patch does not apply
warning: src/main/org/openscience/cdk/config/ElementPTFactory.java has
type 100755, expected 100644
error: patch failed:
src/main/org/openscience/cdk/fingerprint/Fingerprinter.java:36
error: src/main/org/openscience/cdk/fingerprint/Fingerprinter.java: patch
does not apply
error: patch failed:
src/main/org/openscience/cdk/fingerprint/MACCSFingerprinter.java:68
error: src/main/org/openscience/cdk/fingerprint/MACCSFingerprinter.java:
patch does not apply
....

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2816660&group_id=20024

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Cdk-devel mailing list
Cdk-devel@...
https://lists.sourceforge.net/lists/listinfo/cdk-devel