[ cdk-Patches-2832870 ] patch with unit tests for PubChem XML bugs + partial fix

View: New views
1 Messages — Rating Filter:   Alert me  

[ cdk-Patches-2832870 ] patch with unit tests for PubChem XML bugs + partial fix

by SourceForge.net :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Patches item #2832870, was opened at 2009-08-05 18:10
Message generated for change (Settings changed) made by rajarshi
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2832870&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Needs Review
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Egon Willighagen (egonw)
Assigned to: Nobody/Anonymous (nobody)
Summary: patch with unit tests for PubChem XML bugs + partial fix

Initial Comment:
The 0001 patch has unit tests for these two bugs:

2832858   Format matching depends on all formats to be matching...
2832835   Improper detection of PubChem XML formats

and the 0002 patch fixes the 2832835 bug. The other bug is a limitation of the API.

Patch is made against cdk-1.2.x and being a bug fix, requires (at least) one senior review.

----------------------------------------------------------------------

>Comment By: Rajarshi Guha (rajarshi)
Date: 2009-11-01 13:02

Message:
Looks good. However, I pulled these into master by mistake. Can you merge
these 2 commits specifically into cdk-1.2.x?

----------------------------------------------------------------------

Comment By: Egon Willighagen (egonw)
Date: 2009-11-01 12:49

Message:
Sorry about that. Patches are now attached.

----------------------------------------------------------------------

Comment By: Rajarshi Guha (rajarshi)
Date: 2009-11-01 12:22

Message:
There are no patches attached

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2832870&group_id=20024

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Cdk-devel mailing list
Cdk-devel@...
https://lists.sourceforge.net/lists/listinfo/cdk-devel