[ tcl-Patches-2892871 ] Autoconferry from the Autoconf Fairy

View: New views
1 Messages — Rating Filter:   Alert me  

[ tcl-Patches-2892871 ] Autoconferry from the Autoconf Fairy

by SourceForge.net :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Patches item #2892871, was opened at 2009-11-05 13:38
Message generated for change (Tracker Item Submitted) made by stwo
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=310894&aid=2892871&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Stuart Cassoff (stwo)
Assigned to: Nobody/Anonymous (nobody)
Summary: Autoconferry from the Autoconf Fairy

Initial Comment:
1) In tcl.m4 the autoconf macro AC_STRUCT_TIMEZONE is used but its resultant defines HAVE_STRUCT_TM_TM_ZONE, HAVE_TM_ZONE and possibly HAVE_TZNAME are not referenced anywhere in Tcl or in Tk. I recommend it be removed since a) it's not being used, and b) it creates up to two unused defines which clutter the tclConfig.h file and the compile command line needlessly.
2) The autoconf macro AC_STRUCT_ST_BLKSIZE is obsoleted and creates two defines: HAVE_STRUCT_STAT_ST_BLKSIZE and the obsoleted HAVE_ST_BLKSIZE, cluttering the tclConfig.h file and the compile command line needlessly. I (and the autoconf docs) recommend it be changed to AC_CHECK_MEMBERS([struct stat.st_blksize]) which creates the single define HAVE_STRUCT_STAT_ST_BLKSIZE and to modify all code which checks for HAVE_ST_BLKSIZE to check for HAVE_STRUCT_STAT_ST_BLKSIZE instead.
Patches are against HEAD of Nov 4/5.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=310894&aid=2892871&group_id=10894

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Tcl-Bugs mailing list
Tcl-Bugs@...
https://lists.sourceforge.net/lists/listinfo/tcl-bugs