[1.4.19] email-address from LDAP addressbook is not properly quoted

View: New views
19 Messages — Rating Filter:   Alert me  

[1.4.19] email-address from LDAP addressbook is not properly quoted

by Ralf Hildebrandt :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

When I'm retrieving an address from LDAP, then the realname containing an
Umlaut not being properly quoted.

I retrieved the message below with "less" from the Sent-folder:

--- snip ---
Date: Thu, 23 Jul 2009 10:19:26 +0200
Subject: Test michael.roemer@...
From: "Ralf Hildebrandt" <ralf.hildebrandt@...>
To: =?iso-8859-1?Q?R=F6mer=2C_Michael?= <michael.roemer@...>
User-Agent: SquirrelMail/1.4.19
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: 8bit

Und nochmal mit LDAP Adressbuch
--- snip ---

As you can see =?iso-8859-1?Q?R=F6mer=2C_Michael?= translates to
Römer, Michael
instead of the correct form
"Römer, Michael"

The interesting thing is that (see PNG here: http://www.arschkrebs.de/roemer.png )
the compose screen actually displayed:

"Römer, Michael" <michael.roemer@...>

WITH the correct quotes around the realname but in the Sent-Folder it
looks differently. Even using SquirrelMail to look in the Sent folder I'm
getting:

An:     Römer, Michael <michael.roemer@...>

again, without the quotes.

So where have the quotes gone? Something is stripping the quotes away
in the To: field. If I copy the To: field into the Subject: field, the
Quotes are preserved!

SquirrelMail 1.4.19 on Linux
  Installed Plugins
      1. translate
      2. squirrelspell
      3. newmail
      4. sent_subfolders
      5. message_details
      6. delete_move_next
      7. abook_import_export
      8. addgraphics
      9. attachment_tnef
     10. compatibility
     11. cookie_warning
     12. folder_sizes
     13. avelsieve
     14. ldapquery
     15. pupdate
     16. vlogin
     17. verify_reply_to
     18. vacation
     19. unsafe_image_rules
     20. todo
     21. squirrel_logger
     22. change_pass
     23. calendar
     24. calendar_sql_backend
     25. view_as_html
     26. address_add
     27. bounce
     28. naguser
     29. filters
     30. mailnotify
     31. quicksave
     32. timeout_user
     33. check_quota
     34. lockout
     35. show_user_and_ip
     36. smime
           

------------------------------------------------------------------------------
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Paul Lesniewski :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Thu, Jul 23, 2009 at 1:47 AM, Ralf Hildebrandt
<Ralf.Hildebrandt@...> wrote:
> When I'm retrieving an address from LDAP, then the realname containing an
> Umlaut not being properly quoted.

Please try the attached patch.  I'm not sure yet if this is a good
fix, as it may affect other parts of the software.  If you are
interested in helping, you can test this patch by using SquirrelMail
as extensively as possible, and by also watching for my post about it
on the development and/or i18n mailing lists a bit later today.

> I retrieved the message below with "less" from the Sent-folder:
>
> --- snip ---
> Date: Thu, 23 Jul 2009 10:19:26 +0200
> Subject: Test michael.roemer@...
> From: "Ralf Hildebrandt" <ralf.hildebrandt@...>
> To: =?iso-8859-1?Q?R=F6mer=2C_Michael?= <michael.roemer@...>
> User-Agent: SquirrelMail/1.4.19
> MIME-Version: 1.0
> Content-Type: text/plain;charset=iso-8859-1
> Content-Transfer-Encoding: 8bit
>
> Und nochmal mit LDAP Adressbuch
> --- snip ---
>
> As you can see =?iso-8859-1?Q?R=F6mer=2C_Michael?= translates to
> Römer, Michael
> instead of the correct form
> "Römer, Michael"
>
> The interesting thing is that (see PNG here: http://www.arschkrebs.de/roemer.png )
> the compose screen actually displayed:
>
> "Römer, Michael" <michael.roemer@...>
>
> WITH the correct quotes around the realname but in the Sent-Folder it
> looks differently. Even using SquirrelMail to look in the Sent folder I'm
> getting:
>
> An:        Römer, Michael <michael.roemer@...>
>
> again, without the quotes.
>
> So where have the quotes gone? Something is stripping the quotes away
> in the To: field. If I copy the To: field into the Subject: field, the
> Quotes are preserved!
>
> SquirrelMail 1.4.19 on Linux
>  Installed Plugins
>      1. translate
>      2. squirrelspell
>      3. newmail
>      4. sent_subfolders
>      5. message_details
>      6. delete_move_next
>      7. abook_import_export
>      8. addgraphics
>      9. attachment_tnef
>     10. compatibility
>     11. cookie_warning
>     12. folder_sizes
>     13. avelsieve
>     14. ldapquery
>     15. pupdate
>     16. vlogin
>     17. verify_reply_to
>     18. vacation
>     19. unsafe_image_rules
>     20. todo
>     21. squirrel_logger
>     22. change_pass
>     23. calendar
>     24. calendar_sql_backend
>     25. view_as_html
>     26. address_add
>     27. bounce
>     28. naguser
>     29. filters
>     30. mailnotify
>     31. quicksave
>     32. timeout_user
>     33. check_quota
>     34. lockout
>     35. show_user_and_ip
>     36. smime
>
>
> ------------------------------------------------------------------------------
> -----
> squirrelmail-users mailing list
> Posting guidelines: http://squirrelmail.org/postingguidelines
> List address: squirrelmail-users@...
> List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
> List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users


--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

quote_encoded_addresses.diff (2K) Download Attachment

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Ralf Hildebrandt :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

> > When I'm retrieving an address from LDAP, then the realname containing an
> > Umlaut not being properly quoted.
>
> Please try the attached patch.  I'm not sure yet if this is a good
> fix, as it may affect other parts of the software.  If you are
> interested in helping, you can test this patch by using SquirrelMail
> as extensively as possible, and by also watching for my post about it
> on the development and/or i18n mailing lists a bit later today.

This patch renders my server inoperable. It drives the load from 2.57
avg. up to 121 (!) in a few minutes.

Interestingly, it seems to work though :)

--
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebrandt@... | http://www.charite.de
           

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Paul Lesniewski :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Tue, Sep 29, 2009 at 6:49 AM, Ralf Hildebrandt
<Ralf.Hildebrandt@...> wrote:

>> > When I'm retrieving an address from LDAP, then the realname containing an
>> > Umlaut not being properly quoted.
>>
>> Please try the attached patch.  I'm not sure yet if this is a good
>> fix, as it may affect other parts of the software.  If you are
>> interested in helping, you can test this patch by using SquirrelMail
>> as extensively as possible, and by also watching for my post about it
>> on the development and/or i18n mailing lists a bit later today.
>
> This patch renders my server inoperable. It drives the load from 2.57
> avg. up to 121 (!) in a few minutes.

Huh.  Obviously more analysis is needed.  Are you absolutely sure this
was the only thing you changed before the load skyrocketed?  If it
caused this kind of load, it seems like you would have noticed a part
of the software that became noticeably slower -- did you or your users
notice anything like that?

> Interestingly, it seems to work though :)

--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Paul Lesniewski :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Tue, Sep 29, 2009 at 10:04 AM, Paul Lesniewski <paul@...> wrote:

> On Tue, Sep 29, 2009 at 6:49 AM, Ralf Hildebrandt
> <Ralf.Hildebrandt@...> wrote:
>>> > When I'm retrieving an address from LDAP, then the realname containing an
>>> > Umlaut not being properly quoted.
>>>
>>> Please try the attached patch.  I'm not sure yet if this is a good
>>> fix, as it may affect other parts of the software.  If you are
>>> interested in helping, you can test this patch by using SquirrelMail
>>> as extensively as possible, and by also watching for my post about it
>>> on the development and/or i18n mailing lists a bit later today.
>>
>> This patch renders my server inoperable. It drives the load from 2.57
>> avg. up to 121 (!) in a few minutes.
>
> Huh.  Obviously more analysis is needed.  Are you absolutely sure this
> was the only thing you changed before the load skyrocketed?  If it
> caused this kind of load, it seems like you would have noticed a part
> of the software that became noticeably slower -- did you or your users
> notice anything like that?
>
>> Interestingly, it seems to work though :)

If you are willing to sacrifice usability of your machine for another
five minutes, you can try re-applying that patch, then changing the
following lines in functions/mime.php:

1) comment out line 792 so it looks like:

            //case '"':

2) change line 843 so it looks like:

                if ($k > 126 || $string{$i} == '"') {

I think this will have the same result, but having a real world test
to help verify would be a big help.  It seems that encoding quotes
makes too much use of this code, but the only other fix is to rewrite
the function parseAddress in the Rfc822Header class because it tries
to parse by and then strip out quotes regardless of if they are
embedded in an encoded part of the string.

--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Ralf Hildebrandt :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

* Paul Lesniewski <paul@...>:

> > This patch renders my server inoperable. It drives the load from 2.57
> > avg. up to 121 (!) in a few minutes.
>
> Huh.  Obviously more analysis is needed.  Are you absolutely sure this
> was the only thing you changed before the load skyrocketed?

Yes. I applied the patch - and the load rose. I "patch -R"-ed the
patch, all back to normal.

> If it caused this kind of load, it seems like you would have noticed a
> part of the software that became noticeably slower -- did you or your
> users notice anything like that?

SM completely ceased to work.

--
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebrandt@... | http://www.charite.de
           

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Ralf Hildebrandt :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

> If you are willing to sacrifice usability of your machine for another
> five minutes, you can try re-applying that patch, then changing the
> following lines in functions/mime.php:
>
> 1) comment out line 792 so it looks like:
>
>             //case '"':
>
> 2) change line 843 so it looks like:
>
>                 if ($k > 126 || $string{$i} == '"') {
>
> I think this will have the same result, but having a real world test
> to help verify would be a big help.  It seems that encoding quotes
> makes too much use of this code, but the only other fix is to rewrite
> the function parseAddress in the Rfc822Header class because it tries
> to parse by and then strip out quotes regardless of if they are
> embedded in an encoded part of the string.

I applied that patch and made the changes you mention above.
The machine is working fine (load still 2.46 just like befor applying
the patch!), and the patch seems to work.

--
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebrandt@... | http://www.charite.de
           

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Paul Lesniewski :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, Sep 30, 2009 at 12:33 AM, Ralf Hildebrandt
<Ralf.Hildebrandt@...> wrote:

> * Paul Lesniewski <paul@...>:
>
>> > This patch renders my server inoperable. It drives the load from 2.57
>> > avg. up to 121 (!) in a few minutes.
>>
>> Huh.  Obviously more analysis is needed.  Are you absolutely sure this
>> was the only thing you changed before the load skyrocketed?
>
> Yes. I applied the patch - and the load rose. I "patch -R"-ed the
> patch, all back to normal.
>
>> If it caused this kind of load, it seems like you would have noticed a
>> part of the software that became noticeably slower -- did you or your
>> users notice anything like that?
>
> SM completely ceased to work.

I don't understand that.  You said it seemed to fix the issue.  SM
*works* for me with the patch, so it's not that it doesn't work.  I'm
looking for what actions become problematic...


--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Paul Lesniewski :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, Sep 30, 2009 at 12:42 AM, Ralf Hildebrandt
<Ralf.Hildebrandt@...> wrote:

>> If you are willing to sacrifice usability of your machine for another
>> five minutes, you can try re-applying that patch, then changing the
>> following lines in functions/mime.php:
>>
>> 1) comment out line 792 so it looks like:
>>
>>             //case '"':
>>
>> 2) change line 843 so it looks like:
>>
>>                 if ($k > 126 || $string{$i} == '"') {
>>
>> I think this will have the same result, but having a real world test
>> to help verify would be a big help.  It seems that encoding quotes
>> makes too much use of this code, but the only other fix is to rewrite
>> the function parseAddress in the Rfc822Header class because it tries
>> to parse by and then strip out quotes regardless of if they are
>> embedded in an encoded part of the string.
>
> I applied that patch and made the changes you mention above.
> The machine is working fine (load still 2.46 just like befor applying
> the patch!), and the patch seems to work.

Thanks.  I'm a bit surprised at this, so I would appreciate knowing if
your load remains normal after another day or more of running this
code.

Thank you.

--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Paul Lesniewski :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, Sep 30, 2009 at 1:28 AM, Paul Lesniewski <paul@...> wrote:

> On Wed, Sep 30, 2009 at 12:42 AM, Ralf Hildebrandt
> <Ralf.Hildebrandt@...> wrote:
>>> If you are willing to sacrifice usability of your machine for another
>>> five minutes, you can try re-applying that patch, then changing the
>>> following lines in functions/mime.php:
>>>
>>> 1) comment out line 792 so it looks like:
>>>
>>>             //case '"':
>>>
>>> 2) change line 843 so it looks like:
>>>
>>>                 if ($k > 126 || $string{$i} == '"') {
>>>
>>> I think this will have the same result, but having a real world test
>>> to help verify would be a big help.  It seems that encoding quotes
>>> makes too much use of this code, but the only other fix is to rewrite
>>> the function parseAddress in the Rfc822Header class because it tries
>>> to parse by and then strip out quotes regardless of if they are
>>> embedded in an encoded part of the string.
>>
>> I applied that patch and made the changes you mention above.
>> The machine is working fine (load still 2.46 just like befor applying
>> the patch!), and the patch seems to work.
>
> Thanks.  I'm a bit surprised at this, so I would appreciate knowing if
> your load remains normal after another day or more of running this
> code.

And if you're feeling even more adventurous, might I ask you to revert
these changes and try the original patch again to be double sure it
kills the machine?  It's just that this second version shouldn't be
that different than the first....


--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Ralf Hildebrandt :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

> > SM completely ceased to work.
>
> I don't understand that.  You said it seemed to fix the issue.

Yes, it fixed the issue when I tested it, but at the same time it was
driving the load higher and higher up to the point where the whole
machine wouldn't respond to anything.

> SM *works* for me with the patch, so it's not that it doesn't work.

it works, but not with 1000 simultaneous connections, for that your
adapted patch works ok

--
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebrandt@... | http://www.charite.de
           

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Ralf Hildebrandt :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

* Paul Lesniewski <paul@...>:

> > I applied that patch and made the changes you mention above.
> > The machine is working fine (load still 2.46 just like befor applying
> > the patch!), and the patch seems to work.
>
> Thanks.  I'm a bit surprised at this, so I would appreciate knowing if
> your load remains normal after another day or more of running this
> code.

I'll keep the code in place unless the load rises...

--
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebrandt@... | http://www.charite.de
           

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Ralf Hildebrandt :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

* Paul Lesniewski <paul@...>:

> And if you're feeling even more adventurous, might I ask you to revert
> these changes and try the original patch again to be double sure it
> kills the machine?  It's just that this second version shouldn't be
> that different than the first....

Done. Machine still working. I don't understand this :(

--
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebrandt@... | http://www.charite.de
           

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Paul Lesniewski :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, Sep 30, 2009 at 5:12 AM, Ralf Hildebrandt
<Ralf.Hildebrandt@...> wrote:
> * Paul Lesniewski <paul@...>:
>
>> And if you're feeling even more adventurous, might I ask you to revert
>> these changes and try the original patch again to be double sure it
>> kills the machine?  It's just that this second version shouldn't be
>> that different than the first....
>
> Done. Machine still working. I don't understand this :(

Ralf, thanks a lot for being so willing to test this in your
production environment.  Unfortunately, this makes things a little
more difficult to understand.  :-)  Hmmm.

--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Paul Lesniewski :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, Sep 30, 2009 at 11:19 AM, Paul Lesniewski <paul@...> wrote:

> On Wed, Sep 30, 2009 at 5:12 AM, Ralf Hildebrandt
> <Ralf.Hildebrandt@...> wrote:
>> * Paul Lesniewski <paul@...>:
>>
>>> And if you're feeling even more adventurous, might I ask you to revert
>>> these changes and try the original patch again to be double sure it
>>> kills the machine?  It's just that this second version shouldn't be
>>> that different than the first....
>>
>> Done. Machine still working. I don't understand this :(
>
> Ralf, thanks a lot for being so willing to test this in your
> production environment.  Unfortunately, this makes things a little
> more difficult to understand.  :-)  Hmmm.

It may be possible that it's just one particular action or email
message content that triggers a problem with this patch - in which
case maybe SM gets caught in an endless loop eating all your server
memory or the likes.  You didn't happen to notice a runaway httpd
thread when the load was skyrocketing, did you?

--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Ralf Hildebrandt :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

* Paul Lesniewski <paul@...>:

> It may be possible that it's just one particular action or email
> message content that triggers a problem with this patch - in which
> case maybe SM gets caught in an endless loop eating all your server
> memory or the likes.  You didn't happen to notice a runaway httpd
> thread when the load was skyrocketing, did you?

Well, I INITIALLY applied the patch during daytime, at the time of
highest load. Maybe that was unwise and caused the runaway condition...

--
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebrandt@... | http://www.charite.de
           

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Paul Lesniewski :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, Sep 30, 2009 at 12:15 PM, Ralf Hildebrandt
<Ralf.Hildebrandt@...> wrote:

> * Paul Lesniewski <paul@...>:
>
>> It may be possible that it's just one particular action or email
>> message content that triggers a problem with this patch - in which
>> case maybe SM gets caught in an endless loop eating all your server
>> memory or the likes.  You didn't happen to notice a runaway httpd
>> thread when the load was skyrocketing, did you?
>
> Well, I INITIALLY applied the patch during daytime, at the time of
> highest load. Maybe that was unwise and caused the runaway condition...

So can I infer that the second version was never used during peak
time?  (and also that it has not been peak time yet since you reverted
to the first version?)

--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Ralf Hildebrandt :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

* Paul Lesniewski <paul@...>:

> > Well, I INITIALLY applied the patch during daytime, at the time of
> > highest load. Maybe that was unwise and caused the runaway condition...
>
> So can I infer that the second version was never used during peak
> time?  (and also that it has not been peak time yet since you reverted
> to the first version?)

Both versions were used at peak time.
(and the inital version you provided is still running at the moment)

--
Ralf Hildebrandt
  Geschäftsbereich IT | Abteilung Netzwerk
  Charité - Universitätsmedizin Berlin
  Campus Benjamin Franklin
  Hindenburgdamm 30 | D-12203 Berlin
  Tel. +49 30 450 570 155 | Fax: +49 30 450 570 962
  ralf.hildebrandt@... | http://www.charite.de
           

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Re: [1.4.19] email-address from LDAP addressbook is not properly quoted

by Paul Lesniewski :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Thu, Oct 1, 2009 at 1:08 AM, Ralf Hildebrandt
<Ralf.Hildebrandt@...> wrote:

> * Paul Lesniewski <paul@...>:
>
>> > Well, I INITIALLY applied the patch during daytime, at the time of
>> > highest load. Maybe that was unwise and caused the runaway condition...
>>
>> So can I infer that the second version was never used during peak
>> time?  (and also that it has not been peak time yet since you reverted
>> to the first version?)
>
> Both versions were used at peak time.
> (and the inital version you provided is still running at the moment)

Well, you've certainly done your fair share of helping.  The load
issue is a bit unnerving... anyone else able to test this before I
commit it?

--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users