#10445: gtkutils.c purple_request_choice no translation for OK and Cancel buttons

[Pidgin]

#10445: gtkutils.c purple_request_choice no translation for OK and Cancel buttons
----------------------+-----------------------------------------------------
Reporter:  adiroiban  |        Type:  defect      
  Status:  new        |   Component:  pidgin (gtk)
 Version:  2.6.2      |    Keywords:  i18n        
----------------------+-----------------------------------------------------
 The purple_request_choice function calls from pidgin/gtkutils.c does not
 have the OK and Cancel text marked for translation.

 I have attached a quick patch.

 Maybe a better sollution would be to remove the user passed "OK" and
 "Cancel" char* from function call and use the GTK_STOCK buttons.

--
Ticket URL: <http://developer.pidgin.im/ticket/10445>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10445: gtkutils.c purple_request_choice no translation for OK and Cancel buttons
-----------------------+----------------------------------------------------
 Reporter:  adiroiban  |        Owner:              
     Type:  patch      |       Status:  new        
Milestone:             |    Component:  pidgin (gtk)
  Version:  2.6.2      |   Resolution:              
 Keywords:  i18n       |  
-----------------------+----------------------------------------------------
Changes (by MarkDoliner):

  * type:  defect => patch


--
Ticket URL: <http://developer.pidgin.im/ticket/10445#comment:1>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10445: gtkutils.c purple_request_choice no translation for OK and Cancel buttons
-----------------------+----------------------------------------------------
 Reporter:  adiroiban  |        Owner:              
     Type:  patch      |       Status:  new        
Milestone:             |    Component:  pidgin (gtk)
  Version:  2.6.2      |   Resolution:              
 Keywords:  i18n       |  
-----------------------+----------------------------------------------------

Comment(by deryni):

 Do you run pidgin with a translation? So you see English OK and Cancel
 button labels? With your patch applied do you see the correct GTK+ stock
 buttons instead? The request_choice UI function attempts to map stock
 button text to stock buttons, however it attempts to match against
 translated strings and since the calls you are patching don't translate
 the strings that will not match.

--
Ticket URL: <http://developer.pidgin.im/ticket/10445#comment:2>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10445: gtkutils.c purple_request_choice no translation for OK and Cancel buttons
-----------------------------------------+----------------------------------
 Reporter:  adiroiban                    |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.6.2                        |   Resolution:              
 Keywords:  i18n                         |  
-----------------------------------------+----------------------------------
Changes (by MarkDoliner):

  * milestone:  => Patches Needing Improvement


--
Ticket URL: <http://developer.pidgin.im/ticket/10445#comment:3>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker