#10576: pidgin crashes when try to send SMS message via skype plugin

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
-------------------+--------------------------------------------------------
Reporter:  walder  |        Type:  defect
  Status:  new     |   Component:  plugins
 Version:  2.6.3   |    Keywords:  crash  
-------------------+--------------------------------------------------------
 crash is due to unconditional pointer de-reference  in cap.c:97:

         if(strcmp(purple_status_get_id(get_status_for(buddy)), "offline")
 == 0) {
                 /* This is kind of stupid, change it. */
                 if(prediction == 1.0f)
                         prediction = 0.0f;
         }

 trivial patch to fix that attached

--
Ticket URL: <http://developer.pidgin.im/ticket/10576>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  new    
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------
Changes (by datallah):

  * type:  defect => patch


--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:1>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  new    
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------
Changes (by darkrain42):

 * cc: BigBrownChunx (added)


Comment:

 Shouldn't all buddies have a valid !PurpleStatus?

 Eion?

--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:2>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  new    
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------

Comment(by BigBrownChunx):

 Should do.  My guess is that the buddy hasn't been added to the buddy
 list, so may not have a PurpleStatus because of that?

--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:3>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  new    
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------

Comment(by walder):

 This is buddy provided by Skype plugin. And not just usual skype im buddy,
 but just phone number (for skype out calls).
 Skype plugin provides an a way to send SMS here also (did not tried direct
 calls yet)

 This buddy shown in buddy list, and bug triggered when I move mouse over
 buddy.

 Also there was stats for that buddy in .purple/cap.db:

 After apply patch it shows now:
 sqlite> select count(*) from cap_msg_count where buddy = 'katerisska';
 106
 sqlite> select * from cap_status_count where buddy = 'katerisska';
 katerisska|vgrebenschikov|prpl-bigbrownchunx-skype|AWAY|1|2
 katerisska|vgrebenschikov|prpl-bigbrownchunx-skype|NA|0|3
 katerisska|vgrebenschikov|prpl-bigbrownchunx-skype|OFFLINE|1|0
 katerisska|vgrebenschikov|prpl-bigbrownchunx-skype|ONLINE|116|16

 Before apply patch it also saw multiple entries in cap_msg_count and only
 offline
 row in cap_status_count.

 Did not dig dipper.

--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:4>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  pending
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------
Changes (by darkrain42):

  * status:  new => pending


Comment:

 Replying to [comment:3 BigBrownChunx]:
 > Should do.  My guess is that the buddy hasn't been added to the buddy
 list, so may not have a PurpleStatus because of that?

 No, the !PurplePresence is associated with a buddy in `purple_buddy_new`.
 Unless the plugin creates a !PurpleBuddy manually (i.e. g_new0), this
 really shouldn't ever happen.

 walder, what version of the plugin are you using? Make sure it's the most
 recent.

--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:5>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  pending
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------
Changes (by walder):

  * status:  pending => new


Comment:

 Recent FreeBSD port:

 Pidgin 2.6.3
 (libpurple 2.6.3)
 e37623b5567c442c6771daf90fc175ae7898a10b

 and Contact Availability Prediction 2.6.3 plugin
 and http://skype4pidgin.googlecode.com/svn/trunk revision 538

--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:6>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  new    
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------

Comment(by walder):

 hm... looks like skype4pidgin uses g_new0

 $ fgrep -r g_new0 skype4pidgin
 ./skype_events.c:                       skypemessage =
 g_new0(SkypeMessage, 1);
 ./skype_events.c:                       type = g_new0(gchar, 9);
 ./skype_events.c:               chat = g_new0(SkypeChat, 1);
 ./skype_messaging_x11.c:                        e = g_new0(XEvent, 1);
 ./libskype.c:                                   sbuddy = buddy->proto_data
 = g_new0(SkypeBuddy, 1);
 ./libskype.c:                                   sbuddy = buddy->proto_data
 = g_new0(SkypeBuddy, 1);
 ./libskype.c:   SkypeBuddy *newbuddy = g_new0(SkypeBuddy, 1);
 ./libskype.c:   pce = g_new0(struct proto_chat_entry, 1);
 $

--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:7>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  new    
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------

Comment(by BigBrownChunx):

 ...but not for !PurpleBuddy

--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:8>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  pending
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------
Changes (by darkrain42):

  * status:  new => pending


Comment:

 Could you unapply the patch and reproduce the crash with gdb, please? When
 it crashes, run these commands:

   * "print *buddy"
   * "print *buddy->presence"
   * "print *(PurpleStatus *)buddy->presence->statuses->data"

--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:9>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  pending
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------

Comment(by darkrain42):

 (without the quotes)

--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:10>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  pending
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------
Changes (by walder):

  * status:  pending => new


Comment:

 Below gdb output, *buddy was not available in context, I guess due to
 optimizations, so I just step into function to get results.


 (gdb) b cap.c:94
 (gdb) c
 Continuing.
 [New Thread 4c604cc0 (LWP 100290)]
 [New Thread 4c604b80 (LWP 100324)]
 [Thread 4c604b80 (LWP 100324) exited]
 [Thread 4c604cc0 (LWP 100290) exited]
 [New Thread 4c604a40 (LWP 100290)]
 [Thread 4c604a40 (LWP 100290) exited]
 [New Thread 4c604900 (LWP 100290)]
 [New Thread 4c6047c0 (LWP 100324)]
 [Thread 4c6047c0 (LWP 100324) exited]
 [Thread 4c604900 (LWP 100290) exited]
 [Switching to Thread 49201140 (LWP 100168)]

 Breakpoint 1, get_stats_for (buddy=Variable "buddy" is not available.
 ) at cap.c:94
 94              sqlite3_free(sql);
 Breakpoint 1, get_stats_for (buddy=Variable "buddy" is not available.
 ) at cap.c:94
 94              sqlite3_free(sql);
 (gdb) n
 97              if(strcmp(purple_status_get_id(get_status_for(buddy)),
 "offline") == 0) {
 (gdb) print *buddy
 Variable "buddy" is not available.
 (gdb) s
 94              sqlite3_free(sql);
 (gdb) s
 97              if(strcmp(purple_status_get_id(get_status_for(buddy)),
 "offline") == 0) {
 (gdb) s
 get_status_for (buddy=0x4a724cc0) at cap.c:504
 504             PurplePresence *presence =
 purple_buddy_get_presence(buddy);
 (gdb) print *buddy
 $1 = {node = {type = PURPLE_BLIST_BUDDY_NODE, prev = 0x0, next =
 0x4a724d00, parent = 0x4a724c80, child = 0x0, settings = 0x4a719e90,
 ui_data = 0x4a72e2e0, flags = 0},
   name = 0x4a72aae0 "225302010", alias = 0x4a72aaf0 "katerina",
 server_alias = 0x0, proto_data = 0x0, icon = 0x4d1faf00, account =
 0x4954c0a0, presence = 0x4a72c1f0}
 (gdb) print *buddy->presence
 $2 = {context = 1249004736, idle = 19, idle_time = 11591, login_time = 0,
 statuses = 0x3f, status_table = 0xc, active_status = 0x3, u = {account =
 0xe, chat = {conv = 0xe,
       user = 0x3a <Error reading address 0x3a: Bad address>}, buddy =
 {account = 0xe, name = 0x3a <Error reading address 0x3a: Bad address>,
 buddy = 0xb}}}
 (gdb) print *(PurpleStatus *)buddy->presence->statuses->data
 $3 = {type = 0x4954bb20, presence = 0x4a72c1f0, active = 0, attr_values =
 0x4a719cc0}
 (gdb) n
 [New Thread 4c604680 (LWP 100324)]
 [New Thread 4c604540 (LWP 100327)]
 [New Thread 4c604400 (LWP 100328)]
 [New Thread 4c6042c0 (LWP 100329)]
 [New Thread 4c604180 (LWP 100330)]
 505             PurpleStatus *status =
 purple_presence_get_active_status(presence);
 (gdb) n
 [Thread 4c604180 (LWP 100330) exited]
 [Thread 4c604400 (LWP 100328) exited]
 [Thread 4c604540 (LWP 100327) exited]
 [Thread 4c604680 (LWP 100324) exited]

 Program received signal SIGTRAP, Trace/breakpoint trap.
 0x494ba3cd in get_status_for (buddy=Variable "buddy" is not available.
 ) at cap.c:505
 505             PurpleStatus *status =
 purple_presence_get_active_status(presence);
 (gdb) n
 [Thread 4c6042c0 (LWP 100329) exited]

 Program received signal SIGTRAP, Trace/breakpoint trap.
 0x494b9aa4 in ?? () from /usr/local/lib/pidgin/cap.so
 (gdb) bt
 #0  0x494b9aa4 in ?? () from /usr/local/lib/pidgin/cap.so
 #1  0x494ba3d2 in get_status_for (buddy=Variable "buddy" is not available.
 ) at cap.c:505
 #2  0x494baa87 in get_stats_for (buddy=Variable "buddy" is not available.
 ) at cap.c:97
 #3  0x494bac75 in drawing_tooltip (node=0x4a724cc0, text=0x4d1fd7b0,
 full=0) at cap.c:441
 #4  0x48a76696 in purple_marshal_VOID__POINTER_POINTER_UINT (cb=0x494bac50
 <drawing_tooltip>, args=0xbfbfe208 "�LrJ��\037M", data=0x0,
 return_val=0x0) at signals.c:680
 #5  0x48a770b7 in purple_signal_emit_vargs (instance=0x811b7d4,
 signal=0x810419d "drawing-tooltip", args=0xbfbfe208 "�LrJ��\037M") at
 signals.c:482
 #6  0x48a771ec in purple_signal_emit (instance=0x811b7d4, signal=0x810419d
 "drawing-tooltip") at signals.c:434
 #7  0x0808239a in create_tip_for_node (node=0x4a724cc0, full=0) at
 gtkblist.c:3779
 #8  0x08083284 in pidgin_blist_create_tooltip_for_node (widget=0x4a507e60,
 data=0x4a724c80, w=0xbfbfe310, h=0xbfbfe314) at gtkblist.c:3229
 #9  0x080833c9 in pidgin_blist_create_tooltip (widget=0x4a507e60,
 path=0x4dcae3d0, null=0x0, w=0xbfbfe310, h=0xbfbfe314) at gtkblist.c:3397
 #10 0x08100e20 in pidgin_tooltip_timeout (data=0x4a7f8d20) at
 pidgintooltip.c:284
 #11 0x48e10c56 in g_source_get_current_time () from
 /usr/local/lib/libglib-2.0.so.0
 #12 0x48e10519 in g_main_context_dispatch () from
 /usr/local/lib/libglib-2.0.so.0
 #13 0x48e13766 in g_main_context_check () from
 /usr/local/lib/libglib-2.0.so.0
 #14 0x48e13aa7 in g_main_loop_run () from /usr/local/lib/libglib-2.0.so.0
 #15 0x482d9824 in gtk_main () from /usr/local/lib/libgtk-x11-2.0.so.0
 #16 0x080c6791 in main (argc=Error accessing memory address 0x0: Bad
 address.
 ) at gtkmain.c:916
 (gdb)

--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:11>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  pending
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------
Changes (by darkrain42):

  * status:  new => pending


Comment:

 Could you please re-run Pidgin in valgrind now?  Something is corrupting
 the memory of the !PurpleBuddy.

 valgrind --leak-check=no --track-origins=yes --malloc-fill=0xfe --free-
 fill=0xfe

--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:12>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#10576: pidgin crashes when try to send SMS message via skype plugin
--------------------+-------------------------------------------------------
 Reporter:  walder  |        Owner:        
     Type:  patch   |       Status:  closed
Milestone:          |    Component:  plugins
  Version:  2.6.3   |   Resolution:        
 Keywords:  crash   |  
--------------------+-------------------------------------------------------
Changes (by trac-robot):

  * status:  pending => closed


Comment:

 This ticket was closed automatically by the system.  It was previously set
 to a Pending status and hasn't been updated within 14 days.

--
Ticket URL: <http://developer.pidgin.im/ticket/10576#comment:13>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker