#4508: Custom Icons (XStatuses) support in ICQ
|
View:
New views
20 Messages
—
Rating Filter:
Alert me
|
| < Prev | 1 - 2 - 3 - 4 - 5 | Next > |
 |
#4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
---------------------+------------------------------------------------------ Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: new Priority: minor | Component: ICQ Version: 2.3.1 | Keywords: Custom Icon XStatuses ICQ Pending: 0 | ---------------------+------------------------------------------------------ I've implemented support for custom user icons (XStatuses) in libpurple (in the same manner as it is in QIP). XStatus shows in buddy list as a picture and it's possible to select personal XStatus for particular ICQ account as well (via "Set Custom Icon..." item in account's menu). According to different mailing lists this feature is highly desirable by many users (http://developer.pidgin.im/ticket/766) so I'm looking forward to get it included into Pidgin. Extract icons to to $PIDGIN_DEV_ROOT/pidgin-<version>/pidgin/pixmaps/emblems/16 -- Ticket URL: <http://developer.pidgin.im/ticket/4508> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Changes (by MarkDoliner): * status: new => assigned Comment: This looks pretty good to me. I'm a little concerned that you keep track of which icon the person is using by storing the offset into the aim_custom_icons array. Would it be possible to store the filename, instead? Or, the part of the filename without the underscore? So, "shopping," for example? And the filenames... is there any reason they start with an underscore? It seems like it would be much more descriptive to call them "xstatus_shopping.png" or something. -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:1> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by minstrel): Well, it seems to me that it's better to store the offset than the filename. We might need to retrieve a string status description or GUID or whatever else for the certian status in the future. If we store just the file name it would be hard to do... I've changed the filenames to xstatus_xxx.png. There was no reason for them to start witn an underscore. Patch and icons are attached. -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:2> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by r-wolf): Somebody's contact X-status change is displayed only after my reconnect. Contacts without X-status are displayed as "Thinking". X-status at chat window changes to "Thinking" spontaneously. -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:3> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by r-wolf): When main status is different from "Online", then X-status is not displayed. [[BR]] It would be good to see X-status comment strings somewhere at the roster. -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:4> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by minstrel): Replying to [comment:3 r-wolf]: > Somebody's contact X-status change is displayed only after my reconnect. > Contacts without X-status are displayed as "Thinking". > X-status at chat window changes to "Thinking" spontaneously. I've fixed the issue with spontaneous "Thinking" X-Status. Attaching new patch. -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:5> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by Coder_ak): Perfect! How about X-Status text? Read and write my own? -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:6> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by minstrel): well, i would definitely like to help with that but only after i see this patch applied to one of the future versions. i want to be sure i'm not just wasting my time which is very limited... -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:7> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by Robby): cc[[BR]] kthxbai -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:8> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by NightFox): I've written an X-Status text support feature to this patch. I can give that patch, but only if I'll be sure it will go to CVS. -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:9> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by minstrel): lol I had submitted my patch about 4 months ago but it haven't even been scheduled yet... The users keep asking me to make my custom builds with status icons after every new release. but who cares... -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:10> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by NightFox): Actually that's very sad :( -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:11> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by Sim-on): Is this one different from the patch in #766 ?[[BR]] I would rather close this ticket to have one ticket and one patch ?! Maybe you can compare and merge these two patches ? -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:12> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by petr.odut): NightFox: Can you please provide us your patch for Xstatus text? Many people would appreciate this! Thanks! -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:13> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by NightFox): I've added an attachment of my patch, which is based on minstrel's. Patch containing support of custom icons(X-Statues) with text support, text for your own x-status used from current status note. Manual "Get X-Status" button is working too. Some extra statuses such as "Depression", "At Work", "At Home" etc added too. Patch is for version 2.4.0. -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:14> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by ilovemistakes): oops again :([[BR]] to minstrel, sorry, but eidam655 said that he had "googled or smth" this patch, and i've never said that this is my patch, i've only slightly modified it. i only tried to make a temporary solution :) anyway, ticket closed.[[BR]] to Mark Doliner, i've warned that code is dirty. it was temporary and based on minstrel's (now i know the owner) patch. and i'm only user, not a programmer :) thanks for notes, memleak shocked me[[BR]] to minstrel and !NightFox, you guys have done really good job, thanks! :)[[BR]] so, may i post a patch based on !NightFox's patch that works on 2.4.1? or may be it would be more polite to leave it on my hdd? :)[[BR]] regards, Alexey -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:15> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by MarkDoliner): (I left these comments on ticket #766, but I should have left them here, so I'll copy/paste.) I really don't have any time to look at this in detail, but I glanced through customicons4.patch: * Why do the icon file names start with an underscore? * Where did the icons come from? Did someone make them? * Please don't use // style comments. Only /* */ * Why does purple_request_field_list_get_pixbuf() return a boolean? Based on the name shouldn't it return a pixbuf? * Maybe I'm missing something, but doesn't something need to free PurpleRequestField?->u.list.icons and PurpleRequestField?->u.list.icon_data? And where does PurpleRequestField?->u.list.icon_data get initialized? Is that hash table even used? * In gtkrequest.c, "if(icon == TRUE)" should be "if (icon)" * In family_locate.c, "if(customicon_found == FALSE)" should be "if (!customicon_found)" * There's also a little stray whitespace on some blank lines in family_locate.c * Could the parameter "no" for the aim_get_custom_icon functions be changed to maybe "n"? Or "number"? -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:16> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by MarkDoliner): Another question: * Is it possible to unset the icon for yourself? -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:17> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Comment (by ilovemistakes): Replying to [comment:16 MarkDoliner]: > * Where did the icons come from? Did someone make them? afair, same icons are used in QIP. > * Why does purple_request_field_list_get_pixbuf() return a boolean? Based on the name shouldn't it return a pixbuf? yes, i should name it as "get_iconed" or smth. > * Maybe I'm missing something, but doesn't something need to free PurpleRequestField?->u.list.icons and PurpleRequestField?->u.list.icon_data? And where does PurpleRequestField?->u.list.icon_data get initialized? omg, that's my fault, you're right. > Is that hash table even used? no, it isn't. > * Is it possible to unset the icon for yourself? yes, there is "None" item in "Set custom icon" dialog.[[BR]] no answer on other questions. [[BR]] btw, i think you should forget about "patch modifications" from #766. we have another, more featured now :) regards, Alexey -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:18> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
|
|
Re: #4508: Custom Icons (XStatuses) support in ICQ
by Pidgin
::
Rate this Message:
#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+---------------------------------------------------- Reporter: minstrel | Owner: MarkDoliner Type: patch | Status: assigned Priority: minor | Milestone: Component: ICQ | Version: 2.3.1 Resolution: | Keywords: Custom Icon XStatuses ICQ Pending: 0 | -----------------------+---------------------------------------------------- Changes (by Sim-on): * cc: hbons (added) Comment: > > * Where did the icons come from? Did someone make them? > afair, same icons are used in QIP. It would be nice to have some who match to other pidgin-smileys/status... hbons? :P -- Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:19> Pidgin <http://pidgin.im> Pidgin _______________________________________________ Tracker mailing list Tracker@... http://pidgin.im/cgi-bin/mailman/listinfo/tracker |
| < Prev | 1 - 2 - 3 - 4 - 5 | Next > |
| Free embeddable forum powered by Nabble | Forum Help |
