#4508: Custom Icons (XStatuses) support in ICQ

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by minstrel):

 i'll reply only to the questions which concern my patch:

 >  * Is it possible to unset the icon for yourself?
 yes. i've implemented that in my original patch.
 >  * Why do the icon file names start with an underscore?
 they do not (see the latest patch)
 >  * Where did the icons come from? Did someone make them?
 they are taken from QIP and should be replaced with another icons...
 sorry, i'm not a designer. that might be a good opportunity for some
 volunteer :)
 >  * Please don't use // style comments. Only /* */
 Sorry, i wasn't aware of it. That doesn't seem to be a big issue anyway.
 >  * Could the parameter "no" for the aim_get_custom_icon functions be
 changed to maybe "n"? Or "number"?
 sure. "number" seems ok to me. The same applies to:
 aim_get_custom_icon_filename(gint32 no)
 aim_get_custom_icon_descriptivename(gint32 no)
 aim_get_custom_icon_data(gint32 no)
 and that's not a big issue as well.

 i won't make another patch to fix these small issues since NightFox has
 the latest stuff right now. so go ahead, dude :)

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:20>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by petr.odut):

 The icons are from original ICQ client and I guess, they are under
 copyright. Some sort of tango-based icons would be definitely cool.

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:21>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by NightFox):

 I've seen X-Status icons in Kopete, maybe they're under GPL...

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:22>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by simbiot):

 Greets!
 There are a lot of x-status icons for miranda. http://addons.miranda-
 im.org/index.php?action=display&id=35
 They are basically under "Freeware" licence.
 What do you think?

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:23>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by eidam655):

 so... what's up?

 big halo around duplicating the ticket, blaming us for something we didn't
 do, and sudenly the development stops? :)

 nice.

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:24>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by lman):

 Could someone make a version for pidgin 2.4.1, please?

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:25>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by NightFox):

 hmm...why I should ?.. I can make, but... Will this patch will be applied
 to next release ?

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:26>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by eidam655):

 carrierist! :D

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:27>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by lman):

 Replying to [comment:26 NightFox]:
 > hmm...why I should ?.. I can make, but... Will this patch will be
 applied to next release ?
 all right, than don't. Is there any chance that you could make it less
 hidden in menus? Or just show somewhere the current xStatus state icon? Or
 integrate the xstatus chooser into the menus instead of showing another
 window. Thanks in advance

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:28>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by lman):

 BTW, there is a patched version of pidgin: funpidgin.
 http://funpidgin.sourceforge.net maybe they will apply this patch to next
 release ;)

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:29>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by resiak):

 Some remarks on a brief review of !NightFox's patch:

  * There's no point in adding commented-out calls to `purple_debug_*`.
 Either don't add them, or don't comment them out.
  * Please don't use `//` for comments; it's not supported in C89.
 Instead, use `/* */`.
  * A whole bunch of calls to `g_free`, and `return` statements, have been
 commented out.  This really can't be kosher.

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:30>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by petr.odut):

 Can you please write a command to patch pidgin? (something like:)
 patch -p1 < custom_icons4.patch
 but I have no idea about -pNUM switch :-\.

 Is there any difference between version 2.4.0 and 2.4.1, which make patch
 incompatible?
 Is there anybody, who is able to port improvements from ticket #766 patch?

 Thanks a lot for your work!

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:31>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by rlaager):

 NightFox: I would encourage you to drop into #pidgin on irc.freenode.net
 if you have questions about this patch. If you address the problems from
 resiak's comment, you'll be a lot closer to getting this accepted. You
 should remove any unnecessary code from the patch; there are currently a
 couple chunks of commented-out code. There are also a few unnecessary
 whitespace changes. A good practice for patch submission is to read the
 diff itself before you send it in.

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:32>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by rlaager):

 There are comments like this in the patch that I don't understand: /* 6 +
 4 = 10 + 8

 What are those numbers for?

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:33>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by rlaager):

 I also see changes of this type:
 - if (state & AIM_ICQ_STATE_CHAT)
 + if (state == AIM_ICQ_STATE_CHAT)

 Why is that being done? (I'm not saying it's wrong. I'm saying I don't
 understand this codebase, so I'm asking why.)

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:34>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by minstrel):

 You guys would better start from checking-in the original patch:
 custom_icons.3.patch
 I've submitted it 4!!! months ago and to me it seems to be completely
 straight forward.  I can't understand why you don't encourage people to
 write patches, improve pidgin etc, but do the opposite...

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:35>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by NightFox):

 because that-> if (state & AIM_ICQ_STATE_CHAT)  is illegal

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:36>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by elb):

 Replying to [comment:36 NightFox]:
 > because that-> if (state & AIM_ICQ_STATE_CHAT)  is illegal

 Why is it illegal?  It's simply a bit check for the AIM_ICQ_STATE_CHAT
 bit.

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:37>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by elb):

 Replying to [comment:35 minstrel]:
 > You guys would better start from checking-in the original patch:
 custom_icons.3.patch
 > I've submitted it 4!!! months ago and to me it seems to be completely
 straight forward.  I can't understand why you don't encourage people to
 write patches, improve pidgin etc, but do the opposite...

 I'm sorry you feel that anyone is "doing the opposite".  Please do not
 confuse lack of time for active discouragement.  The only reason this has
 not been dealt with before now is that the appropriate people did not have
 the time to do so.  There is no conspiracy theory here to keep your patch
 from proceeding.  :-)

 This patch (from minstrel) introduces some strings which should be
 translated, and unfortunately we are currently in string freeze; it looks
 like it can go in as soon as 2.4.2 is released with minimal changes.  (The
 spurious introduction of curpos, some unnecessary whitespace changes,
 correct the typo of "Engineering", fix some occurrences of //, reconcile
 some consts.)

 The patch from NightFox has some more serious issues and will require
 further review.

 In the future, if a patch which is complete and largely appropriate for
 inclusion is languishing in the tracker, feel free to come make some noise
 in #pidgin or devel@....  Once a patch has been claimed
 by a developer on the tracker, it often gets little attention from other
 developers (as do unclaimed patches which are in an area "belonging" to a
 particular developer); in consequence, if that developer gets busy or is
 unavailable for some reason, it can take a while to get it merged.  A
 friendly poke is all it might take to get it moving again, there's no need
 to feel like you're being ignored!

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:38>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by sadrul):

 It looks like custom_icons.3.patch and xstatus-patch-pidgin-2.4.0.patch
 are the most updated versions of the patch (the former looks cleaner). Is
 either of them in a state to be applied to .next.minor for 2.5.0?

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:39>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker