#4508: Custom Icons (XStatuses) support in ICQ

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by Sim-on):

 first we need an iconset!!! ;) hbons, did you read this? ;)

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:40>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by hbons):

 What kind of icons? I'm sorry, I'm not really following. It's been a while
 since I last used ICQ (> 10 years)

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:41>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by Sim-on):

 Replying to [comment:41 hbons]:
 > What kind of icons? I'm sorry, I'm not really following. It's been a
 while since I last used ICQ (> 10 years)

 have a look in
 [http://developer.pidgin.im/attachment/ticket/4508/custom_user_icons.tar.2.gz
 custom_user_icons.tar.2.gz]. This patch will include different status
 icons for e.g. gaming, coffee, eating,...

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:42>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by hbons):

 Ok. So in ICQ the status icon is replaced by those special icons?
 If it is, I think it's a better idea to have them as emblems tough. To
 keep the buddy status system clean.

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:43>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by petr.odut):

 it is done that way, please try this patch before commenting ;-)

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:44>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by Sim-on):

 hm in standard-ICQ these icons are replacing the status-icon but ok ;)

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:45>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by Coder_ak):

 Patched against version 2.4.2 some rejects but compiles without errors. No
 x-status text input field and no text in buddies profile

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:46>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by Sim-on):

 something new on this issue?
 i would like to see this feature in 2.5.0 ;) :P

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:47>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                
  Priority:  minor     |   Milestone:                          
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by eidam655):

 any news?

 does this work with 2.4.3?

 can we finally get/set custom status messages?

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:48>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
---------------------------------------+------------------------------------
 Reporter:  minstrel                   |        Owner:  MarkDoliner
     Type:  patch                      |       Status:  new        
Milestone:                             |    Component:  ICQ        
  Version:  2.3.1                      |   Resolution:            
 Keywords:  Custom Icon XStatuses ICQ  |  
---------------------------------------+------------------------------------

Comment(by Mentis):

 salieff, I try your patch and its goood =) Thaks! But i found 1 bug in it:

 If my friend (he use QIP)  fill only field2, i cant fetch his xstatus
 message. See this screenshots:

 What my frend do:
 [http://img397.imageshack.us/img397/4551/10182705bd9.jpg]
 What i see: [http://img359.imageshack.us/img359/8162/screenshottr3.png]

 But if he fill field1 also, everything works fine:
 [http://img355.imageshack.us/img355/4039/screenshot1oe8.png]

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:49>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
---------------------------------------+------------------------------------
 Reporter:  minstrel                   |        Owner:  MarkDoliner
     Type:  patch                      |       Status:  new        
Milestone:                             |    Component:  ICQ        
  Version:  2.3.1                      |   Resolution:            
 Keywords:  Custom Icon XStatuses ICQ  |  
---------------------------------------+------------------------------------

Comment(by sadrul):

 I can start committing the patch(es) (after some modification, since some
 of the raised concerns are not addressed yet) to some branch. But I don't
 have any ICQ buddies, so I won't be able to test any of these. If there's
 someone with time and will to build from a different branch in mtn and
 test the changes, let me know. (Sounds like Sim-on uses ICQ, do you also
 build from mtn?)

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:50>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
---------------------------------------+------------------------------------
 Reporter:  minstrel                   |        Owner:  MarkDoliner
     Type:  patch                      |       Status:  new        
Milestone:                             |    Component:  ICQ        
  Version:  2.3.1                      |   Resolution:            
 Keywords:  Custom Icon XStatuses ICQ  |  
---------------------------------------+------------------------------------

Comment(by Mentis):

 Replying to [comment:50 sadrul]:
 > I can start committing the patch(es) (after some modification, since
 some of the raised concerns are not addressed yet) to some branch. But I
 don't have any ICQ buddies, so I won't be able to test any of these. If
 there's someone with time and will to build from a different branch in mtn
 and test the changes, let me know. (Sounds like Sim-on uses ICQ, do you
 also build from mtn?)

 I can gladly help if you explain me where i can grab sources.

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:51>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
---------------------------------------+------------------------------------
 Reporter:  minstrel                   |        Owner:  MarkDoliner
     Type:  patch                      |       Status:  new        
Milestone:                             |    Component:  ICQ        
  Version:  2.3.1                      |   Resolution:            
 Keywords:  Custom Icon XStatuses ICQ  |  
---------------------------------------+------------------------------------

Comment(by Sim-on):

 Replying to [comment:50 sadrul]:
 > (Sounds like Sim-on uses ICQ, do you also build from mtn?)

 You can commit these patches :) i'm on windows but i once built from
 source so this won't be a problem :)
 and i have enought icq-friends for testing :)

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:52>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
---------------------------------------+------------------------------------
 Reporter:  minstrel                   |        Owner:  MarkDoliner
     Type:  patch                      |       Status:  new        
Milestone:                             |    Component:  ICQ        
  Version:  2.3.1                      |   Resolution:            
 Keywords:  Custom Icon XStatuses ICQ  |  
---------------------------------------+------------------------------------

Comment(by nops):

 The xstatus-patch-pidgin-2.5.1.patch is modified xstatus-patch-
 pidgin-2.5.0.patch for 2.5.1 source code. Added lost code from #776
 custom_icons4.patch (add icons in x-status icon dialog, eng'''e'''neering
 -> eng'''i'''neering) and small changes for some recommendation from
 MarkDoliner.

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:53>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
---------------------------------------+------------------------------------
 Reporter:  minstrel                   |        Owner:  MarkDoliner
     Type:  patch                      |       Status:  new        
Milestone:                             |    Component:  ICQ        
  Version:  2.3.1                      |   Resolution:            
 Keywords:  Custom Icon XStatuses ICQ  |  
---------------------------------------+------------------------------------

Comment(by eidam655):

 hello,

 i'm very glad of this patch working :)

 i just have a question - how does the "Get X-Status msg" option in a
 buddy's context menu work?

 because, some status x-status messages are loaded automatically and are
 shown, but with some buddies with the x-status set, there is no apparent
 status message.

 so, this raises the question: why is that option there?

 and another question: how do i set MY own x-status message? is there any
 possibility that the x-status message can be set from the global status
 setter?

 thank you for clearing this to me :)

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:54>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
---------------------------------------+------------------------------------
 Reporter:  minstrel                   |        Owner:  MarkDoliner
     Type:  patch                      |       Status:  new        
Milestone:                             |    Component:  ICQ        
  Version:  2.3.1                      |   Resolution:            
 Keywords:  Custom Icon XStatuses ICQ  |  
---------------------------------------+------------------------------------

Comment(by nops):

 Replying to [comment:54 eidam655]:
 > so, this raises the question: why is that option there?

 It was added in early patch, that has no autofetch function. Now, this no
 longer needed. But autofetch function need modification - on very big
 contact list fetch packets may overflow channel, and server may drop
 connection.

 > and another question: how do i set MY own x-status message? is there any
 possibility that the x-status message can be set from the global status
 setter?

 Yes, this is set from global status message.

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:55>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
---------------------------------------+------------------------------------
 Reporter:  minstrel                   |        Owner:  MarkDoliner
     Type:  patch                      |       Status:  new        
Milestone:                             |    Component:  ICQ        
  Version:  2.3.1                      |   Resolution:            
 Keywords:  Custom Icon XStatuses ICQ  |  
---------------------------------------+------------------------------------

Comment(by eidam655):

 Replying to [comment:55 nops]:
 > Replying to [comment:54 eidam655]:
 > > so, this raises the question: why is that option there?
 >
 > It was added in early patch, that has no autofetch function. Now, this
 no longer needed. But autofetch function need modification - on very big
 contact list fetch packets may overflow channel, and server may drop
 connection.

 Ah, I already noticed that - when many ICQ buddies are connected, i
 connect to the server, load the buddy list, and then i get the message
 "Connection closed by peer." at least i think it's because of that.
 >
 > > and another question: how do i set MY own x-status message? is there
 any possibility that the x-status message can be set from the global
 status setter?
 >
 > Yes, this is set from global status message.

 so... why can't i see it, when i have *me* in my contact list, ans after
 setting a status message, it appears on my MSN and Jabber accounts, but
 not on the ICQ - even after trying "Get X-Status message" several times.

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:56>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
---------------------------------------+------------------------------------
 Reporter:  minstrel                   |        Owner:  MarkDoliner
     Type:  patch                      |       Status:  new        
Milestone:                             |    Component:  ICQ        
  Version:  2.3.1                      |   Resolution:            
 Keywords:  Custom Icon XStatuses ICQ  |  
---------------------------------------+------------------------------------

Comment(by Gromescu):

 I have a strange bug with this patch - I can't read n/a, dnd and occupied
 statuses from all of my buddies except those who use qip. They are shown
 as available.

 Look at Test buddy logged in from qip

 http://pic.ipicture.ru/uploads/081028/b55mGJ64kD.png

 and from miranda

 http://pic.ipicture.ru/uploads/081028/anUddCV2b6.png

 Another is with users with away status when custom icon is not set

 http://pic.ipicture.ru/uploads/081028/cf4cvPlJUF.png

 If a buddy specifies icon it displays as usual

 http://pic.ipicture.ru/uploads/081028/tBL1saStGb.png

 This bug is also with qip users.

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:57>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
---------------------------------------+------------------------------------
 Reporter:  minstrel                   |        Owner:  MarkDoliner
     Type:  patch                      |       Status:  new        
Milestone:                             |    Component:  ICQ        
  Version:  2.3.1                      |   Resolution:            
 Keywords:  Custom Icon XStatuses ICQ  |  
---------------------------------------+------------------------------------

Comment(by nops):

 Changes in xstatus-patch-pidgin-2.5.2.patch:

  * based on xstatus-patch-pidgin-2.5.1.patch;
  * X-status requests is queued (packets do not overflow channel);
  * added parse icqmood, method transmit icons in some client, e.g. R&Q;
  * code refactoring.

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:58>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
---------------------------------------+------------------------------------
 Reporter:  minstrel                   |        Owner:  MarkDoliner
     Type:  patch                      |       Status:  new        
Milestone:                             |    Component:  ICQ        
  Version:  2.3.1                      |   Resolution:            
 Keywords:  Custom Icon XStatuses ICQ  |  
---------------------------------------+------------------------------------

Comment(by Gromescu):

 I had two rejects applying this patch
 {{{
 ***************
 *** 5826,5833 ****
                 else
                         ret = g_strdup(_("Offline"));
         }
 -       else
         {
                 message = purple_status_get_attr_string(status,
 "message");
                 if (message != NULL)
                 {
 --- 5922,5940 ----
                 else
                         ret = g_strdup(_("Offline"));
         }
 +       else if (purple_status_is_available(status) && !strcmp(id,
 OSCAR_STATUS_ID_AVAILABLE))
 +       {
 +               /* Available */
 +               message = purple_status_get_attr_string(status,
 "message");
 +               if (message != NULL)
 +               {
 +                       ret = g_strdup(message);
 +                       purple_util_chrreplace(ret, '\n', ' ');
 +               }
 +       }
 +       else if (!purple_status_is_available(status) && !strcmp(id,
 OSCAR_STATUS_ID_AWAY))
         {
 +               /* Away */
                 message = purple_status_get_attr_string(status,
 "message");
                 if (message != NULL)
                 {
 ***************
 *** 5840,5847 ****
                         g_free(tmp2);
                 }
                 else
 -                       ret = g_strdup(purple_status_get_name(status));
         }
         return ret;
   }

 --- 5947,5959 ----
                         g_free(tmp2);
                 }
                 else
 +               {
 +                       ret = g_strdup(_("Away"));
 +               }
         }
 +       else
 +               ret = g_strdup(purple_status_get_name(status));
 +
         return ret;
   }

 }}}
 Edited manually. It seems to be working.

 The problem with away status not appears now. But pidgin still does not
 read na, dnd, occupied statuses from miranda

--
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:59>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker