#4598: Plus! color tags

[Pidgin]

#4598: Plus! color tags
---------------------------------+------------------------------------------
 Reporter:  daniele_athome       |       Type:  enhancement
   Status:  new                  |   Priority:  minor      
Component:  pidgin (gtk)         |    Version:  2.3.1      
 Keywords:  pidgin blist markup  |    Pending:  0          
---------------------------------+------------------------------------------
 I wrote a patch that registers a new signal in the gtkblist.c file. That
 signal will be called one moment before g_escape_markup_text will be
 called. The callback will return an already-escaped version of the name.

 I also wrote a test plugin that makes all the buddies red :)

--
Ticket URL: <http://developer.pidgin.im/ticket/4598>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------+----------------------------------------------
  Reporter:  daniele_athome  |       Owner:                    
      Type:  patch           |      Status:  new                
  Priority:  minor           |   Milestone:                    
 Component:  pidgin (gtk)    |     Version:  2.3.1              
Resolution:                  |    Keywords:  pidgin blist markup
   Pending:  0               |  
-----------------------------+----------------------------------------------
Changes (by datallah):

  * type:  enhancement => patch

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:1>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------+----------------------------------------------
  Reporter:  daniele_athome  |       Owner:                    
      Type:  patch           |      Status:  new                
  Priority:  minor           |   Milestone:                    
 Component:  pidgin (gtk)    |     Version:  2.3.1              
Resolution:                  |    Keywords:  pidgin blist markup
   Pending:  0               |  
-----------------------------+----------------------------------------------
Comment (by resiak):

 For future reference, don't put patches into zip archives, just attach
 them straight to the ticket.

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:2>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------+----------------------------------------------
  Reporter:  daniele_athome  |       Owner:                    
      Type:  patch           |      Status:  new                
  Priority:  minor           |   Milestone:                    
 Component:  pidgin (gtk)    |     Version:  2.3.1              
Resolution:                  |    Keywords:  pidgin blist markup
   Pending:  0               |  
-----------------------------+----------------------------------------------
Comment (by rekkanoryo):

 There are a number of problems I see with this patch right off the bat:
   * // comments are not valid ANSI C.
   * Use of `g_debug` is strongly discouraged.  Use the libpurple-provided
 debugging API, which is covered quite well in the API documentation and
 the plugin howto wiki pages.
   * Parameters to functions need spaces between them.  For example,
 `foo(parm1, parm2)` instead of `foo(parm1,parm2)`.  The lack of spaces
 makes code very unreadable.

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:3>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------+----------------------------------------------
  Reporter:  daniele_athome  |       Owner:                    
      Type:  patch           |      Status:  new                
  Priority:  minor           |   Milestone:                    
 Component:  pidgin (gtk)    |     Version:  2.3.1              
Resolution:                  |    Keywords:  pidgin blist markup
   Pending:  0               |  
-----------------------------+----------------------------------------------
Comment (by kasmol):

 Great!! Please continue to develop it!!

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:4>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------+----------------------------------------------
  Reporter:  daniele_athome  |       Owner:                    
      Type:  patch           |      Status:  new                
  Priority:  minor           |   Milestone:                    
 Component:  pidgin (gtk)    |     Version:  2.3.1              
Resolution:                  |    Keywords:  pidgin blist markup
   Pending:  0               |  
-----------------------------+----------------------------------------------
Comment (by Twain28):

 Anything new about this? People on MSN are increasingly using bbcode to
 set colors, styles and text dimentions....this patch could come in handy.

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:5>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------+----------------------------------------------
  Reporter:  daniele_athome  |       Owner:                            
      Type:  patch           |      Status:  new                        
  Priority:  minor           |   Milestone:  Patches Needing Improvement
 Component:  pidgin (gtk)    |     Version:  2.3.1                      
Resolution:                  |    Keywords:  pidgin blist markup        
   Pending:  0               |  
-----------------------------+----------------------------------------------
Changes (by QuLogic):

  * milestone:  => Patches Needing Improvement

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:6>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by jgoguen):

 CC myself

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:7>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by ekerazha):

 Any chance to see this patch included?

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:8>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by olivier):

 Great plugin !
 The 2.5.0 milestone of pidgin is really fantastic for new MSN features.
 But I've got many friends who *need* (that's what they say) colored
 plugins, so they use Windows Live Messenger and Plus.
 daniele_athome, did you stop working on this ?
 Maybe I'll try to add gradient nicks support. Would it be possible to have
 smileys in nicks too ? I'm not familiar with pango.

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:9>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by daniele_athome):

 This plugin was just an experiment to see if the community was interested
 to this feature. Personally I don't even like Microsoft MSN protocol and
 its IM chat system (bad designed protocol, very slow servers). Only some
 countries and only specific group of people use MSN messenger with
 colorful nicks (es. very little children or Italians people (sigh)). I'm
 doing my word hard trying to persuade my friends to switch to the jabber
 protocol: people let's realize it, MSN is becoming to have its age.

 Anyway, if someone is really interested in continuing development (instead
 of porting friends to jabber :) I will be more than happy to discuss and
 to explain the plugin code.

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:10>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by olivier):

 I understand and totally agree, but I've got a different approach. I try
 to make people switch to another, better, MSN client (instead of Live
 Messenger) and then convince them to have an XMPP account, that's easy
 because pidgin supports multiple accounts and protocols. I also have
 friends who would switch to Linux instead of Windows, but the only show-
 stopper is "what ? there's no colored nicks in msn ?".

 People will always use crappy things. I can't convince all my
 friends/familiy to switch to another IM protocol, or (for example) to not
 use this commercial thing called facebook. With this "msn plus nicks"
 plugin, pidgin will be more attractive to the msn "plus" userbase, and
 that's a progress.

 Do you have a more recent snapshot than the attached 0.0.2 sources, so
 that the community can continue developing it ?

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:11>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by daniele_athome):

 No I'm sorry I have not. Should it be compatible with the current version
 of piding, shouldn't it? (at least the plugin, the patch is too old
 obviously, but it is pretty simple to reimplement)

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:12>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by olivier):

 It's ok with the current version (pidgin-plus-0.0.2.tar.gz). I tested it
 today with pidgin 2.5.0 + bug4598-plus_colour-cleaned.patch

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:13>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by daniele_athome):

 :-)

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:14>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by elb):

 This patch looks like a memory leak waiting to happen -- it strdup()s a
 string returned from a signal and discards the signal result.  I would
 generally expect the signal handler in a situation like this to have
 allocated the string it wished to return.

 It's also not clear to me why this signal is named "drawing-buddy" and
 takes a buddy as an argument, but seems to be utilized only to return
 markup for the buddy's username.  A more specific signal name which
 indicates this rather limited scope would be appropriate here.

 It looks to me like the whole purpose of this plugin is to handle MSN's
 ill-conceived username markup language; this is something which should
 properly be handled by the MSN protocol plugin.  Perhaps a signal should
 be emitted from the MSN protocol plugin to the effect of msn-buddy-parse-
 markup, with a default implementation of simply stripping these codes from
 the nickname.

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:15>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by QuLogic):

 Replying to [comment:15 elb]:
 > It looks to me like the whole purpose of this plugin is to handle MSN's
 ill-conceived username markup language; this is something which should
 properly be handled by the MSN protocol plugin.  Perhaps a signal should
 be emitted from the MSN protocol plugin to the effect of msn-buddy-parse-
 markup, with a default implementation of simply stripping these codes from
 the nickname.

 This is not technically part of the MSN protocol. It is part of
 [http://www.msgplus.net/ Messenger Plus!], which hacks on various things
 like coloured nicks, skins, funky logs, and who knows what else.

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:16>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by darkweasel):

 Personally, I think that you don't need to make them colored, just
 allowing these [c=15][b]foo[/b][/c=24] to be cancelled out, so that
 something like "[b][c=9][a=1]lenii <3[/a][/c][/b]" just displays as "lenii
 <3" (that's a real nick of one of my buddies, btw).

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:17>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by MastroPino):

 I think that this plugin need to be improve, we need some option like a
 double visualization, I mean plus and anti-plus for example. And I don't
 understand why this is resting a patch, c'mon every one that use that
 stupid MSN protocol have for sure a contact in his/her buddy list that use
 plus tag! Personally every my account use it! Please some one improve this
 essential patch.

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:18>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new        
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by markuznw):

 Please someone keep up this patch, as of italian user it's pretty
 impossible to live with a contact list flooded of bbcode tags from plus.

--
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:19>
Pidgin <http://pidgin.im>
Pidgin
_______________________________________________
Tracker mailing list
Tracker@...
http://pidgin.im/cgi-bin/mailman/listinfo/tracker