#46999 [NEW]: -Werror=format-security

View: New views
6 Messages — Rating Filter:   Alert me  

#46999 [NEW]: -Werror=format-security

by Php - GTK - Dev mailing list :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

From:             oden dot eriksson at envitory dot se
Operating system: Linux
PHP version:      5.2.8
PHP Bug Type:     PHP-GTK related
Bug description:  -Werror=format-security

Description:
------------
The build fails with -Werror=format-security

Will attach a patch that fixes this.

Expected result:
----------------
It should build.

Actual result:
--------------
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c: In function
'parse_arg':
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c:422: error: format
not a string literal and no format arguments
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c: In function
'parse_va_args':
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c:482: error: format
not a string literal and no format arguments


--
Edit bug report at http://bugs.php.net/?id=46999&edit=1
--
Try a CVS snapshot (PHP 5.2):        http://bugs.php.net/fix.php?id=46999&r=trysnapshot52
Try a CVS snapshot (PHP 5.3):        http://bugs.php.net/fix.php?id=46999&r=trysnapshot53
Try a CVS snapshot (PHP 6.0):        http://bugs.php.net/fix.php?id=46999&r=trysnapshot60
Fixed in CVS:                        http://bugs.php.net/fix.php?id=46999&r=fixedcvs
Fixed in CVS and need be documented: http://bugs.php.net/fix.php?id=46999&r=needdocs
Fixed in release:                    http://bugs.php.net/fix.php?id=46999&r=alreadyfixed
Need backtrace:                      http://bugs.php.net/fix.php?id=46999&r=needtrace
Need Reproduce Script:               http://bugs.php.net/fix.php?id=46999&r=needscript
Try newer version:                   http://bugs.php.net/fix.php?id=46999&r=oldversion
Not developer issue:                 http://bugs.php.net/fix.php?id=46999&r=support
Expected behavior:                   http://bugs.php.net/fix.php?id=46999&r=notwrong
Not enough info:                     http://bugs.php.net/fix.php?id=46999&r=notenoughinfo
Submitted twice:                     http://bugs.php.net/fix.php?id=46999&r=submittedtwice
register_globals:                    http://bugs.php.net/fix.php?id=46999&r=globals
PHP 4 support discontinued:          http://bugs.php.net/fix.php?id=46999&r=php4
Daylight Savings:                    http://bugs.php.net/fix.php?id=46999&r=dst
IIS Stability:                       http://bugs.php.net/fix.php?id=46999&r=isapi
Install GNU Sed:                     http://bugs.php.net/fix.php?id=46999&r=gnused
Floating point limitations:          http://bugs.php.net/fix.php?id=46999&r=float
No Zend Extensions:                  http://bugs.php.net/fix.php?id=46999&r=nozend
MySQL Configuration Error:           http://bugs.php.net/fix.php?id=46999&r=mysqlcfg


--
PHP-GTK Development Mailing List (http://gtk.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


#46999 [Opn]: -Werror=format-security

by Php - GTK - Dev mailing list :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

 ID:               46999
 User updated by:  oden dot eriksson at envitory dot se
 Reported By:      oden dot eriksson at envitory dot se
 Status:           Open
 Bug Type:         PHP-GTK related
 Operating System: Linux
 PHP Version:      5.2.8
 New Comment:

--- main/php_gtk_util.c 2008-03-12 16:46:45.000000000 +0100
+++ main/php_gtk_util.c.oden    2009-01-04 13:03:11.000000000 +0100
@@ -419,7 +419,7 @@ static int parse_arg(int arg_num, zval *
                                        get_active_class_name(NULL
TSRMLS_CC),
                                       
get_active_function_name(TSRMLS_C), arg_num, expected_type,
                                        php_gtk_zval_type_name(*arg));
-                       php_error(E_WARNING, buf);
+                       php_error(E_WARNING, "%s", buf);
                }
                return 0;
        }
@@ -479,7 +479,7 @@ static int parse_va_args(int argc, zval
                                        argc < min_argc ? min_argc :
max_argc,
                                        (argc < min_argc ? min_argc :
max_argc) == 1 ? "" : "s",
                                        argc);
-                       php_error(E_WARNING, buf);
+                       php_error(E_WARNING, "%s", buf);
                }
                return 0;
        }


Previous Comments:
------------------------------------------------------------------------

[2009-01-04 12:12:42] oden dot eriksson at envitory dot se

Description:
------------
The build fails with -Werror=format-security

Will attach a patch that fixes this.

Expected result:
----------------
It should build.

Actual result:
--------------
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c: In function
'parse_arg':
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c:422: error:
format not a string literal and no format arguments
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c: In function
'parse_va_args':
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c:482: error:
format not a string literal and no format arguments



------------------------------------------------------------------------


--
Edit this bug report at http://bugs.php.net/?id=46999&edit=1


--
PHP-GTK Development Mailing List (http://gtk.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


Re: #46999 [Opn]: -Werror=format-security

by Bob Majdak Jr-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

valid. i'd suggest committing.

-bob

On 01/04/2009 07:13 AM, oden dot eriksson at envitory dot se wrote:

>   ID:               46999
>   User updated by:  oden dot eriksson at envitory dot se
>   Reported By:      oden dot eriksson at envitory dot se
>   Status:           Open
>   Bug Type:         PHP-GTK related
>   Operating System: Linux
>   PHP Version:      5.2.8
>   New Comment:
>
> --- main/php_gtk_util.c 2008-03-12 16:46:45.000000000 +0100
> +++ main/php_gtk_util.c.oden    2009-01-04 13:03:11.000000000 +0100
> @@ -419,7 +419,7 @@ static int parse_arg(int arg_num, zval *
>                                          get_active_class_name(NULL
> TSRMLS_CC),
>
> get_active_function_name(TSRMLS_C), arg_num, expected_type,
>                                          php_gtk_zval_type_name(*arg));
> -                       php_error(E_WARNING, buf);
> +                       php_error(E_WARNING, "%s", buf);
>                  }
>                  return 0;
>          }
> @@ -479,7 +479,7 @@ static int parse_va_args(int argc, zval
>                                          argc<  min_argc ? min_argc :
> max_argc,
>                                          (argc<  min_argc ? min_argc :
> max_argc) == 1 ? "" : "s",
>                                          argc);
> -                       php_error(E_WARNING, buf);
> +                       php_error(E_WARNING, "%s", buf);
>                  }
>                  return 0;
>          }
>
>
> Previous Comments:
> ------------------------------------------------------------------------
>
> [2009-01-04 12:12:42] oden dot eriksson at envitory dot se
>
> Description:
> ------------
> The build fails with -Werror=format-security
>
> Will attach a patch that fixes this.
>
> Expected result:
> ----------------
> It should build.
>
> Actual result:
> --------------
> /home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c: In function
> 'parse_arg':
> /home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c:422: error:
> format not a string literal and no format arguments
> /home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c: In function
> 'parse_va_args':
> /home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c:482: error:
> format not a string literal and no format arguments
>
>
>
> ------------------------------------------------------------------------
>
>
>    


--
PHP-GTK Development Mailing List (http://gtk.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


#46999 [Opn->Ver]: -Werror=format-security

by bmajdak :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

 ID:               46999
 Updated by:       bmajdak@...
 Reported By:      oden dot eriksson at envitory dot se
-Status:           Open
+Status:           Verified
 Bug Type:         PHP-GTK related
 Operating System: Linux
 PHP Version:      5.2.8


Previous Comments:
------------------------------------------------------------------------

[2009-01-04 12:13:42] oden dot eriksson at envitory dot se

--- main/php_gtk_util.c 2008-03-12 16:46:45.000000000 +0100
+++ main/php_gtk_util.c.oden    2009-01-04 13:03:11.000000000 +0100
@@ -419,7 +419,7 @@ static int parse_arg(int arg_num, zval *
                                        get_active_class_name(NULL
TSRMLS_CC),
                                       
get_active_function_name(TSRMLS_C), arg_num, expected_type,
                                        php_gtk_zval_type_name(*arg));
-                       php_error(E_WARNING, buf);
+                       php_error(E_WARNING, "%s", buf);
                }
                return 0;
        }
@@ -479,7 +479,7 @@ static int parse_va_args(int argc, zval
                                        argc < min_argc ? min_argc :
max_argc,
                                        (argc < min_argc ? min_argc :
max_argc) == 1 ? "" : "s",
                                        argc);
-                       php_error(E_WARNING, buf);
+                       php_error(E_WARNING, "%s", buf);
                }
                return 0;
        }

------------------------------------------------------------------------

[2009-01-04 12:12:42] oden dot eriksson at envitory dot se

Description:
------------
The build fails with -Werror=format-security

Will attach a patch that fixes this.

Expected result:
----------------
It should build.

Actual result:
--------------
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c: In function
'parse_arg':
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c:422: error:
format not a string literal and no format arguments
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c: In function
'parse_va_args':
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c:482: error:
format not a string literal and no format arguments



------------------------------------------------------------------------


--
Edit this bug report at http://bugs.php.net/?id=46999&edit=1


--
PHP-GTK Development Mailing List (http://gtk.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


#46999 [Ver->Asn]: -Werror=format-security

by Felipe Pena-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

 ID:               46999
 Updated by:       felipe@...
 Reported By:      oden dot eriksson at envitory dot se
-Status:           Verified
+Status:           Assigned
 Bug Type:         PHP-GTK related
 Operating System: Linux
 PHP Version:      5.2.8
-Assigned To:      
+Assigned To:      auroraeosrose


Previous Comments:
------------------------------------------------------------------------

[2009-01-04 12:13:42] oden dot eriksson at envitory dot se

--- main/php_gtk_util.c 2008-03-12 16:46:45.000000000 +0100
+++ main/php_gtk_util.c.oden    2009-01-04 13:03:11.000000000 +0100
@@ -419,7 +419,7 @@ static int parse_arg(int arg_num, zval *
                                        get_active_class_name(NULL
TSRMLS_CC),
                                       
get_active_function_name(TSRMLS_C), arg_num, expected_type,
                                        php_gtk_zval_type_name(*arg));
-                       php_error(E_WARNING, buf);
+                       php_error(E_WARNING, "%s", buf);
                }
                return 0;
        }
@@ -479,7 +479,7 @@ static int parse_va_args(int argc, zval
                                        argc < min_argc ? min_argc :
max_argc,
                                        (argc < min_argc ? min_argc :
max_argc) == 1 ? "" : "s",
                                        argc);
-                       php_error(E_WARNING, buf);
+                       php_error(E_WARNING, "%s", buf);
                }
                return 0;
        }

------------------------------------------------------------------------

[2009-01-04 12:12:42] oden dot eriksson at envitory dot se

Description:
------------
The build fails with -Werror=format-security

Will attach a patch that fixes this.

Expected result:
----------------
It should build.

Actual result:
--------------
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c: In function
'parse_arg':
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c:422: error:
format not a string literal and no format arguments
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c: In function
'parse_va_args':
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c:482: error:
format not a string literal and no format arguments



------------------------------------------------------------------------


--
Edit this bug report at http://bugs.php.net/?id=46999&edit=1


--
PHP-GTK Development Mailing List (http://gtk.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


#46999 [Asn->Csd]: -Werror=format-security

by bmajdak :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

 ID:               46999
 Updated by:       bmajdak@...
 Reported By:      oden dot eriksson at envitory dot se
-Status:           Assigned
+Status:           Closed
 Bug Type:         PHP-GTK related
 Operating System: Linux
 PHP Version:      5.2.8
-Assigned To:      auroraeosrose
+Assigned To:      bmajdak
 New Comment:

patch applied, thanks


Previous Comments:
------------------------------------------------------------------------

[2009-01-04 12:13:42] oden dot eriksson at envitory dot se

--- main/php_gtk_util.c 2008-03-12 16:46:45.000000000 +0100
+++ main/php_gtk_util.c.oden    2009-01-04 13:03:11.000000000 +0100
@@ -419,7 +419,7 @@ static int parse_arg(int arg_num, zval *
                                        get_active_class_name(NULL
TSRMLS_CC),
                                       
get_active_function_name(TSRMLS_C), arg_num, expected_type,
                                        php_gtk_zval_type_name(*arg));
-                       php_error(E_WARNING, buf);
+                       php_error(E_WARNING, "%s", buf);
                }
                return 0;
        }
@@ -479,7 +479,7 @@ static int parse_va_args(int argc, zval
                                        argc < min_argc ? min_argc :
max_argc,
                                        (argc < min_argc ? min_argc :
max_argc) == 1 ? "" : "s",
                                        argc);
-                       php_error(E_WARNING, buf);
+                       php_error(E_WARNING, "%s", buf);
                }
                return 0;
        }

------------------------------------------------------------------------

[2009-01-04 12:12:42] oden dot eriksson at envitory dot se

Description:
------------
The build fails with -Werror=format-security

Will attach a patch that fixes this.

Expected result:
----------------
It should build.

Actual result:
--------------
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c: In function
'parse_arg':
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c:422: error:
format not a string literal and no format arguments
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c: In function
'parse_va_args':
/home/oden/RPM/BUILD/php-gtk-2.0.1/main/php_gtk_util.c:482: error:
format not a string literal and no format arguments



------------------------------------------------------------------------


--
Edit this bug report at http://bugs.php.net/?id=46999&edit=1


--
PHP-GTK Development Mailing List (http://gtk.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php