[Branch ~musicbrainz-developers/picard/trunk] Rev 1007: Fixed deletion of all COMM frames in ID3, which was introduced in rev. 989

View: New views
1 Messages — Rating Filter:   Alert me  

[Branch ~musicbrainz-developers/picard/trunk] Rev 1007: Fixed deletion of all COMM frames in ID3, which was introduced in rev. 989

by noreply-45 :: Rate this Message:

Reply (Restricted by the Administrator) | Reply to Author | View Threaded | Show Only this Message

------------------------------------------------------------
revno: 1007
committer: Philipp Wolfer <ph.wolfer@...>
branch nick: trunk
timestamp: Sun 2009-11-01 18:49:45 +0100
message:
  Fixed deletion of all COMM frames in ID3, which was introduced in rev. 989
modified:
  picard/formats/id3.py


--
lp:picard
https://code.launchpad.net/~musicbrainz-developers/picard/trunk

You are subscribed to branch lp:picard.
To unsubscribe from this branch go to https://code.launchpad.net/~musicbrainz-developers/picard/trunk/+edit-subscription.

=== modified file 'picard/formats/id3.py'
--- picard/formats/id3.py 2009-10-19 20:47:36 +0000
+++ picard/formats/id3.py 2009-11-01 17:49:45 +0000
@@ -236,7 +236,6 @@
 
         id3.TCMP = compatid3.TCMP
         tags.delall('TCMP')
-        tags.delall('COMM')
         for name, values in metadata.rawitems():
             if name.startswith('performer:'):
                 role = name.split(':', 1)[1]
@@ -245,6 +244,7 @@
             elif name.startswith('comment:'):
                 desc = name.split(':', 1)[1]
                 if desc.lower()[:4]=="itun":
+                    tags.delall('COMM:' + desc)
                     tags.add(id3.COMM(encoding=0, desc=desc, lang='eng', text=[v+u'\x00' for v in values]))
                 else:
                     tags.add(id3.COMM(encoding=encoding, desc=desc, lang='eng', text=values))


_______________________________________________
MusicBrainz-commits mailing list
MusicBrainz-commits@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-commits