[Bug 116602] New: ampersands in link addresses not handled

View: New views
5 Messages — Rating Filter:   Alert me  

[Bug 116602] New: ampersands in link addresses not handled

by Brian Wallis-2 :: Rate this Message:

| View Threaded | Show Only this Message

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=116602         
           Summary: ampersands in link addresses not handled
           Product: klinkstatus
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: moura kdewebdev org
        ReportedBy: brian.wallis ot com au


Version:           0.2.2 (using KDE 3.4.1, Gentoo)
Compiler:          gcc version 3.4.4 (Gentoo 3.4.4, ssp-3.4.4-1.0, pie-8.7.8)
OS:                Linux (i686) release 2.6.9-gentoo-r1

The following reports a bad link but it works fine:

<td style="text-align: center;"><img style="width: 213px; height: 160px;" alt="Minty & Sno-Glo" title="Minty & Sno-Glo" src="minty&snoglo.jpg"></td>
      <td style="vertical-align: top;">Minty & Sno-Glo:<br>

The file minty&snoglo.jpg exists on the server, but minty&snoglo.jpg does not which is what the checker seems to be looking for. I suspect it should translate the & into the & character before looking it up.

[Bug 116602] ampersands in link addresses not handled

by Bugzilla from moura@kdewebdev.org :: Rate this Message:

| View Threaded | Show Only this Message

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=116602         
moura kdewebdev org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1

[Bug 116602] ampersands in link addresses not handled

by Bugzilla from owner@bugs.kde.org :: Rate this Message:

| View Threaded | Show Only this Message

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=116602         
moura kdewebdev org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugs wright-family me uk



------- Additional Comments From moura kdewebdev org  2006-04-17 22:49 -------
*** Bug 124720 has been marked as a duplicate of this bug. ***

[Bug 116602] ampersands in link addresses not handled

by Bugzilla from moura@kdewebdev.org :: Rate this Message:

| View Threaded | Show Only this Message

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=116602         
moura kdewebdev org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From moura kdewebdev org  2006-04-18 04:10 -------
SVN commit 530923 by mojo:

Resolve entities in URIs.

BUG: 116602

 M  +1 -1      engine/linkchecker.cpp  
 M  +4 -2      parser/url.cpp  


--- branches/work/klinkstatus_proceed/src/engine/linkchecker.cpp #530922:530923
 @ -67,7 +67,7  @
 {
     Q_ASSERT(!finnished_);
 
-    KURL url = linkStatus()->absoluteUrl();
+    KURL url(linkStatus()->absoluteUrl());
     Q_ASSERT(url.isValid());
 
     if(url.hasRef())
--- branches/work/klinkstatus_proceed/src/parser/url.cpp #530922:530923
 @ -24,7 +24,9  @
 #include "mstring.h"
 #include "../utils/utils.h"
 
+#include <kcharsets.h>
 
+
 Node::LinkType Url::resolveLinkType(QString const& url)
 {
     QString aux(url);
 @ -94,13 +96,13  @
 
 //         kdDebug(23100) <<  url.url() << endl;
 
-        return url;
+        return KURL(KCharsets::resolveEntities(url.url()));
     }
 }
 
 KURL Url::normalizeUrl(QString const& string_url)
 {
-    QString qs_url = string_url.stripWhiteSpace();
+    QString qs_url(KCharsets::resolveEntities(string_url.stripWhiteSpace()));
 
     if(qs_url[0] == '/')
     {

[Bug 116602] ampersands in link addresses not handled

by Bugzilla from moura@kdewebdev.org :: Rate this Message:

| View Threaded | Show Only this Message

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=116602         




------- Additional Comments From moura kdewebdev org  2006-04-18 04:20 -------
SVN commit 530925 by mojo:

Show decoded URLs.

CCBUG: 116602

 M  +2 -1      treeview.cpp  


--- branches/work/klinkstatus_proceed/src/ui/treeview.cpp #530924:530925
 @ -412,7 +412,8  @
     {
         TreeColumnViewItem item(root_, linkstatus, i + 1);
         column_items_.push_back(item);
-        setText(item.columnIndex() - 1, KCharsets::resolveEntities(item.text(i + 1)));
+        setText(item.columnIndex() - 1, KURL::decode_string(
+                KCharsets::resolveEntities(item.text(i + 1))));
         setPixmap(item.columnIndex() - 1, item.pixmap(i + 1));
     }
 }