|

»

[Bug 199190] New: "Highlight Semantic Problems" checkbox has no effect

View: New views

8 Messages — Rating Filter: Alert me

	[Bug 199190] New: "Highlight Semantic Problems" checkbox has no effect by Bugzilla from jacob.benoit.1@gmail.com :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message https://bugs.kde.org/show_bug.cgi?id=199190 Summary: "Highlight Semantic Problems" checkbox has no effect Product: kdevelop Version: unspecified Platform: Compiled Sources OS/Version: unspecified Status: NEW Severity: normal Priority: NOR Component: general AssignedTo: kdevelop-bugs@... ReportedBy: jacob.benoit.1@... Version: 3.9.94 (using Devel) Installed from: Compiled sources I want to disable the wiggly lines in the editor, so I go to Settings -> Configure KDevelop -> Language Support ... and then I notice that the checkbox "Highlight Semantic Problems" is NOT ticked, so there shouldn't be wiggly lines in the first place. Checking and re-unchecking this checkbox has no effect either. See discussion here: https://bugs.kde.org/show_bug.cgi?id=199088 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
	[Bug 199190] "Highlight Semantic Problems" checkbox has no effect by Andreas Pakulat-3 :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message https://bugs.kde.org/show_bug.cgi?id=199190 Andreas Pakulat <apaku@...> changed: What \|Removed \|Added ---------------------------------------------------------------------------- Priority\|NOR \|HI Component\|general \|Language Support: CPP Target Milestone\|--- \|4.0.0 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
	[Bug 199190] "Highlight Semantic Problems" checkbox has no effect by Bugzilla from olivier.jg@gmail.com :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message https://bugs.kde.org/show_bug.cgi?id=199190 Olivier.jg <olivier.jg@...> changed: What \|Removed \|Added ---------------------------------------------------------------------------- CC\| \|olivier.jg@... --- Comment #1 from Olivier.jg <olivier jg gmail com> 2009-10-24 08:03:28 --- Seems like there are two problems at work here: The first bug is that when KDevelop starts it appears not to load the configuration wherein you'll find "Highlight Semantic Problems", and the default is true. If you enable and disable it though, it will actually take effect (that is "highlightSemanticProblems()" returns false, you still have to reload the file to get rid of those squiggles). The second bug is that the problem reporter plugin for kdevplatform draws its squiggly yellow lines regardless of whether or not "Highlight Semantic Problems is checked". For the first bug, it's a matter of finding out why the settings aren't loaded when Kdevelop starts, and I imagine also either reloading the file or resetting highlights when the settings are changed. But for the second bug, while making it respect the setting is simple enough, does it seem strange to have the problem reporter enabled and popping up without it's identifying highlights? Should it simply not highlight or should it go further than that and not show up at all? -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
	[Bug 199190] "Highlight Semantic Problems" checkbox has no effect by Bugzilla from mail@milianw.de :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message https://bugs.kde.org/show_bug.cgi?id=199190 --- Comment #2 from Milian Wolff <mail milianw de> 2009-10-24 13:21:09 --- So far we use the setting in the PHP language plugin and decide there whether to report a problem or not, depending on the setting. Though imo it would indeed make sense to always report this stuff and let the problem reporter decide whether or not to show these issues. One could also extend the setting to make the different problem severities configurable, i.e. "only show errors, but no warnings or notices" and similar... -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
	[Bug 199190] "Highlight Semantic Problems" checkbox has no effect by Bugzilla from olivier.jg@gmail.com :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message https://bugs.kde.org/show_bug.cgi?id=199190 --- Comment #3 from Olivier.jg <olivier jg gmail com> 2009-10-25 02:45:14 --- Created an attachment (id=37810) --> (http://bugs.kde.org/attachment.cgi?id=37810) Fix Checkbox not working issue This patch fixes the checkbox issue. The .kcfg file said the default was off, but the code said the default was true, so when the KConfig said the value was default, the code set it to true, even though the box was unchecked. Of course, this is my first foray into KDE programming so that took way too long to figure out. It remains to be discussed whether or not the Problem Reporter's lack of response to this setting is acceptable. In the meantime, anyone wanting a quick fix can know there are two types of underlining/highlighting going on. The simple built-in problem highlights, which do respond to the checkbox (well, when this patch is applied anyhow) The Problem Reporter plugin highlights, which detect significantly more problems, and usually override the simple built-in highlights. To disable these, you can just disable the Problem Reporter View plugin from the Plugin settings. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
	[Bug 199190] "Highlight Semantic Problems" checkbox has no effect by Bugzilla from jacob.benoit.1@gmail.com :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message https://bugs.kde.org/show_bug.cgi?id=199190 --- Comment #4 from Benoît Jacob <jacob benoit 1 gmail com> 2009-11-07 20:17:17 --- I just tried kdevelop 4 beta 6, the issue is still there: my source files are littered by wiggly lines that can't be disabled. I really wanted to use kdevelop :( -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
	[Bug 199190] "Highlight Semantic Problems" checkbox has no effect by Bugzilla from david.nolden.kde@art-master.de :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message https://bugs.kde.org/show_bug.cgi?id=199190 David Nolden <david.nolden.kde@...> changed: What \|Removed \|Added ---------------------------------------------------------------------------- Status\|NEW \|RESOLVED Resolution\| \|FIXED --- Comment #5 from David Nolden <david nolden kde art-master de> 2009-11-08 16:24:02 --- SVN commit 1046379 by zwabel: - Link yellow underlines to the "Highlight semantic problems" option in the language support settings, and update it directly when the setting was changed - Add some copyright notices BUG: 199190 M +1 -1 language/interfaces/iproblem.h M +33 -16 plugins/problemreporter/problemhighlighter.cpp M +4 -1 plugins/problemreporter/problemhighlighter.h M +1 -0 plugins/problemreporter/problemreporterplugin.cpp M +1 -0 plugins/problemreporter/problemreporterplugin.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1046379 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
	[Bug 199190] "Highlight Semantic Problems" checkbox has no effect by Bugzilla from jacob.benoit.1@gmail.com :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message https://bugs.kde.org/show_bug.cgi?id=199190 --- Comment #6 from Benoît Jacob <jacob benoit 1 gmail com> 2009-11-08 16:27:44 --- Many thanks! -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.