[Bug 1997] New: New match criteria: 'has_attachment' and 'signed'

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=1997

           Summary: New match criteria: 'has_attachment' and 'signed'
           Product: Claws Mail
           Version: CVS
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: Filtering
        AssignedTo: claws-mail-users@...
        ReportedBy: aleksei@...


Created an attachment (id=723)
 --> (http://www.thewildbeast.co.uk/claws-mail/bugzilla/attachment.cgi?id=723)
the patch

This is just another 'scratch your own itches' stuff. Motivation: long time ago
I used my gmail account for file transfer, and today I needed to find some of
those files among 20K message.

So I added two new match critera for filteing/processing/search:
'has_attachment' and (as long as I was hacking there anyway) 'signed'. They of
course have tilda-counterparts '~has_attachment' and '~signed'.

Currently I placed them under 'Flags', because they are actaully implement
through message flags, but planning to move them up one level, into the 'Search
creteria' drop-down when I extend them to more advanced, like matching over
attachments' filenames/size or signature validity. Is that okay with everyone?

--
Configure bugmail: http://www.thewildbeast.co.uk/claws-mail/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: claws-mail-users-unsubscribe@...
For additional commands, e-mail: claws-mail-users-help@...

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=1997


Aleksei Miheev <aleksei@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #723 is|0                           |1
           obsolete|                            |




--- Comment #1 from Aleksei Miheev  2009-09-11 16:20:04 ---
Created an attachment (id=724)
 --> (http://www.thewildbeast.co.uk/claws-mail/bugzilla/attachment.cgi?id=724)
A fixed patch

Ok, that patch contained a typo. This one if correct.

--
Configure bugmail: http://www.thewildbeast.co.uk/claws-mail/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: claws-mail-users-unsubscribe@...
For additional commands, e-mail: claws-mail-users-help@...

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=1997





--- Comment #2 from Colin Leroy  2009-09-14 09:30:31 ---
>Currently I placed them under 'Flags', because they are actaully implement
>through message flags, but planning to move them up one level, into the 'Search
>creteria' drop-down when I extend them to more advanced, like matching over
>attachments' filenames/size or signature validity. Is that okay with everyone?

Yes, do the same as what's done with Tags, for example. First patch applied,
thanks!

--
Configure bugmail: http://www.thewildbeast.co.uk/claws-mail/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: claws-mail-users-unsubscribe@...
For additional commands, e-mail: claws-mail-users-help@...

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=1997





--- Comment #3 from claws-mail-users  2009-09-14 09:31:38 ---
Changes related to this bug have been committed.
Please check latest CVS and update the bug accordingly.
You can also get the patch from:
http://www.colino.net/claws-mail/

2009-09-14 [colin]    3.7.2cvs32

    * src/matcher.c
    * src/matcher.h
    * src/matcher_parser_parse.y
    * src/prefs_matcher.c
        Add 'has_attachment' and 'signed' matcher
        expressions. Patch by Aleksei Miheev, fixes
        bug 1997.

--
Configure bugmail: http://www.thewildbeast.co.uk/claws-mail/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: claws-mail-users-unsubscribe@...
For additional commands, e-mail: claws-mail-users-help@...

http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=1997


Paul Mangan <paul@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--
Configure bugmail: http://www.thewildbeast.co.uk/claws-mail/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: claws-mail-users-unsubscribe@...
For additional commands, e-mail: claws-mail-users-help@...