[Bug 5998] New: Mail::SpamAssassin::BayesStore::MySQL.pm is not completely master-master replication safe

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5998

           Summary: Mail::SpamAssassin::BayesStore::MySQL.pm is not
                    completely master-master replication safe
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Libraries
        AssignedTo: dev@...
        ReportedBy: matt@...


When using Mail::SpamAssassin::BayesStore::MySQL.pm in a master-master
replication status, there is a problem with some of the insert code which can
cause replication errors.

Although the interactions with bayes_token are safe (i.e. the inserts have an
ON DUPLICATE statement), the interaction with bayes_seen is not.


--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5998





--- Comment #1 from Matt Hampton <matt@...>  2008-10-16 07:11:24 PST ---
Created an attachment (id=4378)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4378)
Patch to resolve issue


--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5998


Justin Mason <jm@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.3.0




--- Comment #2 from Justin Mason <jm@...>  2008-10-16 07:30:23 PST ---
looks sensible.  +1


--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5998





--- Comment #3 from Michael Parker <parkerm@...>  2008-10-16 07:39:56 PST ---
-1 on the patch.  Bayes for mysql was not designed to be master-master safe and
there are other issues that would cause breakage.


--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5998





--- Comment #4 from Matt Hampton <matt@...>  2008-10-16 07:47:37 PST ---
OK it was not designed to be master-master safe BUT in the whole it is.

I have been running it in production for 3 years in master-master (and I know
others who have as well).

The issue I have created the patch for is to fix the only issue I have ever
identified.  

This patch also resolves the situation where MailScanner is running on a box
where the messages are split per recipient and two MailScanner children try to
learn the same message (this was the other place that I detected it).


--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5998

Frank Urban <frank.urban@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frank.urban@...

--- Comment #5 from Frank Urban <frank.urban@...> 2009-10-30 05:06:14 UTC ---
This feature will be included in SA 3.3?
What about Bug 4508? I like more to have the possibility to use another server
for writing data than to read from.
I'm using SQLGrey in this way today.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5998

Justin Mason <jm@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jm@...

--- Comment #6 from Justin Mason <jm@...> 2009-10-30 05:51:10 UTC ---
(In reply to comment #5)
> This feature will be included in SA 3.3?

Nope -- Michael is about the nearest thing we have on the dev team to our SQL
expert.  if he vetoes it, that's a big problem....

> What about Bug 4508? I like more to have the possibility to use another server
> for writing data than to read from.
> I'm using SQLGrey in this way today.

without someone reviewing and approving the patches, we can't apply them....

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5998

--- Comment #7 from Michael Parker <parkerm@...> 2009-11-17 08:03:41 UTC ---
Removing my veto on the patch, it will work and does not require a bump in the
required version of MySQL.

However, don't believe that this makes the SQL Bayes storage master-master
safe, its not.  Folks might be using it that way but they are most likely not
using it for a diverse set of users (ie using bayes_sql_override_username or
just a single user).

There are some ways todo that via AUTO_INCREMENT tricks.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.