[Bug 648] New: Add onCommit hook

http://helma.org/bugs/show_bug.cgi?id=648

           Summary: Add onCommit hook
           Product: Helma
           Version: CVS trunk
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P1
         Component: Generic/Other
        AssignedTo: helma-dev@...
        ReportedBy: lists@...


Here is a little patch that adds a onCommit hook to Transactor. The function is
called before commitTransaction is executed, and no parameters are passed to it
right now. One could consider passing the inserted / updated / deleted nodes to
it, e.g. in an object of this form: { inserted: [], updated: [], deleted: [] }.


--
Configure bugmail: http://helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://helma.org/bugs/show_bug.cgi?id=648





------- Comment #1 from lists@...  2008-11-03 15:35 -------
Created an attachment (id=101)
 --> (http://helma.org/bugs/attachment.cgi?id=101&action=view)
onCommit patch


--
Configure bugmail: http://helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://helma.org/bugs/show_bug.cgi?id=648





------- Comment #2 from hannes@...  2008-11-05 15:17 -------
What is this good for if no arguments are passed to it? Does it make any sense
to commit as is?


--
Configure bugmail: http://helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://helma.org/bugs/show_bug.cgi?id=648





------- Comment #3 from lists@...  2008-11-05 15:25 -------
I am using it to be notified that some fake properties that I install using
__define[GS]etter__ should set the native db fields internally, before the
object is commited. But for this feature, I realised it actually needs to be
called before all the dirty nodes are scanned and stored, otherwise the changes
in onCommit would actually not make it into the commit.

So maybe we could consider supporting two callbacks there: onBeforeCommit and
onCommit. onCommit could then receive all the updated, deleted, inserted nodes
as parameters.

What do you think?

When looking for this feature I realised that axiomstack already implemented it
in their fork:

http://file.axiomstack.com/public-bzr/stack-trunk/src/java/axiom/objectmodel/db/Transactor.java


--
Configure bugmail: http://helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev