[Bug 671] New: A proposal for making FileObject handling more flexible

http://dev.helma.org/bugs/show_bug.cgi?id=671

           Summary: A proposal for making FileObject handling more
                    flexible
           Product: Helma
           Version: CVS trunk
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: JavaScript Interpreter
        AssignedTo: helma-dev@...
        ReportedBy: lists@...


Created an attachment (id=114)
 --> (http://dev.helma.org/bugs/attachment.cgi?id=114)
A proposal for making FileObject handling more flexible

Here a simple patch that with a few changes makes both FileObject and
ImageObject handle files objects more flexibly.

One change is that FileObject now acts as a wrapper for a native java File
object.

The other is that a file object implemented in JS can replace the native File
object and be passed directly to ImageObject. The path is then determined
through its toString function.

I think both additions make a lot of sense and do not break any existing code.

--
Configure bugmail: http://dev.helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://dev.helma.org/bugs/show_bug.cgi?id=671





--- Comment #1 from Juerg Lehni <lists@...>  2009-08-05 16:22:31 ---
Hannes mentioned some doubts about this patch in a comment in #672:

"maybe keep the special code for FileObject arguments?"

This is not necessary since FileObject is a Wrapper now and the code unwraps
any wrappers that are passed both for argument 0 and 1, so these arguments
become normal java File objects, which then are passed to the appropriate
constructor.

--
Configure bugmail: http://dev.helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://dev.helma.org/bugs/show_bug.cgi?id=671


Hannes Wallnoefer <hannes@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hannes@...




--- Comment #2 from Hannes Wallnoefer <hannes@...>  2009-08-12 12:40:06 ---
The patch looks okay-ish, but I think it is big enought that it should get some
testing time. So unless this is urgent for you, I propose to postpone
committing it until after the final 1.7.0 release.

--
Configure bugmail: http://dev.helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://dev.helma.org/bugs/show_bug.cgi?id=671





--- Comment #3 from Juerg Lehni <lists@...>  2009-08-12 14:17:53 ---
I am fine either way. It does not seem to break anything here and I wrote the
code so that it would not break existing code or change the current behaviour,
but one never knows.

--
Configure bugmail: http://dev.helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev