[Bug 672] New: A row of cosmetic changes to the imaging code

http://dev.helma.org/bugs/show_bug.cgi?id=672

           Summary: A row of cosmetic changes to the imaging code
           Product: Helma
           Version: CVS trunk
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Generic/Other
        AssignedTo: helma-dev@...
        ReportedBy: lists@...


Created an attachment (id=115)
 --> (http://dev.helma.org/bugs/attachment.cgi?id=115)
A row of cosmetic changes to the imaging code

Here a patch containing a row of minor cosmetic changes to my imaging code.
Since I lost write access to the new svn or git location, here as patch.

--
Configure bugmail: http://dev.helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://dev.helma.org/bugs/show_bug.cgi?id=672


Hannes Wallnoefer <hannes@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hannes@...




--- Comment #1 from Hannes Wallnoefer <hannes@...>  2009-08-05 16:12:57 ---
Thanks for the patches, Juerg. I think they're all fine, except for some doubts
about #671 (maybe keep the special code for FileObject arguments?)

To regain svn commit powers please register with the Helma trac:

https://dev.helma.org/trac/helma/register

and I'll add you to the committer group.

--
Configure bugmail: http://dev.helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://dev.helma.org/bugs/show_bug.cgi?id=672





--- Comment #2 from Juerg Lehni <lists@...>  2009-08-05 16:20:42 ---
Hi Hannes, I created the user now: lehni.

As for #671, I move the discussion there, ok?

--
Configure bugmail: http://dev.helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://dev.helma.org/bugs/show_bug.cgi?id=672





--- Comment #3 from Hannes Wallnoefer <hannes@...>  2009-08-05 16:55:03 ---
> Hi Hannes, I created the user now: lehni.

You should be able to commit now. Make sure you check out the repository via
https, i.e. https://dev.helma.org/svn/helma/helma/trunk . Let me know if it
doesn't work, it's quite possible I got something wrong.

--
Configure bugmail: http://dev.helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://dev.helma.org/bugs/show_bug.cgi?id=672





--- Comment #4 from Juerg Lehni <lists@...>  2009-08-10 16:29:55 ---
I just commited the patch, it did indeed work.
What about the other patches? Shall I commit them as well?

--
Configure bugmail: http://dev.helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev

http://dev.helma.org/bugs/show_bug.cgi?id=672


Hannes Wallnoefer <hannes@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Hannes Wallnoefer <hannes@...>  2009-08-12 12:44:48 ---
(In reply to comment #4)
> I just commited the patch, it did indeed work.

Great!

> What about the other patches? Shall I commit them as well?

Go ahead with bug #673 and bug #674. For bugs #671 and #675 I've added some
notes.

--
Configure bugmail: http://dev.helma.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Helma-dev mailing list
Helma-dev@...
http://helma.org/mailman/listinfo/helma-dev