[Bug 688] New: exiwhat fails on log_selector = +pid (fix included)

View: New views
3 Messages — Rating Filter:   Alert me  

[Bug 688] New: exiwhat fails on log_selector = +pid (fix included)

by Bugzilla from hs+exim@schlittermann.de :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=688
           Summary: exiwhat fails on log_selector = +pid (fix included)
           Product: Exim
           Version: 4.68
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: bug
          Priority: medium
         Component: Logging
        AssignedTo: nigel@...
        ReportedBy: hs+exim@...
                CC: exim-dev@...


When using

    log_selector = +pid

the exiwhat script fails to parse the "exim-process.info" file
correctly. It gets confused by the PID prepended to each line.

The following "sed" expression should fix it:
(found near the end of the script)

    old:   's/^[0-9-]* [0-9:]* \([+-][0-9]* \)*//'
    new:   's/^[0-9-]* [0-9:]* \([+-][0-9]* \)*\(\[[0-9]\+\] \)\?//'


I'm not sure about incompatibilites with "sed"s on systems other then
linux, here it's "GNU sed Version 4.1.5".

I tested it with and without "+pid", both worked. It's not tested with
time offsets (I suppose, the [+-][0-9]* is meant for this).

    Best regards from Dresden
    Viele Grüße aus Dresden
    Heiko Schlittermann
--
 SCHLITTERMANN.de ---------------------------- internet & unix support -
 Heiko Schlittermann HS12-RIPE -----------------------------------------
 gnupg encrypted messages are welcome - key ID: 48D0359B ---------------
 gnupg fingerprint: 3061 CFBF 2D88 F034 E8D2  7E92 EE4E AC98 48D0 359B -


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email
--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

[Bug 688] exiwhat fails on log_selector = +pid (fix included)

by Bugzilla from nigel@exim.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=688




--- Comment #1 from Nigel Metheringham <nigel@...>  2009-10-19 12:45:23 ---
I think the whole script is crying out for a perl rewrite, but for now will
just apply this fix.


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

[Bug 688] exiwhat fails on log_selector = +pid (fix included)

by Bugzilla from nigel@exim.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=688

Nigel Metheringham <nigel@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Nigel Metheringham <nigel@...>  2009-10-19 12:47:44 ---
CVS commit by nm4:

Correct exiwhat mishandling log_selector = +pid.  Fixes: bug#688

--- CVS commit summary ---
1.574  1.575  +3 -0  -  exim/exim-doc/doc-txt/ChangeLog
1.3    1.4    +1 -1  -  exim/exim-src/src/exiwhat.src


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##