[Bug 795] New: No user message after accept with endpass on ACL

View: New views
2 Messages — Rating Filter:   Alert me  

[Bug 795] New: No user message after accept with endpass on ACL

by Adam Osuchowski :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=795
           Summary: No user message after accept with endpass on ACL
           Product: Exim
           Version: 4.69
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: bug
          Priority: medium
         Component: ACLs
        AssignedTo: nigel@...
        ReportedBy: adwol@...
                CC: exim-dev@...


I have such ACL rule:

  accept  message = this is my message
          domains = +local_domains
          endpass
          verify  = recipient

in acl_smtp_rcpt. But where this rule condition is met and rule returns
accept the message sended to SMTP client is ,,250 Accepted'' instead of
,,250 this is my message''. If I remove endpass modifier from rule,
the answer is correct (,,250 this is my message''). The same situation
take place in acl_smtp_mail ACL.

I found in acl_check_condition() function body (src/acl.c) following statement:

    if (*epp && rc == OK) user_message = NULL;

Is it correct? Shouldn't it be rather:

    if (*epp && rc != OK) user_message = NULL;

user_message should be cleared if there is endpass modifier and rule
condition _fails_ because then control moves to next rule.


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

[Bug 795] No user message after accept with endpass on ACL

by Bugzilla from nigel@exim.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=795

Nigel Metheringham <nigel@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID




--- Comment #1 from Nigel Metheringham <nigel@...>  2009-10-20 13:31:58 ---
Behaviour is as documented in section
http://docs.exim.org/current/spec_html/ch40.html#SECID200


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##