[Bug 901] New: Patch to remove differ in signedness (exim-4.70 RC2)

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=901
           Summary: Patch to remove differ in signedness  (exim-4.70 RC2)
           Product: Exim
           Version: N/A
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: bug
          Priority: medium
         Component: Packaging
        AssignedTo: nigel@...
        ReportedBy: serge-exim@...
                CC: exim-dev@...


Hi,

When compiled with gcc and -Wall causes differ in signedness as:

malware.c:234 --> parentheses around assignment used as truth value

parse.c:1778 --> unused variable 'o' ==> removed
parse.c:1779 --> const uschar *day_name[7]={ "mon"... ==> US"mon"...
parse.c:1837 --> strncmp ==> Ustrncmp
parse.c:1790 --> const uschar *month_name[]={ "jan"... ==> US"jan"...

sieve.c:2974 --> strncmp ==> Ustrncmp
sieve.c:3041 --> strncmp ==> Ustrncmp
sieve.c:3043 --> strncmp ==> Ustrncmp
sieve.c:3045 --> expand_string("..." ==> expand_string(US"..."
sieve.c:3071 --> expand_string("..." ==> expand_string(US"..."

tls-openssl.c:76 --> msg = ssl_errstring ==> msg = (uschar*)ssl_errstring
tls-openssl.c:82 --> strncmp ==> Ustrncmp
tls-openssl.c:256 --> char * ==> (uschar *)
tls-openssl.c:624 --> char * ==> US"..."


Not cleaned:
---

receive.c:1288 --> warning: 'rc' may be used uninitialized in this function




The patchs remove errors:

* exim-4.70RC2-differ_in_signedness.patch

Tested in GNU/Linux x86_64/i686


Sorry, if it isn't real bug.. :-)

--Serge


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=901




--- Comment #1 from Serge Demonchaux <serge-exim@...>  2009-11-05 13:21:06 ---
Created an attachment (id=337)
 --> (http://bugs.exim.org/attachment.cgi?id=337)
patch exim-4.70RC2  remove differ in signedness

Patch exim-4.70RC2-differ_in_signedness.patch


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=901

Nigel Metheringham <nigel@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Nigel Metheringham <nigel@...>  2009-11-05 19:40:51 ---
CVS commit by nm4:

Fix signed/unsigned and UTF errors  Fixes: bug#901

--- CVS commit summary ---
1.586  1.587  +3 -0  -  exim/exim-doc/doc-txt/ChangeLog
1.16   1.17   +1 -1  -  exim/exim-src/src/malware.c
1.13   1.14   +3 -4  -  exim/exim-src/src/parse.c
1.37   1.38   +5 -5  -  exim/exim-src/src/sieve.c
1.20   1.21   +5 -5  -  exim/exim-src/src/tls-openssl.c


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=901




--- Comment #3 from Serge Demonchaux <serge-exim@...>  2009-11-05 20:25:30 ---
Created an attachment (id=338)
 --> (http://bugs.exim.org/attachment.cgi?id=338)
differ in signedness: src/spf.c

src/spf.c
Fixed differ in signedness


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##