[Bug fortran/25068] New: better diagnostic needed

using GNU Fortran 95 (GCC) 4.1.0 20051126 (prerelease)  with '-g -pedantic
-std=f95', I get a bad / no diagnostic for the following invalid code:

 INTEGER*8 :: I
 OPEN(10,FILE="fort.10")
 CLOSE(10,IOSTAT=I)
END


--
           Summary: better diagnostic needed
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jv244 at cam dot ac dot uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068

------- Comment #1 from fxcoudert at gcc dot gnu dot org  2005-11-26 19:40 -------
Humm... I don't think that one is bug, really. I think we have the right to
accept non-default IOSTAT variable if we do it correctly ;)

## gfortran ##
## g95 ##
In file foo.f90:3

 CLOSE(10,IOSTAT=I)
                  1
Error: IOSTAT variable at (1) must be a default integer
## Intel ##
## Portland ##
PGF90-S-0201-Illegal I/O specifier - IOSTAT (foo.f90: 3)
  0 inform,   0 warnings,   1 severes, 0 fatal for MAIN
## Sun ##


--


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068

------- Comment #2 from jv244 at cam dot ac dot uk  2005-11-26 20:19 -------
(In reply to comment #1)
> I think we have the right to
> accept non-default IOSTAT variable if we do it correctly ;)

not with -std=f95


--


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068

------- Comment #3 from kargl at gcc dot gnu dot org  2005-11-27 19:07 -------
Sigh. Change subject to something meaningful.


--

kargl at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|better diagnostic needed    |IOSTAT should be default
                   |                            |integer when -std=f95


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068

------- Comment #4 from fxcoudert at gcc dot gnu dot org  2005-12-10 19:42 -------
(In reply to comment #2)
>> I think we have the right to
>> accept non-default IOSTAT variable if we do it correctly ;)
>
> not with -std=f95

This time, I read both the F95 and F2003 standard, and this is indeed a F95
constraint that disapeared in F2003. How cool!


--

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-12-10 19:42:53
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068

------- Comment #5 from fxcoudert at gcc dot gnu dot org  2005-12-10 21:44 -------
Subject: Bug 25068

Author: fxcoudert
Date: Sat Dec 10 21:44:43 2005
New Revision: 108360

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=108360
Log:
        PR fortran/25068

        * io.c (resolve_tag): Add correct diagnostic for F2003 feature.

        * gfortran.dg/iostat_3.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/iostat_3.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/io.c
    trunk/gcc/testsuite/ChangeLog


--


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068

------- Comment #6 from fxcoudert at gcc dot gnu dot org  2005-12-10 21:53 -------
Fixed on mainline. Will backport the fix to 4.1 after a few days.


--

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |fxcoudert at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch
      Known to fail|                            |4.1.0 4.0.3
      Known to work|                            |4.2.0
   Last reconfirmed|2005-12-10 19:42:53         |2005-12-10 21:53:40
               date|                            |
            Summary|IOSTAT should be default    |[4.0/4.1] IOSTAT should be
                   |integer when -std=f95       |default integer when -
                   |                            |std=f95
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068

------- Comment #7 from kargl at gcc dot gnu dot org  2005-12-11 00:39 -------
Subject: Bug 25068

Author: kargl
Date: Sun Dec 11 00:39:14 2005
New Revision: 108371

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=108371
Log:
Fix testsuite after this commit:

   2005-12-10  Francois-Xavier Coudert  <coudert@...>

    PR fortran/25068
    * gfortran.dg/iostat_3.f90: New test.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/g77/19981216-0.f


--


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068

------- Comment #8 from mmitchel at gcc dot gnu dot org  2005-12-19 18:16 -------
Fortran issues are not release-critical: P5.


--

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068

------- Comment #9 from pault at gcc dot gnu dot org  2005-12-22 07:06 -------
Subject: Bug 25068

Author: pault
Date: Thu Dec 22 07:05:22 2005
New Revision: 108943

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=108943
Log:
2005-12-22  Paul Thomas  <pault@...>

        PR fortran/20889
        *resolve.c(resolve_structure_cons): Do not attempt to convert
        the type of mismatched pointer type components, except when
        the constructor component is BT_UNKNOWN; emit error instead.

        PR fortran/25029
        PR fortran/21256
        *resolve.c(check_assumed_size_reference): New function to check for
upper
        bound in assumed size array references.
        (resolve_assumed_size_actual): New function to do a very restricted
scan
        of actual argument expressions of those procedures for which incomplete
        assumed size array references are not allowed.
        (resolve_function, resolve_call): Switch off assumed size checking of
        actual arguments, except for elemental procedures and array valued
        intrinsics; excepting LBOUND.
        (resolve_variable): Call check_assumed_size_reference.

        PR fortran/19362
        PR fortran/20244
        PR fortran/20864
        PR fortran/25391
        *interface.c(gfc_compare_types): Broken into two.
        (gfc_compare_derived_types): Second half of gfc_compare_types with
        corrections for a missing check that module name is non-NULL and
        a check for private components.
        *symbol.c(gfc_free_dt_list): New function.
        (gfc_free_namespace): Call gfc_free_dt_list.
        *resolve.c(resolve_symbol): Build the list of derived types in the
        symbols namespace.
        *gfortran.h: Define the structure type gfc_dt_list.  Add a new field,
        derived_types to gfc_namespace.  Provide a prototye for the new
        function gfc_compare_derived_types.
        *trans_types.c(gfc_get_derived_type): Test for the derived type being
        available in the host namespace. In this case, the host backend
        declaration is used for the structure and its components.  If an
        unbuilt, equal structure that is not use associated is found in the
        host namespace, build it there and then.  On exit,traverse the
        namespace of the derived type to see if there are equal but unbuilt.
        If so, copy the structure and its component declarations.
        (copy_dt_decls_ifequal): New functions to copy declarations to other
        equal structure types.

        PR fortran/20862
        * io.c (gfc_match_format): Make the appearance of a format statement
        in a module specification block an error.

        PR fortran/23152
        * match.c (gfc_match_namelist): Set assumed shape arrays in
        namelists as std=GFC_STD_GNU and assumed size arrays as an
        unconditional error.

        PR fortran/25069
        * match.c (gfc_match_namelist): Set the respecification of a USE
        associated namelist group as std=GFC_STD_GNU.  Permit the concatenation
        on no error.

        PR fortran/25053
        PR fortran/25063
        PR fortran/25064
        PR fortran/25066
        PR fortran/25067
        PR fortran/25068
        PR fortran/25307
        * io.c (resolve_tag): Change std on IOSTAT != default integer to
        GFC_STD_GNU and change message accordingly.  Add same error for
        SIZE.
        (match_dt_element, gfortran.h): Add field err_where to gfc_dt and
        set it when tags are being matched.
        (gfc_resolve_dt): Remove tests that can be done before resolution
        and add some of the new ones here.
        (check_io_constraints): New function that checks for most of the
        data transfer constraints. Some of these were previously done in
        match_io, from where this function is called, and some were done
        in gfc_resolve_dt.
        (match_io): Remove most of the tests of constraints and add the
        call to check_io_constraints.

2005-12-22  Paul Thomas  <pault@...>

        PR fortran/20889
        *gfortran.dg/pointer_component_type_1.f90: New test.

        PR fortran/25029
        PR fortran/21256
        *gfortran.dg/assumed_size_refs.f90: New test for the conditions that
        should give an error with assumed size array refernces and checks those
        that should not.
        *gfortran.dg/gfortran.dg/pr15140.f90: Give the assumed size array
        reference an upper bound so that it does not generate an error.

        PR fortran/19362
        PR fortran/20244
        PR fortran/20864
        PR fortran/25391
        *gfortran.dg/used_dummy_types_1.f90: New test.
        *gfortran.dg/used_dummy_types_2.f90: New test.
        *gfortran.dg/used_dummy_types_3.f90: New test.
        *gfortran.dg/used_dummy_types_4.f90: New test.
        *gfortran.dg/used_dummy_types_5.f90: New test.

        PR fortran/23152
        *gfortran.dg/namelist_use.f90: Add trap for warning on NAMELIST
        group already being USE associated.
        *gfortran.dg/assumed_shape_nml.f90: New test.
        *gfortran.dg/assumed_size_nml.f90: New test.

        PR fortran/20862
        PR fortran/25053
        PR fortran/25063
        PR fortran/25064
        PR fortran/25066
        PR fortran/25067
        PR fortran/25068
        PR fortran/25307
        * gfortran.dg/io_constraints_1.f90: New test.
        * gfortran.dg/io_constraints_1.f90: New test.
        * gfortran.dg/iostat_3.f90: Change wording of warning.
         * gfortran.dg/g77/19981216-0.f:  the same.

Added:
    trunk/gcc/testsuite/gfortran.dg/assumed_shape_nml.f90
    trunk/gcc/testsuite/gfortran.dg/assumed_size_nml.f90
    trunk/gcc/testsuite/gfortran.dg/io_constraints_1.f90
    trunk/gcc/testsuite/gfortran.dg/io_constraints_2.f90
    trunk/gcc/testsuite/gfortran.dg/pointer_component_type_1.f90
    trunk/gcc/testsuite/gfortran.dg/used_dummy_types_1.f90
    trunk/gcc/testsuite/gfortran.dg/used_dummy_types_2.f90
    trunk/gcc/testsuite/gfortran.dg/used_dummy_types_3.f90
    trunk/gcc/testsuite/gfortran.dg/used_dummy_types_4.f90
    trunk/gcc/testsuite/gfortran.dg/used_dummy_types_5.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/interface.c
    trunk/gcc/fortran/io.c
    trunk/gcc/fortran/match.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/symbol.c
    trunk/gcc/fortran/trans-types.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/g77/19981216-0.f
    trunk/gcc/testsuite/gfortran.dg/initialization_1.f90
    trunk/gcc/testsuite/gfortran.dg/iostat_3.f90
    trunk/gcc/testsuite/gfortran.dg/namelist_use.f90
    trunk/gcc/testsuite/gfortran.dg/pr15140.f90


--


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068

------- Comment #10 from pault at gcc dot gnu dot org  2005-12-26 09:07 -------
Subject: Bug 25068

Author: pault
Date: Mon Dec 26 09:07:27 2005
New Revision: 109061

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=109061
Log:
2005-12-26  Paul Thomas  <pault@...>

        PR fortran/20889
        *resolve.c(resolve_structure_cons): Do not attempt to convert
        the type of mismatched pointer type components, except when
        the constructor component is BT_UNKNOWN; emit error instead.

        PR fortran/25018
        * expr.c (check_inquiry): Return FAILURE if there is no symtree to
        provide a name. Error/warning for assumed character length argument
        to LEN for an initialization expression, using GFC_GNU_STD. Add an
        argument to flag that the expression is not restricted.
        (check_init_expr): Improve the message for a failing variable.
        (gfc_match_init_expr): Call check_enquiry again to make sure that
        unsimplified expressions are not causing unnecessary errors.

        PR fortran/19362
        PR fortran/20244
        PR fortran/20864
        PR fortran/25391
        * interface.c (gfc_compare_types): Broken into two.
        (gfc_compare_derived_types): Second half of gfc_compare_types with
        corrections for a missing check that module name is non-NULL and
        a check for private components.
        * symbol.c (gfc_free_dt_list): New function.
        (gfc_free_namespace): Call gfc_free_dt_list.
        * resolve.c (resolve_symbol): Build the list of derived types in the
        symbols namespace.
        * gfortran.h: Define the structure type gfc_dt_list.  Add a new field,
        derived_types to gfc_namespace.  Provide a prototye for the new
        function gfc_compare_derived_types.
        * trans_types.c (gfc_get_derived_type): Test for the derived type being
        available in the host namespace. In this case, the host backend
        declaration is used for the structure and its components.  If an
        unbuilt, equal structure that is not use associated is found in the
        host namespace, build it there and then.  On exit,traverse the
        namespace of the derived type to see if there are equal but unbuilt.
        If so, copy the structure and its component declarations.
        (copy_dt_decls_ifequal): New functions to copy declarations to other
        equal structure types.

        PR fortran/20862
        * io.c (gfc_match_format): Make the appearance of a format statement
        in a module specification block an error.

        PR fortran/23152
        * match.c (gfc_match_namelist): Set assumed shape arrays in
        namelists as std=GFC_STD_GNU and assumed size arrays as an
        unconditional error.

        PR fortran/25069
        * match.c (gfc_match_namelist): Set the respecification of a USE
        associated namelist group as std=GFC_STD_GNU.  Permit the concatenation
        on no error.

        PR fortran/25053
        PR fortran/25063
        PR fortran/25064
        PR fortran/25066
        PR fortran/25067
        PR fortran/25068
        PR fortran/25307
        * io.c (resolve_tag): Change std on IOSTAT != default integer to
        GFC_STD_GNU and change message accordingly.  Add same error for
        SIZE.
        (match_dt_element, gfortran.h): Add field err_where to gfc_dt and
        set it when tags are being matched.
        (gfc_resolve_dt): Remove tests that can be done before resolution
        and add some of the new ones here.
        (check_io_constraints): New function that checks for most of the
        data transfer constraints. Some of these were previously done in
        match_io, from where this function is called, and some were done
        in gfc_resolve_dt.
        (match_io): Remove most of the tests of constraints and add the
        call to check_io_constraints.

2005-12-26  Paul Thomas  <pault@...>

        PR fortran/20889
        * gfortran.dg/pointer_component_type_1.f90: New test.

        PR fortran/25018
        * gfortran.dg/initialization_1.f90: New test.
        * gfortran.dg/enum_5.f90: Change dg-error to new message.
        * gfortran.dg/g77/980616-0.f: The same.

        PR fortran/19362
        PR fortran/20244
        PR fortran/20864
        PR fortran/25391
        *gfortran.dg/used_dummy_types_1.f90: New test.
        *gfortran.dg/used_dummy_types_2.f90: New test.
        *gfortran.dg/used_dummy_types_3.f90: New test.
        *gfortran.dg/used_dummy_types_4.f90: New test.
        *gfortran.dg/used_dummy_types_5.f90: New test.

        PR fortran/23152
        * gfortran.dg/namelist_use.f90: Add trap for warning on NAMELIST
        group already being USE associated.
        * gfortran.dg/assumed_shape_nml.f90: New test.
        * gfortran.dg/assumed_size_nml.f90: New test.

        PR fortran/20862
        PR fortran/25053
        PR fortran/25063
        PR fortran/25064
        PR fortran/25066
        PR fortran/25067
        PR fortran/25068
        PR fortran/25307
        * gfortran.dg/io_constraints_1.f90: New test.
        * gfortran.dg/io_constraints_1.f90: New test.
        * gfortran.dg/iostat_3.f90: Change wording of warning.
        * gfortran.dg/g77/19981216-0.f:  the same.

Modified:
    branches/gcc-4_1-branch/gcc/fortran/ChangeLog
    branches/gcc-4_1-branch/gcc/fortran/expr.c
    branches/gcc-4_1-branch/gcc/fortran/gfortran.h
    branches/gcc-4_1-branch/gcc/fortran/interface.c
    branches/gcc-4_1-branch/gcc/fortran/io.c
    branches/gcc-4_1-branch/gcc/fortran/match.c
    branches/gcc-4_1-branch/gcc/fortran/resolve.c
    branches/gcc-4_1-branch/gcc/fortran/symbol.c
    branches/gcc-4_1-branch/gcc/fortran/trans-types.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/enum_5.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/g77/19981216-0.f
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/g77/980616-0.f
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/namelist_use.f90


--


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068

------- Comment #11 from pault at gcc dot gnu dot org  2005-12-26 13:18 -------
Fixed on trunk and 4.1


--

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068

------- Comment #12 from pault at gcc dot gnu dot org  2005-12-29 06:18 -------
Subject: Bug 25068

Author: pault
Date: Thu Dec 29 06:18:23 2005
New Revision: 109139

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=109139
Log:
2005-12-29  Paul Thomas  <pault@...>

        PR fortran/25532
        * trans-types.c (copy_dt_decls_ifequal): Copy declarations for
        components of derived type components by recursing into
        gfc_get_derived_type.

2005-12-29  Paul Thomas  <pault@...>

        PR fortran/25532
        *gfortran.dg/host_used_types_1.f90: Check that host associated
        derived type components of derived types are properly declared
        in contained procedures.

        The following tests were not added on the 2005-12-26 commit.

        PR fortran/20889
        * gfortran.dg/pointer_component_type_1.f90: New test.

        PR fortran/25018
        * gfortran.dg/initialization_1.f90: New test.

        PR fortran/19362
        PR fortran/20244
        PR fortran/20864
        PR fortran/25391
        * gfortran.dg/used_dummy_types_1.f90: New test.
        * gfortran.dg/used_dummy_types_2.f90: New test.
        * gfortran.dg/used_dummy_types_3.f90: New test.
        * gfortran.dg/used_dummy_types_4.f90: New test.
        * gfortran.dg/used_dummy_types_5.f90: New test.

        PR fortran/23152
        * gfortran.dg/assumed_shape_nml.f90: New test.
        * gfortran.dg/assumed_size_nml.f90: New test.

        PR fortran/20862
        PR fortran/25053
        PR fortran/25063
        PR fortran/25064
        PR fortran/25066
        PR fortran/25067
        PR fortran/25068
        PR fortran/25307
        * gfortran.dg/io_constraints_1.f90: New test.
        * gfortran.dg/io_constraints_1.f90: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/assumed_shape_nml.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/assumed_size_nml.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/host_used_types_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/initialization_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/io_constraints_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/io_constraints_2.f90
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/pointer_component_type_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/used_dummy_types_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/used_dummy_types_2.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/used_dummy_types_3.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/used_dummy_types_4.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/used_dummy_types_5.f90
Modified:
    branches/gcc-4_1-branch/gcc/fortran/ChangeLog
    branches/gcc-4_1-branch/gcc/fortran/trans-types.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


--


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25068