[Bug gas/10856] New: [2.20 regression] gas creates wrong code which results in a test failure in libcrypto++'s sha2 test

The patch to fix PR gas/10704 causes sha.cpp assembled in a way that causes the
sha-256 test not to terminate. Undoing the patch runs the test fine. Replacing
the sha.o with one assembled with gas having this patch reverted lets the test pass.

--
           Summary: [2.20 regression] gas creates wrong code which results
                    in a test failure in libcrypto++'s sha2 test
           Product: binutils
           Version: 2.20
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gas
        AssignedTo: unassigned at sources dot redhat dot com
        ReportedBy: doko at debian dot org
                CC: bug-binutils at gnu dot org
GCC target triplet: x86_64-linux-gnu


http://sourceware.org/bugzilla/show_bug.cgi?id=10856

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From doko at debian dot org  2009-10-27 23:55 -------
Created an attachment (id=4329)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4329&action=view)
diff of disassembled files


--


http://sourceware.org/bugzilla/show_bug.cgi?id=10856

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From doko at debian dot org  2009-10-27 23:56 -------
Created an attachment (id=4330)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4330&action=view)
sha .s and .o files


--


http://sourceware.org/bugzilla/show_bug.cgi?id=10856

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From amodra at bigpond dot net dot au  2009-10-28 02:53 -------
Simpler testcase:

 .text
 .intel_syntax noprefix
 .space 5480
 .byte 0,0,0
0:
 .space 1620
 .byte 0
1:
 .space 2468
 nop
 jne 1b
 .space 52
 nop
 jl 0b

Without the .intel_syntax this assembles OK.


--


http://sourceware.org/bugzilla/show_bug.cgi?id=10856

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at sources dot   |amodra at bigpond dot net
                   |redhat dot com              |dot au
             Status|NEW                         |ASSIGNED
   Last reconfirmed|0000-00-00 00:00:00         |2009-10-28 06:46:51
               date|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=10856

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2009-10-28 08:21 -------
Subject: Bug 10856

CVSROOT: /cvs/src
Module name: src
Changes by: amodra@... 2009-10-28 08:21:45

Modified files:
        gas            : ChangeLog expr.c
        gas/testsuite  : ChangeLog
        gas/testsuite/gas/i386: intelpic.d

Log message:
        PR gas/10856
        * expr.c (resolve_expression): Only add "left" value to O_symbol
        expression when the symbol is undefined and different from the
        original symbol.  Simplify negative logic.
       
        * gas/i386/intelpic.d: Correct.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gas/ChangeLog.diff?cvsroot=src&r1=1.3999&r2=1.4000
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gas/expr.c.diff?cvsroot=src&r1=1.78&r2=1.79
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gas/testsuite/ChangeLog.diff?cvsroot=src&r1=1.1573&r2=1.1574
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/i386/intelpic.d.diff?cvsroot=src&r1=1.3&r2=1.4



--


http://sourceware.org/bugzilla/show_bug.cgi?id=10856

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2009-10-28 08:24 -------
Subject: Bug 10856

CVSROOT: /cvs/src
Module name: src
Branch: binutils-2_20-branch
Changes by: amodra@... 2009-10-28 08:23:49

Modified files:
        gas            : ChangeLog expr.c

Log message:
        PR gas/10856
        * expr.c (resolve_expression): Only add "left" value to O_symbol
        expression when the symbol is undefined and different from the
        original symbol.  Simplify negative logic.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gas/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_20-branch&r1=1.3938.2.27&r2=1.3938.2.28
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gas/expr.c.diff?cvsroot=src&only_with_tag=binutils-2_20-branch&r1=1.77.2.1&r2=1.77.2.2



--


http://sourceware.org/bugzilla/show_bug.cgi?id=10856

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From doko at debian dot org  2009-10-28 10:03 -------
checked that the sha test passes, when sha.o is built with this patch.


--


http://sourceware.org/bugzilla/show_bug.cgi?id=10856

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From amodra at bigpond dot net dot au  2009-10-28 10:08 -------
.

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=10856

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From amodra at bigpond dot net dot au  2009-11-05 12:14 -------
*** Bug 10906 has been marked as a duplicate of this bug. ***

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |freddy77 at gmail dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10856

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils