[Bug gold/10910] New: gold is broken

On x86-64 Fedora 11

gcc version 4.4.1 20090725 (Red Hat 4.4.1-2) (GCC)

and Fedora 10

gcc version 4.3.2 20081105 (Red Hat 4.3.2-7) (GCC)

most of gold tests failed with

gcctestdir/ld: internal error in set_section_list_addresses, at
/net/gnu-6/export/gnu/import/git/binutils/gold/output.cc:3562

--
           Summary: gold is broken
           Product: binutils
           Version: 2.21 (HEAD)
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gold
        AssignedTo: ian at airs dot com
        ReportedBy: hjl dot tools at gmail dot com
                CC: bug-binutils at gnu dot org


http://sourceware.org/bugzilla/show_bug.cgi?id=10910

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From hjl dot tools at gmail dot com  2009-11-05 17:33 -------
It is caused by

http://sourceware.org/ml/binutils/2009-11/msg00054.html

--


http://sourceware.org/bugzilla/show_bug.cgi?id=10910

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From hjl dot tools at gmail dot com  2009-11-05 18:02 -------
The problem came from .note.ABI-tag and  .note.gnu.build-id
output sections.

--


http://sourceware.org/bugzilla/show_bug.cgi?id=10910

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From hjl dot tools at gmail dot com  2009-11-05 18:43 -------
Both .note.ABI-tag .note.gnu.build-id sections can appear in 2 segments:

 Section to Segment mapping:
  Segment Sections...
   00    
   01     .interp
   02     .interp .note.ABI-tag .note.gnu.build-id .gnu.hash .dynsym .dynstr
.gnu.version .gnu.version_r .rela.dyn .rela.plt .init .plt .text .fini .rodata
.eh_frame_hdr .eh_frame .gcc_except_table
   03     .ctors .dtors .jcr .dynamic .got .got.plt .data .bss
   04     .dynamic
   05     .note.ABI-tag .note.gnu.build-id
   06     .eh_frame_hdr
   07    


--


http://sourceware.org/bugzilla/show_bug.cgi?id=10910

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From hjl dot tools at gmail dot com  2009-11-05 19:09 -------
.note.ABI-tag .note.gnu.build-id sections are put in PT_LOAD segment
twice.

--


http://sourceware.org/bugzilla/show_bug.cgi?id=10910

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From hjl dot tools at gmail dot com  2009-11-05 19:23 -------
The bug is in do_sort in Output_segment::add_output_section(). It
adds a note section without removing the old one.

--


http://sourceware.org/bugzilla/show_bug.cgi?id=10910

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2009-11-05 19:54 -------
Subject: Bug 10910

CVSROOT: /cvs/src
Module name: src
Changes by: ian@... 2009-11-05 19:54:30

Modified files:
        gold           : ChangeLog output.cc

Log message:
        PR 10910
        * output.cc (Output_segment::add_output_section): Add missing
        return statement.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gold/ChangeLog.diff?cvsroot=src&r1=1.346&r2=1.347
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gold/output.cc.diff?cvsroot=src&r1=1.103&r2=1.104



--


http://sourceware.org/bugzilla/show_bug.cgi?id=10910

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2009-11-05 19:58 -------
Subject: Bug 10910

CVSROOT: /cvs/src
Module name: src
Branch: binutils-2_20-branch
Changes by: ian@... 2009-11-05 19:58:28

Modified files:
        gold           : ChangeLog output.cc

Log message:
        PR 10910
        * output.cc (Output_segment::add_output_section): Add missing
        return statement.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gold/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_20-branch&r1=1.281.2.10&r2=1.281.2.11
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gold/output.cc.diff?cvsroot=src&only_with_tag=binutils-2_20-branch&r1=1.94.2.3&r2=1.94.2.4



--


http://sourceware.org/bugzilla/show_bug.cgi?id=10910

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From hjl dot tools at gmail dot com  2009-11-05 19:59 -------
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gold/output.cc.diff?cvsroot=src&r1=1.103&r2=1.104

doesn't match the ChangeLog entry. Is

@@ -3558,9 +3554,11 @@
     off += (*p)->address() - (addr + (off - startoff));
   else
     {
+#if 0
       if (!layout->script_options()->saw_sections_clause())
  gold_unreachable();
       else
+#endif
  {
   Output_section* os = (*p)->output_section();

intentional?

--


http://sourceware.org/bugzilla/show_bug.cgi?id=10910

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils

------- Additional Comments From ian at airs dot com  2009-11-05 20:01 -------
I already committed a patch to remove the erroneous #if 0.

Bug is fixed.

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=10910

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@...
http://lists.gnu.org/mailman/listinfo/bug-binutils