[Bug libc/4457] New: Allow ports a simple override of "libgcc_s.so.1" in sysdeps/generic/framestate.c

The file sysdeps/generic/framestate.c has a hardcoded value of "libgcc.so.1".
Some architectures have bumped the so version on libgcc_s and therefore the
hardcoded value is wrong.

It would be nice if ports could write:
ports/sysdeps/$target/framestate.c:
#define LIBGCC_S_SO "libgcc_so.so.2"
#include-next <framestate.c>

There are other alternatives but this one seemed the simplest and easiest to
maintain.

Patch attached.

--
           Summary: Allow ports a simple override of "libgcc_s.so.1" in
                    sysdeps/generic/framestate.c
           Product: glibc
           Version: 2.3.6
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: carlos at systemhalted dot org
                CC: glibc-bugs at sources dot redhat dot com
 GCC build triplet: hppa-linux-gnu
  GCC host triplet: hppa-linux-gnu
GCC target triplet: hppa-linux-gnu


http://sourceware.org/bugzilla/show_bug.cgi?id=4457

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

------- Additional Comments From carlos at systemhalted dot org  2007-05-03 06:32 -------
Created an attachment (id=1746)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=1746&action=view)
[PATCH] Allow override of "libgcc_s.so.1" in framestate.c

This patch allows the override of "libgcc_s.so.1" in
sysdeps/generic/framestate.c.

Tested without regressions on hppa-linux-gnu.

--


http://sourceware.org/bugzilla/show_bug.cgi?id=4457

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

------- Additional Comments From jakub at redhat dot com  2007-05-07 15:40 -------
framestate.c is so short that I wonder if it isn't better just to duplicate
the file in ports.

--


http://sourceware.org/bugzilla/show_bug.cgi?id=4457

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

------- Additional Comments From drepper at redhat dot com  2007-08-22 07:15 -------
No reply in 3+ months.  Closing.

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |WORKSFORME


http://sourceware.org/bugzilla/show_bug.cgi?id=4457

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

------- Additional Comments From mkuvyrkov at gmail dot com  2009-08-23 18:53 -------
Created an attachment (id=4144)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4144&action=view)
Another attempt

Hello,

The attached patch makes another attempt to fix this issue.

It doesn't implement exactly the solution Ulrich proposed above in that it
doesn't detects the version of libgcc_s.so installed.  Instead, the patch make
GLIBC to rely on shlib-versions files to specify it.

The entry in top-level shlib-versions file specifies the version of libgcc_s to
be '1' (what most architectures have) and shlib-versions in sysdeps directories
can override that.

FWIW, making GLIBC to autodetect the version of libgcc_s installed does not
seem trivial to me.

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1746 is|0                           |1
           obsolete|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=4457

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

------- Additional Comments From mkuvyrkov at gmail dot com  2009-08-23 18:55 -------
Created an attachment (id=4145)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4145&action=view)
Set libgcc_s' version for m68k and hppa

This patch sets libgcc_s' version to 2 for m68k and to 4 for hppa.

The combined patch was tested on m68k and powerpc.

--


http://sourceware.org/bugzilla/show_bug.cgi?id=4457

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

------- Additional Comments From mkuvyrkov at gmail dot com  2009-08-23 18:56 -------
Would please maintainers kindly consider the patches attached above?

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WORKSFORME                  |


http://sourceware.org/bugzilla/show_bug.cgi?id=4457

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

------- Additional Comments From mkuvyrkov at gmail dot com  2009-10-26 20:09 -------
Ping.

Would maintainers please kindly consider the patches in the attachment.

--


http://sourceware.org/bugzilla/show_bug.cgi?id=4457

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

------- Additional Comments From carlos at systemhalted dot org  2009-11-08 18:46 -------
This is now fixed on trunk by these patches.

This fix will be part of 2.11 given that the 2.11 branch happens from trunk.

/

2009-11-03  Andreas Schwab  <schwab@...>

[BZ #4457]
* sysdeps/generic/libgcc_s.h: New file.
* sysdeps/generic/framestate.c: Include it and use LIBGCC_S_SO.

nptl/

2009-11-03  Andreas Schwab  <schwab@...>

[BZ #4457]
* sysdeps/pthread/unwind-resume.c: Include <libgcc_s.h> and use
LIBGCC_S_SO.
* sysdeps/pthread/unwind-forcedunwind.c: Likewise.



--
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=4457

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |10920
              nThis|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=4457

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |10921
              nThis|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=4457

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

------- Additional Comments From carlos at systemhalted dot org  2009-11-08 18:55 -------
Per the new bugzilla procedure I've opened new issues for m68k and hppa to
provide libgcc_s.h.

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|10920, 10921                |
              nThis|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=4457

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.