[CalendarServer] #274: caldavd does not properly quote parameters

View: New views
3 Messages — Rating Filter:   Alert me  

[CalendarServer] #274: caldavd does not properly quote parameters

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#274: caldavd does not properly quote parameters
---------------------------------+------------------------------------------
 Reporter:  kmdurbrow@...  |       Owner:  wsanchez@...
     Type:  Defect               |      Status:  new              
 Priority:  5: Not set           |   Milestone:                    
Component:  Calendar Server      |     Version:                    
 Severity:  Other                |    Keywords:                    
---------------------------------+------------------------------------------
 Last line of caldavd

 {{{
 ${configfile}
 }}}

 should be quoted

--
Ticket URL: <https://trac.calendarserver.org/ticket/274>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo/calendarserver-dev

Re: [CalendarServer] #274: caldavd does not properly quote parameters

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#274: caldavd does not properly quote parameters
---------------------------------+------------------------------------------
 Reporter:  kmdurbrow@...  |        Owner:  wsanchez@...
     Type:  Defect               |       Status:  new              
 Priority:  3: Important         |    Milestone:  2.x              
Component:  Calendar Server      |      Version:                    
 Severity:  Other                |   Resolution:                    
 Keywords:                       |  
---------------------------------+------------------------------------------
Changes (by wsanchez@...):

  * priority:  5: Not set => 3: Important
  * milestone:  => 2.x

Comment:

 This is tricky. `"${configfile}"` is either `""` or `"-f some_file"`. (In
 your case, I'm assuming it's actually `"-f some file"`, with a space.)  So
 quoting it outright makes it into one token, which isn't what we want; we
 want zero or two tokens.

 I think what actually wants to change is something like

 {{{
 configfile="-f ${OPTARG}"
 }}}

 to

 {{{
 configfile="-f \"${OPTARG}\""
 }}}

 But then the exec line at the bottom still tokenized on the space in the
 filename...  Don't know what the right way to fix that is, offhand, other
 than to rewrite the script in a language (Python) that doesn't have this
 goofy tokenization stuff all over the place.

--
Ticket URL: <https://trac.calendarserver.org/ticket/274#comment:1>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-dev

Re: [CalendarServer] #274: caldavd does not properly quote parameters

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#274: caldavd does not properly quote parameters
---------------------------------+------------------------------------------
 Reporter:  kmdurbrow@…          |       Owner:  glyph@…          
     Type:  Defect               |      Status:  new              
 Priority:  3: Important         |   Milestone:  CalendarServer-3.x
Component:  Calendar Server      |    Severity:  Other            
 Keywords:                       |  
---------------------------------+------------------------------------------
Changes (by wsanchez@…):

  * owner:  wsanchez@… => glyph@…
  * milestone:  CalendarServer-2.x => CalendarServer-3.x


Comment:

 Might be time to pythonify this.  Glyph was itching to do that, I think.

 May also make sense to skip twistd and start the server from within
 caldavd directly, ya?

--
Ticket URL: <http://trac.calendarserver.org/ticket/274#comment:2>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-dev