[CalendarServer] #285: Uses deprecated twisted interfaces

View: New views
10 Messages — Rating Filter:   Alert me  

[CalendarServer] #285: Uses deprecated twisted interfaces

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#285: Uses deprecated twisted interfaces
-----------------------------+----------------------------------------------
 Reporter:  agx@...  |       Owner:  wsanchez@...
     Type:  Defect           |      Status:  new              
 Priority:  5: Not set       |   Milestone:                    
Component:  Calendar Server  |     Version:                    
 Severity:  Other            |    Keywords:                    
-----------------------------+----------------------------------------------
 In Debian we splitted out things enough (so we don't have to ship our own
 twisted). We only ship the patched web2 plugin + twistedcaldav. With
 recent twisted we're seeing:

 /usr/lib/python2.5/site-packages/twisted/plugins/twisted_web2.py:22:
 DeprecationWarning: mktap and related support modules are deprecated as of
 Twisted 8.0.  Use Twisted Application Plugins with the 'twistd' command
 directly, as described in 'Writing a Twisted Application Plugin for
 twistd' chapter of the Developer Guide.
   from twisted.scripts.mktap import _tapHelper

 This is 1.2 but the code in 1.3 looks pretty much the same. I assume you
 guys will want switch to newer twisted sooner or later. Any hints on how
 to fix this in a way that can go into your SVN.

--
Ticket URL: <http://trac.calendarserver.org/ticket/285>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-dev

Re: [CalendarServer] #285: Uses deprecated twisted interfaces

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#285: Uses deprecated twisted interfaces
-----------------------------+----------------------------------------------
 Reporter:  agx@...  |        Owner:  wsanchez@...
     Type:  Defect           |       Status:  new              
 Priority:  5: Not set       |    Milestone:                    
Component:  Calendar Server  |      Version:                    
 Severity:  Other            |   Resolution:                    
 Keywords:                   |  
-----------------------------+----------------------------------------------
Old description:

> In Debian we splitted out things enough (so we don't have to ship our own
> twisted). We only ship the patched web2 plugin + twistedcaldav. With
> recent twisted we're seeing:
>
> /usr/lib/python2.5/site-packages/twisted/plugins/twisted_web2.py:22:
> DeprecationWarning: mktap and related support modules are deprecated as
> of Twisted 8.0.  Use Twisted Application Plugins with the 'twistd'
> command directly, as described in 'Writing a Twisted Application Plugin
> for twistd' chapter of the Developer Guide.
>   from twisted.scripts.mktap import _tapHelper
>
> This is 1.2 but the code in 1.3 looks pretty much the same. I assume you
> guys will want switch to newer twisted sooner or later. Any hints on how
> to fix this in a way that can go into your SVN.

New description:

 In Debian we splitted out things enough (so we don't have to ship our own
 twisted). We only ship the patched web2 plugin + twistedcaldav. With
 recent twisted we're seeing:

 {{{
 /usr/lib/python2.5/site-packages/twisted/plugins/twisted_web2.py:22:
 DeprecationWarning: mktap and related support modules are deprecated as of
 Twisted 8.0.  Use Twisted Application Plugins with the 'twistd' command
 directly, as described in 'Writing a Twisted Application Plugin for
 twistd' chapter of the Developer Guide.
   from twisted.scripts.mktap import _tapHelper
 }}}

 This is 1.2 but the code in 1.3 looks pretty much the same. I assume you
 guys will want switch to newer twisted sooner or later. Any hints on how
 to fix this in a way that can go into your SVN.

--
Ticket URL: <http://trac.calendarserver.org/ticket/285#comment:1>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-dev

Re: [CalendarServer] #285: Uses deprecated twisted interfaces

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#285: Uses deprecated twisted interfaces
-----------------------------+----------------------------------------------
 Reporter:  agx@...  |        Owner:  wsanchez@...
     Type:  Defect           |       Status:  closed            
 Priority:  5: Not set       |    Milestone:                    
Component:  Calendar Server  |      Version:                    
 Severity:  Other            |   Resolution:  worksforme        
 Keywords:                   |  
-----------------------------+----------------------------------------------
Changes (by wsanchez@...):

  * status:  new => closed
  * resolution:  => worksforme

Comment:

 I *think* you can avoid this by simply deleting `/usr/lib/python2.5/site-
 packages/twisted/plugins/twisted_web2.py`.  I don't think we use that TAP
 plugin in any form, but the way Twisted loads its plugins causes some code
 to run even if you don't use them... Yeah, it doesn't look lie we install
 them in our OS X build.  We do install
  * `caldav` (ours)
  * `kqueuereactor` (not ours, but in from our source tree until we merge
 forward)
  * `twisted_reactors`
  * `twisted_trial`

--
Ticket URL: <http://trac.calendarserver.org/ticket/285#comment:2>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-dev

Re: [CalendarServer] #285: Uses deprecated twisted interfaces

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#285: Uses deprecated twisted interfaces
-----------------------------+----------------------------------------------
 Reporter:  agx@...  |        Owner:  wsanchez@...
     Type:  Defect           |       Status:  reopened          
 Priority:  5: Not set       |    Milestone:                    
Component:  Calendar Server  |      Version:                    
 Severity:  Other            |   Resolution:                    
 Keywords:                   |  
-----------------------------+----------------------------------------------
Changes (by agx@...):

  * status:  closed => reopened
  * resolution:  worksforme =>

Comment:

 removing /usr/lib/python2.5/site-packages/twisted/plugins/twisted_web2.py
 moves the warning to /usr/lib/python2.5/site-packages/twistedcaldav/tap.py
 - removing this one breaks the calendarserver startup:

 /usr/bin/twistd: unkown command: caldav

 So while I agree that this is a minor issue for the "official" version
 it's at least a small annoyance for other ports.

--
Ticket URL: <https://trac.calendarserver.org/ticket/285#comment:3>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-dev

Re: [CalendarServer] #285: Uses deprecated twisted interfaces

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#285: Uses deprecated twisted interfaces
-----------------------------+----------------------------------------------
 Reporter:  agx@...  |        Owner:  wsanchez@...
     Type:  Defect           |       Status:  closed            
 Priority:  5: Not set       |    Milestone:                    
Component:  Calendar Server  |      Version:                    
 Severity:  Other            |   Resolution:  worksforme        
 Keywords:                   |  
-----------------------------+----------------------------------------------
Changes (by wsanchez@...):

  * status:  reopened => closed
  * resolution:  => worksforme

Comment:

 My point is that the bug isn't in the Calendar Server; we can't fix this.
 The problem is in your separate Twisted web2 install; the warning is
 coming from twisted_web2.py, which is not owned by this project.

 I don't think that installing the patched web2 plugin into a system
 location is advisable, since that prevents you form installing the current
 web2 plugin from Twisted without breaking Calendar Server.  Unfortunately,
 given how Python does its path searching, that does require installing a
 complete separate Twisted for Calendar Server.

 The real problem is that we're on an old branch of web2, which I think is
 a different bug.

--
Ticket URL: <https://trac.calendarserver.org/ticket/285#comment:4>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-dev

Re: [CalendarServer] #285: Uses deprecated twisted interfaces

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#285: Uses deprecated twisted interfaces
-----------------------------+----------------------------------------------
 Reporter:  agx@...  |        Owner:  wsanchez@...
     Type:  Defect           |       Status:  closed            
 Priority:  5: Not set       |    Milestone:                    
Component:  Calendar Server  |      Version:                    
 Severity:  Other            |   Resolution:  worksforme        
 Keywords:                   |  
-----------------------------+----------------------------------------------
Comment (by agx@...):

 I won't press this issue, but (as I wrote above)j if I work around the
 twisted_web2.py case there's another warning in twistedcaldav/tap.py which
 _is_ part of calendarserver. I'd still be happier to have this bug in the
 Linux-Port section but it's your call.

--
Ticket URL: <https://trac.calendarserver.org/ticket/285#comment:5>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-dev

Re: [CalendarServer] #285: Uses deprecated twisted interfaces

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#285: Uses deprecated twisted interfaces
-----------------------------+----------------------------------------------
 Reporter:  agx@...  |        Owner:  wsanchez@...
     Type:  Defect           |       Status:  closed            
 Priority:  5: Not set       |    Milestone:                    
Component:  Calendar Server  |      Version:                    
 Severity:  Other            |   Resolution:  worksforme        
 Keywords:                   |  
-----------------------------+----------------------------------------------
Comment (by wsanchez@...):

 If you are getting `unkown command: caldav`, that's usually cause by (a)
 not finding the `caldav` plugin or (b) an exception while init'ing the
 plugin.

 This warning shouldn't be raising an exception.  Are you sure that's
 what's causing the error?

--
Ticket URL: <https://trac.calendarserver.org/ticket/285#comment:6>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-dev

Re: [CalendarServer] #285: Uses deprecated twisted interfaces

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#285: Uses deprecated twisted interfaces
-----------------------------+----------------------------------------------
 Reporter:  agx@...  |        Owner:  wsanchez@...
     Type:  Defect           |       Status:  closed            
 Priority:  5: Not set       |    Milestone:                    
Component:  Calendar Server  |      Version:                    
 Severity:  Other            |   Resolution:  worksforme        
 Keywords:                   |  
-----------------------------+----------------------------------------------
Comment (by agx@...):

 The error happens after I remove twisted_web2.py (as you suggested) and
 then twistedcaldav/tap.py (which is the second place causing this warning)
 so I think this is expected. Which means: there are parts *within* the
 calendarserver project (and not only in twisted) that cause the
 deprecation warning (which means this is a valid bug IMHO).

--
Ticket URL: <https://trac.calendarserver.org/ticket/285#comment:7>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-dev

Re: [CalendarServer] #285: Uses deprecated twisted interfaces

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#285: Uses deprecated twisted interfaces
-----------------------------+----------------------------------------------
 Reporter:  agx@...  |        Owner:  wsanchez@...
     Type:  Defect           |       Status:  reopened          
 Priority:  4: Nice to have  |    Milestone:  2.x              
Component:  Calendar Server  |      Version:                    
 Severity:  Other            |   Resolution:                    
 Keywords:                   |  
-----------------------------+----------------------------------------------
Changes (by wsanchez@...):

  * priority:  5: Not set => 4: Nice to have
  * status:  closed => reopened
  * resolution:  worksforme =>
  * milestone:  => 2.x

Comment:

 OK, can you paste in the error when it's coming from our plugin?

--
Ticket URL: <https://trac.calendarserver.org/ticket/285#comment:8>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-dev

Re: [CalendarServer] #285: Uses deprecated twisted interfaces

by CalendarServer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#285: Uses deprecated twisted interfaces
------------------------------+---------------------------------------------
  Reporter:  agx@…            |       Owner:  agx@…            
      Type:  Defect           |      Status:  new              
  Priority:  4: Nice to have  |   Milestone:  CalendarServer-2.x
 Component:  Calendar Server  |    Severity:  Other            
Resolution:                   |    Keywords:                    
------------------------------+---------------------------------------------
Changes (by wsanchez@…):

  * owner:  wsanchez@… => agx@…
  * status:  reopened => new


--
Ticket URL: <http://trac.calendarserver.org/ticket/285#comment:9>
CalendarServer </>
HTTP/WebDAV/CalDAV Server
_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@...
http://lists.macosforge.org/mailman/listinfo.cgi/calendarserver-dev