[Freeze break request] Nautilus: do not put a frame around images that have an alpha plane

[Jaap A. Haitsma]

Hi,

Attached a patch that makes sure that images don't get a frame.
Currently larger images than 128 pixels will always get framed, but
this can look ugly (see attached screenshot)

Patch has been approved by Alexander Larsson (Nautilus Maintainer).
Can this patch still go in? It's a trivial change and it makes the
desktop look better.

Regards,

Jaap

[0001-Don-t-show-frames-around-images-with-alpha-plane.patch]

---

From bd97abd6133b8400493611052ccb0d0f83b35848 Mon Sep 17 00:00:00 2001
From: Jaap A. Haitsma <jaap@...>
Date: Sat, 5 Sep 2009 12:34:22 +0200
Subject: [PATCH] Don't show frames around images with alpha plane

---
 libnautilus-private/nautilus-file.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libnautilus-private/nautilus-file.c b/libnautilus-private/nautilus-file.c
index cfe5c5b..84d99ac 100644
--- a/libnautilus-private/nautilus-file.c
+++ b/libnautilus-private/nautilus-file.c
@@ -4165,8 +4165,8 @@ nautilus_file_get_icon (NautilusFile *file,
  w * scale, h * scale,
  GDK_INTERP_BILINEAR);
 
- /* We don't want frames around small icons */
- if (!gdk_pixbuf_get_has_alpha(raw_pixbuf) || s >= 128) {
+ /* We don't want frames around images with an alpha plane */
+ if (!gdk_pixbuf_get_has_alpha(raw_pixbuf)) {
  nautilus_thumbnail_frame_image (&scaled_pixbuf);
  }
  g_object_unref (raw_pixbuf);
--
1.6.3.3

---

--
nautilus-list mailing list
nautilus-list@...
http://mail.gnome.org/mailman/listinfo/nautilus-list

[Frederic Peters-5]

Jaap A. Haitsma wrote:

> Attached a patch that makes sure that images don't get a frame.
> Currently larger images than 128 pixels will always get framed, but
> this can look ugly (see attached screenshot)
>
> Patch has been approved by Alexander Larsson (Nautilus Maintainer).
> Can this patch still go in? It's a trivial change and it makes the
> desktop look better.

I know this is not a request for comments but wouldn't this give the
(false?) idea to the user that it is mandatory to click on an opaque
pixel, while the frame indicated it was ok to click anywhere?



        Frederic
--
nautilus-list mailing list
nautilus-list@...
http://mail.gnome.org/mailman/listinfo/nautilus-list

[Steve Frécinaux]

Patryk Zawadzki wrote:
> 2) It doesn't seem to be an issue for images below 128x128 and they
> currently have no frame.

I would rather have added a frame around images smaller than 128x128.
>
--
nautilus-list mailing list
nautilus-list@...
http://mail.gnome.org/mailman/listinfo/nautilus-list

On Tue, Sep 15, 2009 at 9:25 PM, Patryk Zawadzki <patrys@...> wrote:

> On Tue, Sep 15, 2009 at 9:06 PM, Frederic Peters <fpeters@...> wrote:
>> Jaap A. Haitsma wrote:
>>
>>> Attached a patch that makes sure that images don't get a frame.
>>> Currently larger images than 128 pixels will always get framed, but
>>> this can look ugly (see attached screenshot)
>> I know this is not a request for comments but wouldn't this give the
>> (false?) idea to the user that it is mandatory to click on an opaque
>> pixel, while the frame indicated it was ok to click anywhere?
>
> 1) We prelight icons on hover.
>
> 2) It doesn't seem to be an issue for images below 128x128 and they
> currently have no frame.
>
> --
> Patryk Zawadzki
> _______________________________________________
> desktop-devel-list mailing list
> desktop-devel-list@...
> http://mail.gnome.org/mailman/listinfo/desktop-devel-list
>

Not true.
If you use GIT checkout it's true. If you use the latest stable
version then everything just gets a frame.

@Steve Frécinaux
That is the current case in a stable version but has changed in GIT.

I personally (without the intend to start a new discussion) don't
think this is a good idea to put in nautilus.
--
nautilus-list mailing list
nautilus-list@...
http://mail.gnome.org/mailman/listinfo/nautilus-list