[Issue 1296] New - Session doesn't terminate when SOAP-over-TCP is used with RM

View: New views
10 Messages — Rating Filter:   Alert me  

[Issue 1296] New - Session doesn't terminate when SOAP-over-TCP is used with RM

by daveronge :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://wsit.dev.java.net/issues/show_bug.cgi?id=1296
                 Issue #|1296
                 Summary|Session doesn't terminate when SOAP-over-TCP is used w
                        |ith RM
               Component|wsit
                 Version|current
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|transport
             Assigned to|oleksiys
             Reported by|daveronge






------- Additional comments from daveronge@... Mon Nov  2 19:42:21 +0000 2009 -------
With V2 and latest builds of Metro test cases fail on Xtest hard timeout with
all but the last message being delivered. (The last message may in fact be
delivered too but it is not visible possibly because file buffer is not flushed
by IPing method not finished.)
Attaching the logs from a single session sending five text messages.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...


[Issue 1296] Session doesn't terminate when SOAP-over-TCP is used with RM

by daveronge :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://wsit.dev.java.net/issues/show_bug.cgi?id=1296



User daveronge changed the following:

                What    |Old value                 |New value
================================================================================
              QA contact|jbenoit                   |daveronge
--------------------------------------------------------------------------------




------- Additional comments from daveronge@... Mon Nov  2 19:43:47 +0000 2009 -------
changed QA contact

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...


[Issue 1296] Session doesn't terminate when SOAP-over-TCP is used with RM

by daveronge :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://wsit.dev.java.net/issues/show_bug.cgi?id=1296






------- Additional comments from daveronge@... Mon Nov  2 19:46:09 +0000 2009 -------
Created an attachment (id=1042)
Stdout/stderr of the test Ant script


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...


[Issue 1296] Session doesn't terminate when SOAP-over-TCP is used with RM

by daveronge :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://wsit.dev.java.net/issues/show_bug.cgi?id=1296






------- Additional comments from daveronge@... Mon Nov  2 19:47:49 +0000 2009 -------
Created an attachment (id=1043)
V2 server log from a single session


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...


[Issue 1296] Session doesn't terminate when SOAP-over-TCP is used with RM

by oleksiys :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://wsit.dev.java.net/issues/show_bug.cgi?id=1296



User oleksiys changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|''                        |'oleksiys'
--------------------------------------------------------------------------------
              QA contact|daveronge                 |jbenoit
--------------------------------------------------------------------------------
            Subcomponent|transport                 |jaxws-runtime
--------------------------------------------------------------------------------




------- Additional comments from oleksiys@... Wed Nov  4 17:37:24 +0000 2009 -------
we've fixed test configuration for v2, so there are no classnotfound problems.
But there is another SOAP/TCP related issue.

SOAP/TCP channel, unlike HTTP, should get notification from WS framework (jax-ws), that SOAP/TCP
StreamReader was read out, so SOAP/TCP channel could be released and reused. This mechanism
works via XMLStreamReaderFactory.RecycleAware() interface. Currently in XMLStreamReaderFactory we
have several factory implementations, which could be used: Zephyr, Default, Woodstox. Among those
implementations, only Zephyr calls RecycleAware.onRecycled() for StreamReaders, other implementation
never do that. So SOAP/TCP channels never got released, so client just hangs.

Here is the patch, I propose to apply to jax-ws's XMLStreamReaderFactory [1].
Reassinging this issue to jax-ws, hope the fix is fine and we can integrate it.

Thanks.

Alexey.

[1]

Index: jax-ws-sources/jaxws-
ri/rt/src/com/sun/xml/ws/api/streaming/XMLStreamReaderFactory.java
--- jax-ws-sources/jaxws-ri/rt/src/com/sun/xml/ws/api/streaming/XMLStreamReaderFactory.java
Base (1.8.2.1)
+++ jax-ws-sources/jaxws-ri/rt/src/com/sun/xml/ws/api/streaming/XMLStreamReaderFactory.java
Locally Modified (Based On 1.8.2.1)
@@ -184,6 +184,10 @@
      *      of this class needs to be aware of that.
      */
     public static void recycle(XMLStreamReader r) {
+        if (r instanceof RecycleAware) {
+            ((RecycleAware) r).onRecycled();
+        }
+
         get().doRecycle(r);
     }
 
@@ -289,8 +293,6 @@
         public void doRecycle(XMLStreamReader r) {
             if(zephyrClass.isInstance(r))
                 pool.set(r);
-            if(r instanceof RecycleAware)
-                ((RecycleAware)r).onRecycled();
         }


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...


[Issue 1296] Session doesn't terminate when SOAP-over-TCP is used with RM

by oleksiys :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://wsit.dev.java.net/issues/show_bug.cgi?id=1296



User oleksiys changed the following:

                What    |Old value                 |New value
================================================================================
             Assigned to|oleksiys                  |jitu
--------------------------------------------------------------------------------




------- Additional comments from oleksiys@... Wed Nov  4 17:46:38 +0000 2009 -------
reassign to subcomponent owner

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...


[Issue 1296] Session doesn't terminate when SOAP-over-TCP is used with RM

by jitu-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://wsit.dev.java.net/issues/show_bug.cgi?id=1296






------- Additional comments from jitu@... Wed Nov  4 18:51:54 +0000 2009 -------
Shouldn't the onRecycled() be called after doRecycle() ?

     public static void recycle(XMLStreamReader r) {
         get().doRecycle(r);
+        if (r instanceof RecycleAware) {
+            ((RecycleAware) r).onRecycled();
+        }
+
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...


[Issue 1296] Session doesn't terminate when SOAP-over-TCP is used with RM

by m_potociar :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://wsit.dev.java.net/issues/show_bug.cgi?id=1296






------- Additional comments from m_potociar@... Thu Nov  5 10:28:47 +0000 2009 -------
Hi Jitu, can we close this bug now?

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...


[Issue 1296] Session doesn't terminate when SOAP-over-TCP is used with RM

by scm_issue_link :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://wsit.dev.java.net/issues/show_bug.cgi?id=1296






------- Additional comments from scm_issue_link@... Thu Nov  5 19:02:43 +0000 2009 -------
Code changed in jax-ws-sources
User: jitu
Path:
 /jax-ws-sources/jaxws-ri/rt/src/com/sun/xml/ws/api/streaming/XMLStreamReaderFactory.java (1.8.2.2)
 http://fisheye5.cenqua.com/changelog/jax-ws-sources/?cs=jaxws22:jitu:20091105190208

Log:
[WSIT-1296] XMLStreamReaderFactory#recycle() calls onRecycled(), instead of
its subclasses like zephyr calling onRecycled()
Issue number:  
Obtained from:
Submitted by:  
Reviewed by:  



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...


[Issue 1296] Session doesn't terminate when SOAP-over-TCP is used with RM

by jitu-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://wsit.dev.java.net/issues/show_bug.cgi?id=1296



User jitu changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------
        Target milestone|not determined            |2.0
--------------------------------------------------------------------------------




------- Additional comments from jitu@... Thu Nov  5 19:27:28 +0000 2009 -------
Marking this as fixed.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...