[Issue 215] New - Version number not updated in some generated files

[xlv-java.net]

https://javacc.dev.java.net/issues/show_bug.cgi?id=215
                 Issue #|215
                 Summary|Version number not updated in some generated files
               Component|javacc
                 Version|4.2
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P5
            Subcomponent|general
             Assigned to|sreeni
             Reported by|xlv






------- Additional comments from xlv@... Sat Nov 29 18:50:26 +0000 2008 -------
Some of the files generated with jjtree and javacc are using 4.1 instead of 4.2
for the version number:

The AST node classes, Node.java, SimpleNode.java

CharStream.java,
ParseException.java
Token.java
TokenMgrError.java

At least the last ones (generated with javacc) have differences that are not
only cosmetic ones.

To reproduce:

jjtree Java.jjt
javacc Java.jj

with the grammar:

http://pmd.svn.sourceforge.net/viewvc/pmd/trunk/pmd/etc/grammar/Java.jjt?view=log

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[paulcager]

https://javacc.dev.java.net/issues/show_bug.cgi?id=215






------- Additional comments from paulcager@... Sat Nov 29 22:08:04 +0000 2008 -------
Isn't the version number in that comment right? It is used to determine when the
format of the file last changed (and hence generate, when necessary, the warning
that a file needs to be regenerated).


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[xlv-java.net]

https://javacc.dev.java.net/issues/show_bug.cgi?id=215






------- Additional comments from xlv@... Sat Nov 29 22:19:49 +0000 2008 -------
Sorry I should have included more info in my original report. If I regenerate
all the files from scratch with 4.1 and 4.2, they are different. For the AST
files, it's just that the comment at the top now includes:

,SUPPORT_CLASS_VISIBILITY_PUBLIC=true

so that's not a big deal as it's only a cosmetic change and has no impact at
runtime but for CharStream.java, there's extra @Deprecated clauses, for
ParseException, the serialization has changed as well as some code dealing with
`specialConstructor', serialization was also changed for Token.java and
TokenManager.java.

I've attached the diff file from generating the same grammar with 4.1 and 4.2.
BTW, I put a low priority on the report as it's not that important but some of
the templates have changed and IMHO the version should be bumped.


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[xlv-java.net]

https://javacc.dev.java.net/issues/show_bug.cgi?id=215






------- Additional comments from xlv@... Sat Nov 29 22:20:49 +0000 2008 -------
Created an attachment (id=66)
differences between files generated with 4.1 and 4.2


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[paulcager]

https://javacc.dev.java.net/issues/show_bug.cgi?id=215



User paulcager changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |STARTED
--------------------------------------------------------------------------------




------- Additional comments from paulcager@... Sat Nov 29 23:10:40 +0000 2008 -------
I'd forgotten about the Serialization changes. Yes, we should bump the version
number for files affected by that change.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[paulcager]

https://javacc.dev.java.net/issues/show_bug.cgi?id=215



User paulcager changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|STARTED                   |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from paulcager@... Wed Sep  9 18:05:12 +0000 2009 -------
This was fixed as part of the 5.0 release

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...