[Issue 464] New - TableComparatorChooser & wrong selection

[BRANDS-2]

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=464
                 Issue #|464
                 Summary|TableComparatorChooser & wrong selection
               Component|glazedlists
                 Version|current
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|swing
             Assigned to|jessewilson
             Reported by|brands






------- Additional comments from brands@... Sun Feb  8 17:52:01 +0000 2009 -------
Bugreport from user list:
https://glazedlists.dev.java.net/servlets/ReadMsg?list=users&msgNo=3726

"I'm using the TableComparatorChooser to sort my rows and stumbled upon an
annoying issue. The selection stays when sorting, but when using the arrow
keys to navigate to the next/previous row, the first row of the table is
selected instead of the next/previous row of the current selection. I've
noticed that when sorting the rows, the anchor/lead selection index is set
to -1 which causes this incorrect behaviour. It seems that the selection
model's state is incorrect. Having a selection without anchor or lead
indexes looks wrong in my humble understanding of the swing table model."

I've added a test case for this problem:
EventTableModelTest.guiTestChangeSelectionByKeysInSortedState_FixMe()

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[brianmerrill]

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=464






------- Additional comments from brianmerrill@... Fri Jun 19 21:38:23 +0000 2009 -------
Created an attachment (id=47)
Proposed patch (generated via Eclipse) to track changes to the lead and anchor indices by way of the reorder map to preserve keyboard selections.


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[brianmerrill]

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=464






------- Additional comments from brianmerrill@... Fri Jun 19 21:43:34 +0000 2009 -------
The above patch also contains an update to the JUnit test case for this issue,
i.e. "guiTestChangeSelectionByKeysInSortedState_FixMe".  The test case checked
for a lead selection of -1 when it should be a value > 0 based upon the previous
setSelectionInterval(1, 1) call.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...

[brianmerrill]

https://glazedlists.dev.java.net/issues/show_bug.cgi?id=464






------- Additional comments from brianmerrill@... Fri Jun 19 21:48:31 +0000 2009 -------
Or rather, the lead selection should be a value greater than or *equal* to zero
but not negative.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...