[Issue 633] New - ShaderAttributeSetRetained : remove(..) doesn't remove a ShaderAttribute

View: New views
2 Messages — Rating Filter:   Alert me  

[Issue 633] New - ShaderAttributeSetRetained : remove(..) doesn't remove a ShaderAttribute

by interactivemesh :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://java3d.dev.java.net/issues/show_bug.cgi?id=633
                 Issue #|633
                 Summary|ShaderAttributeSetRetained : remove(..) doesn't remove
                        | a ShaderAttribute
               Component|java3d
                 Version|1.5.2
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|j3d-core
             Assigned to|issues@java3d
             Reported by|interactivemesh






------- Additional comments from interactivemesh@... Tue Oct 27 14:21:21 +0000 2009 -------
ShaderAttributeSetRetained : remove(ShaderAttribute attr) doesn't remove a
ShaderAttribute

It seems as if in 'remove(ShaderAttribute attr)' a ShaderAttributeRetained
object is compared with a ShaderAttribute object, because 'attrs.get(attrName)'
returns a ShaderAttributeRetained object and 'attr' is a ShaderAttribute object.

void remove(ShaderAttribute attr) {
        synchronized(liveStateLock) {  
           
            String attrName = attr.getAttributeName();
           
            if (attrs.get(attrName) == attr) { // ... == attr.retained  !?
               
                attrs.remove(attrName);
                if (source.isLive()) {
                      ((ShaderAttributeRetained)attr.retained).clearLive(refCount);
                    ((ShaderAttributeRetained)attr.retained).removeMirrorUsers(this);
                   
                    sendMessage(ShaderConstants.ATTRIBUTE_SET_REMOVE, attrName);
                }
            }
    }
}

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...


[Issue 633] ShaderAttributeSetRetained : remove(..) doesn't remove a ShaderAttribute

by aces-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://java3d.dev.java.net/issues/show_bug.cgi?id=633



User aces changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from aces@... Fri Oct 30 10:48:26 +0000 2009 -------

Thanks!

Code fix applied.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@...
For additional commands, e-mail: issues-help@...