[Issue 999] New - Compare With much slower than svn diff

[JW12345]

http://subclipse.tigris.org/issues/show_bug.cgi?id=999
                 Issue #|999
                 Summary|Compare With much slower than svn diff
               Component|subclipse
                 Version|current
                Platform|All
              OS/Version|Mac OS X
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|core
             Assigned to|issues@subclipse
             Reported by|jacobweber






------- Additional comments from jacobweber@... Thu Sep 24 11:45:07 -0700 2009 -------
If I select a Subversion project and do Compare With > Latest from Repository, it seems to be
comparing each folder individually, and takes a long time.

But if I use this command on the same project:
svn diff -rHEAD
it's much faster.

Similarly, if I do Compare With > Branch/Tag and select another branch, it seems to compare each file,
and takes forever.

But if I do this:
svn diff --old . --new [URL]
it's very fast.

Is it possible to use the same svn diff commands for the Compare With feature?

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1046&dsMessageId=2399913

To unsubscribe from this discussion, e-mail: [issues-unsubscribe@...].

[Mark Phippard-3]

http://subclipse.tigris.org/issues/show_bug.cgi?id=999






------- Additional comments from markphip@... Thu Sep 24 11:53:49 -0700 2009 -------
It is not possible if you want the graphical differences.  We have to let Eclipse do the diffing to give you
a GUI.  If you take the option for a Unified Diff, then it runs the SVN API.

There is a workaround you can often use though.  If you do your compare against two URL's, rather
than your working copy and a URL, we can do things faster.  For example, use the HEAD revision of the
URL that your working copy is pointing to.

In that scenario we call a Subversion API to give us the list of items that are different and we then only
let Eclipse look at those items.  The problem is that the Subversion API does not currently support the
working copy for this API.  There was an attempt to add it in 1.6 but they ran into some roadblocks and
gave up.

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1046&dsMessageId=2399952

To unsubscribe from this discussion, e-mail: [issues-unsubscribe@...].

[JW12345]

http://subclipse.tigris.org/issues/show_bug.cgi?id=999






------- Additional comments from jacobweber@... Thu Sep 24 11:58:24 -0700 2009 -------
That's unfortunate. Would it be possible to just parse the filenames out of the "svn diff" results, and have
Eclipse diff those files? A little hacky perhaps, but it seems like it would be a lot faster.

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1046&dsMessageId=2399957

To unsubscribe from this discussion, e-mail: [issues-unsubscribe@...].

[Mark Phippard-3]

http://subclipse.tigris.org/issues/show_bug.cgi?id=999






------- Additional comments from markphip@... Thu Sep 24 11:59:51 -0700 2009 -------
If someone wants to write the code, anything is possible.

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1046&dsMessageId=2399958

To unsubscribe from this discussion, e-mail: [issues-unsubscribe@...].

[Doug Gibson-2]

http://subclipse.tigris.org/issues/show_bug.cgi?id=999






------- Additional comments from jdgibson@... Tue Nov  3 10:54:13 -0800 2009 -------
I've taken a shot at a patch for this issue.  It does a couple of things:

1.  If the rev number of the local and remote folders are equal, getChildren
returns an empty list so that Differencer.traverse doesn't have to examine any
children.

2.  The RevisionAwareDifferencer does an svn diff --summarize when created.  The
results of this are used to determine whether a file is equal/not equal in
compareStatusAndRevisions.

Note that I ran into some problems because my local working copy was not checked
out from the root of the repository.
ISVNRemoteResource.getProjectRelativePath() is a new method that addresses the
problem.  I did NOT go through the rest of the code looking for places where
this method should be used.

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1046&dsMessageId=2414188

To unsubscribe from this discussion, e-mail: [issues-unsubscribe@...].

[Doug Gibson-2]

http://subclipse.tigris.org/issues/show_bug.cgi?id=999






------- Additional comments from jdgibson@... Tue Nov  3 10:55:52 -0800 2009 -------
Created an attachment (id=293)
Core patch

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1046&dsMessageId=2414190

To unsubscribe from this discussion, e-mail: [issues-unsubscribe@...].

[Doug Gibson-2]

http://subclipse.tigris.org/issues/show_bug.cgi?id=999






------- Additional comments from jdgibson@... Tue Nov  3 10:56:19 -0800 2009 -------
Created an attachment (id=294)
UI patch

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1046&dsMessageId=2414191

To unsubscribe from this discussion, e-mail: [issues-unsubscribe@...].