[JIRA] Created: (MAGNOLIA-2516) Cleanup/consolidate i.m.cms.beans.runtime.File and the various Document classes

View: New views
4 Messages — Rating Filter:   Alert me  

[JIRA] Created: (MAGNOLIA-2516) Cleanup/consolidate i.m.cms.beans.runtime.File and the various Document classes

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Cleanup/consolidate i.m.cms.beans.runtime.File and the various Document classes
-------------------------------------------------------------------------------

                 Key: MAGNOLIA-2516
                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2516
             Project: Magnolia
          Issue Type: Improvement
          Components: core
            Reporter: Gregory Joseph
            Assignee: Philipp Bracher
             Fix For: 4.0


{{info.magnolia.cms.beans.runtime.File}}, {{info.magnolia.cms.beans.runtime.FileProperties}}, {{info.magnolia.cms.beans.runtime.Document}} and even {{info.magnolia.module.dms.beans.Document}} all seem to have a fairly similar purpose. They should be cleaned up, given better name(s) and packages.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Updated: (MAGNOLIA-2516) Cleanup/consolidate i.m.cms.beans.runtime.File and the various Document classes

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



     [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luca Boati updated MAGNOLIA-2516:
---------------------------------

    Attachment: File.patch

Maybe you are refactoring these classes, anyway...

Saving a binary file, info.magnolia.module.admininterface.saveHandlerImpl set the contentType attribute with key FileProperties.PROPERTY_CONTENTTYPE:
- data.setAttribute(FileProperties.PROPERTY_CONTENTTYPE, doc.getType());

Into info.magnolia.cms.beans.runtime.File the constructor set the contentType property getting the value of key "contentType" from nodeData :
- this.setContentType(data.getAttribute("contentType")); //$NON-NLS-1$
but data.getAttribute("contentType") returns an empty string.

fixing with
this.setContentType(data.getAttribute(FileProperties.PROPERTY_CONTENTTYPE));



> Cleanup/consolidate i.m.cms.beans.runtime.File and the various Document classes
> -------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2516
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2516
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: core
>            Reporter: Grégory Joseph
>            Assignee: Philipp Bärfuss
>             Fix For: 4.2
>
>         Attachments: File.patch
>
>
> {{info.magnolia.cms.beans.runtime.File}}, {{info.magnolia.cms.beans.runtime.FileProperties}}, {{info.magnolia.cms.beans.runtime.Document}} and even {{info.magnolia.module.dms.beans.Document}} all seem to have a fairly similar purpose. They should be cleaned up, given better name(s) and packages.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Updated: (MAGNOLIA-2516) Cleanup/consolidate i.m.cms.beans.runtime.File and the various Document classes

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



     [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philipp Bärfuss updated MAGNOLIA-2516:
--------------------------------------

    Patch included: [Yes]

> Cleanup/consolidate i.m.cms.beans.runtime.File and the various Document classes
> -------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2516
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2516
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: core
>            Reporter: Grégory Joseph
>            Assignee: Philipp Bärfuss
>             Fix For: 4.2
>
>         Attachments: File.patch
>
>
> {{info.magnolia.cms.beans.runtime.File}}, {{info.magnolia.cms.beans.runtime.FileProperties}}, {{info.magnolia.cms.beans.runtime.Document}} and even {{info.magnolia.module.dms.beans.Document}} all seem to have a fairly similar purpose. They should be cleaned up, given better name(s) and packages.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Updated: (MAGNOLIA-2516) Cleanup/consolidate i.m.cms.beans.runtime.File and the various Document classes

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



     [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grégory Joseph updated MAGNOLIA-2516:
-------------------------------------

    Fix Version/s: 4.3
                       (was: 4.2)

> Cleanup/consolidate i.m.cms.beans.runtime.File and the various Document classes
> -------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2516
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2516
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: core
>            Reporter: Grégory Joseph
>            Assignee: Philipp Bärfuss
>             Fix For: 4.3
>
>         Attachments: File.patch
>
>
> {{info.magnolia.cms.beans.runtime.File}}, {{info.magnolia.cms.beans.runtime.FileProperties}}, {{info.magnolia.cms.beans.runtime.Document}} and even {{info.magnolia.module.dms.beans.Document}} all seem to have a fairly similar purpose. They should be cleaned up, given better name(s) and packages.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------