[JIRA] Created: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
|
View:
New views
14 Messages
—
Rating Filter:
Alert me
|
 |
[JIRA] Created: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
contentNodeIterator tag doesn't inherit content ----------------------------------------------- Key: MAGNOLIA-2806 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 Project: Magnolia Issue Type: Bug Components: taglibs Affects Versions: 4.1 Reporter: Thomas Duffey Assignee: Fabrizio Giustina When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Updated: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Duffey updated MAGNOLIA-2806: ------------------------------------ Attachment: ContentNodeIterator.java.inherit.patch Patch to ContentNodeIterator.getCollection() to use parent getFirstMatchingNode() method which handles inheriting from ancestor pages > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1 > Reporter: Thomas Duffey > Assignee: Fabrizio Giustina > Attachments: ContentNodeIterator.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Updated: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Duffey updated MAGNOLIA-2806: ------------------------------------ Attachment: BaseContentTag.java.inherit.patch Patch to BaseContentTag.resolveNode(Content currentPage) to use supplied currentPage instead of the local content node to handle searching through ancestor pages > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1 > Reporter: Thomas Duffey > Assignee: Fabrizio Giustina > Attachments: BaseContentTag.java.inherit.patch, ContentNodeIterator.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Commented: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=23431#action_23431 ] Thomas Duffey commented on MAGNOLIA-2806: ----------------------------------------- Please review two attached patches. There are a lot of different conditional cases involved that I do not fully understand but this handled one test case I am working on doing something like: <cms:contentNodeIterator contentNodeCollectionName="adBox" inherit="true"> . ... </cms:contentNodeIterator> where I expect the inherit="true" attribute to look for the content in ancestor pages. Unfortunately, this breaks some test cases because apparently the use of BaseContentTag.getFirstMatchingNode() requires the [config] repository to be setup. I am trying to add this capability to the tests and will submit another patch for them if I can figure it out. > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1 > Reporter: Thomas Duffey > Assignee: Fabrizio Giustina > Attachments: BaseContentTag.java.inherit.patch, ContentNodeIterator.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Updated: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Duffey updated MAGNOLIA-2806: ------------------------------------ Attachment: ContentNodeIteratorTests.java.inherit.patch Patch to make test case work along with the other patches in this issue > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1 > Reporter: Thomas Duffey > Assignee: Fabrizio Giustina > Attachments: BaseContentTag.java.inherit.patch, ContentNodeIterator.java.inherit.patch, ContentNodeIteratorTests.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Assigned: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grégory Joseph reassigned MAGNOLIA-2806: ---------------------------------------- Assignee: Grégory Joseph (was: Fabrizio Giustina) > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1 > Reporter: Thomas Duffey > Assignee: Grégory Joseph > Fix For: 4.1.1 > > Attachments: BaseContentTag.java.inherit.patch, ContentNodeIterator.java.inherit.patch, ContentNodeIteratorTests.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Updated: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grégory Joseph updated MAGNOLIA-2806: ------------------------------------- Fix Version/s: 4.1.1 > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1 > Reporter: Thomas Duffey > Assignee: Grégory Joseph > Fix For: 4.1.1 > > Attachments: BaseContentTag.java.inherit.patch, ContentNodeIterator.java.inherit.patch, ContentNodeIteratorTests.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Commented: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=23772#action_23772 ] Thomas Duffey commented on MAGNOLIA-2806: ----------------------------------------- Note that the ContentNodeIterator patch is solid -- you definitely need to use getFirstMatchingNode() for inherit to work. The patch to BaseContentTag is most likely a hack that only worked for my current scenario. I believe a better solution may be found in MAGNOLIA-2669 > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1 > Reporter: Thomas Duffey > Assignee: Grégory Joseph > Fix For: 4.1.1 > > Attachments: BaseContentTag.java.inherit.patch, ContentNodeIterator.java.inherit.patch, ContentNodeIteratorTests.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Work started: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on MAGNOLIA-2806 started by Jan Haderka. > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1 > Reporter: Thomas Duffey > Assignee: Jan Haderka > Fix For: 4.1.1 > > Attachments: BaseContentTag.java.inherit.patch, ContentNodeIterator.java.inherit.patch, ContentNodeIteratorTests.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Assigned: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka reassigned MAGNOLIA-2806: ------------------------------------- Assignee: Jan Haderka (was: Grégory Joseph) > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1 > Reporter: Thomas Duffey > Assignee: Jan Haderka > Fix For: 4.1.1 > > Attachments: BaseContentTag.java.inherit.patch, ContentNodeIterator.java.inherit.patch, ContentNodeIteratorTests.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Updated: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2806: ---------------------------------- Fix Version/s: 4.0.3 Affects Version/s: 4.0.2 > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1, 4.0.2 > Reporter: Thomas Duffey > Assignee: Jan Haderka > Fix For: 4.1.1, 4.0.3 > > Attachments: BaseContentTag.java.inherit.patch, ContentNodeIterator.java.inherit.patch, ContentNodeIteratorTests.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Resolved: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka resolved MAGNOLIA-2806. ----------------------------------- Resolution: Fixed {{BaseContentTag}} patched by changes made for MAGNOLIA-2669. Applied the rest. Thanks for patches. > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1, 4.0.2 > Reporter: Thomas Duffey > Assignee: Jan Haderka > Fix For: 4.1.1, 4.0.3 > > Attachments: BaseContentTag.java.inherit.patch, ContentNodeIterator.java.inherit.patch, ContentNodeIteratorTests.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Commented: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=23919#action_23919 ] Hudson CI server commented on MAGNOLIA-2806: -------------------------------------------- Integrated in !http://hudson.magnolia-cms.com/nocacheImages/16x16/blue.gif! [magnolia_main-trunk #941|http://hudson.magnolia-cms.com/job/magnolia_main-trunk/941/] MAGNOLIA-2669, Inherit=true related patches. Parent content is now retrieved using AggregationState directly instead of via Resource class. > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1, 4.0.2 > Reporter: Thomas Duffey > Assignee: Jan Haderka > Fix For: 4.1.1, 4.0.3 > > Attachments: BaseContentTag.java.inherit.patch, ContentNodeIterator.java.inherit.patch, ContentNodeIteratorTests.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
|
|
[JIRA] Commented: (MAGNOLIA-2806) contentNodeIterator tag doesn't inherit content
by JIRA (on behalf of Jan Haderka)
::
Rate this Message:
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=23921#action_23921 ] Hudson CI server commented on MAGNOLIA-2806: -------------------------------------------- Integrated in !http://hudson.magnolia-cms.com/nocacheImages/16x16/blue.gif! [magnolia_main-4.0-branch #49|http://hudson.magnolia-cms.com/job/magnolia_main-4.0-branch/49/] MAGNOLIA-2669, Inherit=true related patches. Parent content is now retrieved using AggregationState directly instead of via Resource class. Backport of r27059. > contentNodeIterator tag doesn't inherit content > ----------------------------------------------- > > Key: MAGNOLIA-2806 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2806 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 4.1, 4.0.2 > Reporter: Thomas Duffey > Assignee: Jan Haderka > Fix For: 4.1.1, 4.0.3 > > Attachments: BaseContentTag.java.inherit.patch, ContentNodeIterator.java.inherit.patch, ContentNodeIteratorTests.java.inherit.patch > > > When you set inherit="true" on the content node iterator tag it does not inherit content from ancestor pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscribe@...> ---------------------------------------------------------------- |
| Free embeddable forum powered by Nabble | Forum Help |
