[JIRA] Created: (MAGNOLIA-2870) ServletDispatchingFilter is not dispatching destroy() method to wrapped servlet

View: New views
4 Messages — Rating Filter:   Alert me  

[JIRA] Created: (MAGNOLIA-2870) ServletDispatchingFilter is not dispatching destroy() method to wrapped servlet

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


ServletDispatchingFilter is not dispatching destroy() method to wrapped servlet
-------------------------------------------------------------------------------

                 Key: MAGNOLIA-2870
                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2870
             Project: Magnolia
          Issue Type: Bug
          Components: core
    Affects Versions: 4.1
            Reporter: Erik Alphenaar
            Assignee: Philipp Bärfuss
            Priority: Minor
         Attachments: ServletDispatchingFilter.patch

The ServletDispatchingFilter calls the init() method of the wrapped servlet on start-up.

When the contents of the servlets tree in /server/filters/servlets are changed in the magnolia admincentral, magnolia reloads the filter chain
to enable the changes to be processed, and thus creates a new instance, and calls the init() method.
The destroy method of the wrapped servlet does not seem to be called.

In my opinion it would be nice to also dispatch the destroy method to the wrapped servlet. At the moment the destroy() is completely ignored
by the ServletDispatchingFilter. This might lead to unexpected behaviour in some scenarios.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Updated: (MAGNOLIA-2870) ServletDispatchingFilter is not dispatching destroy() method to wrapped servlet

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



     [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philipp Bärfuss updated MAGNOLIA-2870:
--------------------------------------

    Fix Version/s: 4.2

> ServletDispatchingFilter is not dispatching destroy() method to wrapped servlet
> -------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2870
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2870
>             Project: Magnolia
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.1
>            Reporter: Erik Alphenaar
>            Assignee: Philipp Bärfuss
>            Priority: Minor
>             Fix For: 4.2
>
>         Attachments: ServletDispatchingFilter.patch
>
>   Original Estimate: 0.06d
>  Remaining Estimate: 0.06d
>
> The ServletDispatchingFilter calls the init() method of the wrapped servlet on start-up.
> When the contents of the servlets tree in /server/filters/servlets are changed in the magnolia admincentral, magnolia reloads the filter chain
> to enable the changes to be processed, and thus creates a new instance, and calls the init() method.
> The destroy method of the wrapped servlet does not seem to be called.
> In my opinion it would be nice to also dispatch the destroy method to the wrapped servlet. At the moment the destroy() is completely ignored
> by the ServletDispatchingFilter. This might lead to unexpected behaviour in some scenarios.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Resolved: (MAGNOLIA-2870) ServletDispatchingFilter is not dispatching destroy() method to wrapped servlet

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



     [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grégory Joseph resolved MAGNOLIA-2870.
--------------------------------------

    Resolution: Fixed

Applied patch, thanks !
(with the slight change that it now *first* delegates to the servlet's destroy method)

> ServletDispatchingFilter is not dispatching destroy() method to wrapped servlet
> -------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2870
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2870
>             Project: Magnolia
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.1
>            Reporter: Erik Alphenaar
>            Assignee: Philipp Bärfuss
>            Priority: Minor
>             Fix For: 4.2
>
>         Attachments: ServletDispatchingFilter.patch
>
>   Original Estimate: 0.06d
>  Remaining Estimate: 0.06d
>
> The ServletDispatchingFilter calls the init() method of the wrapped servlet on start-up.
> When the contents of the servlets tree in /server/filters/servlets are changed in the magnolia admincentral, magnolia reloads the filter chain
> to enable the changes to be processed, and thus creates a new instance, and calls the init() method.
> The destroy method of the wrapped servlet does not seem to be called.
> In my opinion it would be nice to also dispatch the destroy method to the wrapped servlet. At the moment the destroy() is completely ignored
> by the ServletDispatchingFilter. This might lead to unexpected behaviour in some scenarios.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Commented: (MAGNOLIA-2870) ServletDispatchingFilter is not dispatching destroy() method to wrapped servlet

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



    [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24921#action_24921 ]

Hudson CI server commented on MAGNOLIA-2870:
--------------------------------------------

Integrated in !http://hudson.magnolia-cms.com/nocacheImages/16x16/blue.gif! [magnolia_main-trunk #1125|http://hudson.magnolia-cms.com/job/magnolia_main-trunk/1125/]
      applied patch - dispatching the destroy() call to the wrapped servlet


> ServletDispatchingFilter is not dispatching destroy() method to wrapped servlet
> -------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2870
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2870
>             Project: Magnolia
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.1
>            Reporter: Erik Alphenaar
>            Assignee: Philipp Bärfuss
>            Priority: Minor
>             Fix For: 4.2
>
>         Attachments: ServletDispatchingFilter.patch
>
>   Original Estimate: 0.06d
>  Remaining Estimate: 0.06d
>
> The ServletDispatchingFilter calls the init() method of the wrapped servlet on start-up.
> When the contents of the servlets tree in /server/filters/servlets are changed in the magnolia admincentral, magnolia reloads the filter chain
> to enable the changes to be processed, and thus creates a new instance, and calls the init() method.
> The destroy method of the wrapped servlet does not seem to be called.
> In my opinion it would be nice to also dispatch the destroy method to the wrapped servlet. At the moment the destroy() is completely ignored
> by the ServletDispatchingFilter. This might lead to unexpected behaviour in some scenarios.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------