[JIRA] Created: (MAGNOLIA-2875) TreeHandlerManager should set properties recursively to allow flexible tree configurations

View: New views
5 Messages — Rating Filter:   Alert me  

[JIRA] Created: (MAGNOLIA-2875) TreeHandlerManager should set properties recursively to allow flexible tree configurations

by JIRA (on behalf of Hudson CI server) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


TreeHandlerManager should set properties recursively to allow flexible tree configurations
------------------------------------------------------------------------------------------

                 Key: MAGNOLIA-2875
                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2875
             Project: Magnolia
          Issue Type: Improvement
          Components: admininterface
    Affects Versions: 4.1.1
            Reporter: Will Scheidegger
            Assignee: Philipp Bärfuss
         Attachments: TreeHandlerManager.recursive.patch

The way trees are configured at this time is not very flexible: It's all hardcoded in configuration classes. And all you can to is select the configuration class, choose the starting path of the tree and switch between tree and browse mode.

Instead of simply selecting a configuration class by setting the configurationClass value it would be much better to have a ConfigurableTreeConfiguration class which reads its configuration at runtime from the config tree. So instead of providing a configurationClass nodeData one would provide a configuration contentNode which contains all the trees configuration info.

When I tried to do this, I noticed however that this contentNode was never turned into a bean. This is because the TreeHandlerManager does not set the properties recursively. The attached patch fixes this problem.

In a later step, I will provide a first version of the ConfigurableTreeConfiguration too.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Updated: (MAGNOLIA-2875) TreeHandlerManager should set properties recursively to allow flexible tree configurations

by JIRA (on behalf of Hudson CI server) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



     [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philipp Bärfuss updated MAGNOLIA-2875:
--------------------------------------

    Fix Version/s: 4.2

We have not yet moved to supporting content2bean for trees and dialogs because this will be changed in the 5.0 version completely. But this minimal patch won't hurt in my opinion.

Thanks!

> TreeHandlerManager should set properties recursively to allow flexible tree configurations
> ------------------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2875
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2875
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: admininterface
>    Affects Versions: 4.1.1
>            Reporter: Will Scheidegger
>            Assignee: Philipp Bärfuss
>             Fix For: 4.2
>
>         Attachments: TreeHandlerManager.recursive.patch
>
>   Original Estimate: 0.01d
>  Remaining Estimate: 0.01d
>
> The way trees are configured at this time is not very flexible: It's all hardcoded in configuration classes. And all you can to is select the configuration class, choose the starting path of the tree and switch between tree and browse mode.
> Instead of simply selecting a configuration class by setting the configurationClass value it would be much better to have a ConfigurableTreeConfiguration class which reads its configuration at runtime from the config tree. So instead of providing a configurationClass nodeData one would provide a configuration contentNode which contains all the trees configuration info.
> When I tried to do this, I noticed however that this contentNode was never turned into a bean. This is because the TreeHandlerManager does not set the properties recursively. The attached patch fixes this problem.
> In a later step, I will provide a first version of the ConfigurableTreeConfiguration too.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Commented: (MAGNOLIA-2875) TreeHandlerManager should set properties recursively to allow flexible tree configurations

by JIRA (on behalf of Hudson CI server) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



    [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24447#action_24447 ]

Philipp Bärfuss commented on MAGNOLIA-2875:
-------------------------------------------

Will Scheidegger has published a configuration class which can be used once the patch has been applied:

--> http://www.fastforward.ch/web/ff/dokumentation/entwickler/magnolia_configurable_tree.html

Thanks!

> TreeHandlerManager should set properties recursively to allow flexible tree configurations
> ------------------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2875
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2875
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: admininterface
>    Affects Versions: 4.1.1
>            Reporter: Will Scheidegger
>            Assignee: Philipp Bärfuss
>             Fix For: 4.2
>
>         Attachments: TreeHandlerManager.recursive.patch
>
>   Original Estimate: 0.01d
>  Remaining Estimate: 0.01d
>
> The way trees are configured at this time is not very flexible: It's all hardcoded in configuration classes. And all you can to is select the configuration class, choose the starting path of the tree and switch between tree and browse mode.
> Instead of simply selecting a configuration class by setting the configurationClass value it would be much better to have a ConfigurableTreeConfiguration class which reads its configuration at runtime from the config tree. So instead of providing a configurationClass nodeData one would provide a configuration contentNode which contains all the trees configuration info.
> When I tried to do this, I noticed however that this contentNode was never turned into a bean. This is because the TreeHandlerManager does not set the properties recursively. The attached patch fixes this problem.
> In a later step, I will provide a first version of the ConfigurableTreeConfiguration too.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Resolved: (MAGNOLIA-2875) TreeHandlerManager should set properties recursively to allow flexible tree configurations

by JIRA (on behalf of Hudson CI server) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



     [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grégory Joseph resolved MAGNOLIA-2875.
--------------------------------------

    Resolution: Fixed
      Assignee: Grégory Joseph  (was: Philipp Bärfuss)

Patch applied, thanks Will !
Also updated javadoc of AdminTreeMVCHandler to reflect this; {{setConfiguration()}} isn't deprecated anymore.

> TreeHandlerManager should set properties recursively to allow flexible tree configurations
> ------------------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2875
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2875
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: admininterface
>    Affects Versions: 4.1.1
>            Reporter: Will Scheidegger
>            Assignee: Grégory Joseph
>             Fix For: 4.2
>
>         Attachments: TreeHandlerManager.recursive.patch
>
>   Original Estimate: 0.01d
>  Remaining Estimate: 0.01d
>
> The way trees are configured at this time is not very flexible: It's all hardcoded in configuration classes. And all you can to is select the configuration class, choose the starting path of the tree and switch between tree and browse mode.
> Instead of simply selecting a configuration class by setting the configurationClass value it would be much better to have a ConfigurableTreeConfiguration class which reads its configuration at runtime from the config tree. So instead of providing a configurationClass nodeData one would provide a configuration contentNode which contains all the trees configuration info.
> When I tried to do this, I noticed however that this contentNode was never turned into a bean. This is because the TreeHandlerManager does not set the properties recursively. The attached patch fixes this problem.
> In a later step, I will provide a first version of the ConfigurableTreeConfiguration too.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Commented: (MAGNOLIA-2875) TreeHandlerManager should set properties recursively to allow flexible tree configurations

by JIRA (on behalf of Hudson CI server) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



    [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24923#action_24923 ]

Hudson CI server commented on MAGNOLIA-2875:
--------------------------------------------

Integrated in !http://hudson.magnolia-cms.com/nocacheImages/16x16/blue.gif! [magnolia_main-trunk #1126|http://hudson.magnolia-cms.com/job/magnolia_main-trunk/1126/]
      applied patch - TreeHandlerManager now sets properties of the AdminTreeMVCHandler recursively, allowing the TreeConfiguration to be setup via content2bean


> TreeHandlerManager should set properties recursively to allow flexible tree configurations
> ------------------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2875
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2875
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: admininterface
>    Affects Versions: 4.1.1
>            Reporter: Will Scheidegger
>            Assignee: Grégory Joseph
>             Fix For: 4.2
>
>         Attachments: TreeHandlerManager.recursive.patch
>
>   Original Estimate: 0.01d
>  Remaining Estimate: 0.01d
>
> The way trees are configured at this time is not very flexible: It's all hardcoded in configuration classes. And all you can to is select the configuration class, choose the starting path of the tree and switch between tree and browse mode.
> Instead of simply selecting a configuration class by setting the configurationClass value it would be much better to have a ConfigurableTreeConfiguration class which reads its configuration at runtime from the config tree. So instead of providing a configurationClass nodeData one would provide a configuration contentNode which contains all the trees configuration info.
> When I tried to do this, I noticed however that this contentNode was never turned into a bean. This is because the TreeHandlerManager does not set the properties recursively. The attached patch fixes this problem.
> In a later step, I will provide a first version of the ConfigurableTreeConfiguration too.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------