[JIRA] Created: (MAGNOLIA-2878) Dialog class and saveHandler is no more used/called

View: New views
6 Messages — Rating Filter:   Alert me  

[JIRA] Created: (MAGNOLIA-2878) Dialog class and saveHandler is no more used/called

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Dialog class and saveHandler is no more used/called
---------------------------------------------------

                 Key: MAGNOLIA-2878
                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2878
             Project: Magnolia
          Issue Type: Bug
    Affects Versions: 4.1
            Reporter: Benoît Segaert
            Assignee: Boris Kraft
            Priority: Critical
         Attachments: excelrenderer-saveHandler.jpg, module-class.jpg

On a new module, the class and saveHandler parameter of a Dialog is no more used.

I have 2 examples (cf. attachements)
 - In the Excel Renderer module that I changed for the compatibility with templating kit (saveHandler)
 - In another module, with the using of the class

I added tracing in my code:

public class WSTDownloadLinkListDialog extends ParagraphEditDialog{

   public WSTDownloadLinkListDialog(String name, HttpServletRequest request, HttpServletResponse response, Content configNode) {
                super(name, request, response, configNode);
                log.info("WSTDownloadLinkListDialog instanciated");
        }

And in Excel Renderer module:

public class ExcelTransformerSaveHandler extends UUIDSaveHandler {
    protected void processBinary(Content node, String name) throws RepositoryException {
        super.processBinary(node, name);
        removePreRenderedProperty(name, node);
        log.info("processBinary");
    }

    protected void processString(Content node, String name, int type, int encoding, String[] values, String valueStr) throws PathNotFoundException, RepositoryException, AccessDeniedException {
        super.processString(node, name, type, encoding, values, valueStr);
        final DialogControlImpl control = getControl(name);
        log.info("pprocessString General");
        if (control instanceof UUIDDialogControl) {
            log.info("pprocessString Control");
            removePreRenderedProperty(name, node);
        }
    }

I can see the dialogs but these classes are never instantiated and the method are never called (constructor for WSTDownloadLinkListDialog ).





--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Commented: (MAGNOLIA-2878) Dialog class and saveHandler is no more used/called

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



    [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24338#action_24338 ]

Philipp Bärfuss commented on MAGNOLIA-2878:
-------------------------------------------

This is probably only the case for dialogs assigned to paragraphs. Otherwise save handlers seam to work.

> Dialog class and saveHandler is no more used/called
> ---------------------------------------------------
>
>                 Key: MAGNOLIA-2878
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2878
>             Project: Magnolia
>          Issue Type: Bug
>    Affects Versions: 4.1
>            Reporter: Benoît Segaert
>            Assignee: Boris Kraft
>            Priority: Critical
>         Attachments: excelrenderer-saveHandler.jpg, module-class.jpg
>
>
> On a new module, the class and saveHandler parameter of a Dialog is no more used.
> I have 2 examples (cf. attachements)
>  - In the Excel Renderer module that I changed for the compatibility with templating kit (saveHandler)
>  - In another module, with the using of the class
> I added tracing in my code:
> public class WSTDownloadLinkListDialog extends ParagraphEditDialog{
>    public WSTDownloadLinkListDialog(String name, HttpServletRequest request, HttpServletResponse response, Content configNode) {
>                 super(name, request, response, configNode);
>                 log.info("WSTDownloadLinkListDialog instanciated");
>         }
> And in Excel Renderer module:
> public class ExcelTransformerSaveHandler extends UUIDSaveHandler {
>     protected void processBinary(Content node, String name) throws RepositoryException {
>         super.processBinary(node, name);
>         removePreRenderedProperty(name, node);
>         log.info("processBinary");
>     }
>     protected void processString(Content node, String name, int type, int encoding, String[] values, String valueStr) throws PathNotFoundException, RepositoryException, AccessDeniedException {
>         super.processString(node, name, type, encoding, values, valueStr);
>         final DialogControlImpl control = getControl(name);
>         log.info("pprocessString General");
>         if (control instanceof UUIDDialogControl) {
>             log.info("pprocessString Control");
>             removePreRenderedProperty(name, node);
>         }
>     }
> I can see the dialogs but these classes are never instantiated and the method are never called (constructor for WSTDownloadLinkListDialog ).

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Commented: (MAGNOLIA-2878) Dialog class and saveHandler is no more used/called

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



    [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24339#action_24339 ]

Benoît Segaert commented on MAGNOLIA-2878:
------------------------------------------

Effectively, both examples,, I explained are referred from paragraphs.



> Dialog class and saveHandler is no more used/called
> ---------------------------------------------------
>
>                 Key: MAGNOLIA-2878
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2878
>             Project: Magnolia
>          Issue Type: Bug
>    Affects Versions: 4.1
>            Reporter: Benoît Segaert
>            Assignee: Boris Kraft
>            Priority: Critical
>         Attachments: excelrenderer-saveHandler.jpg, module-class.jpg
>
>
> On a new module, the class and saveHandler parameter of a Dialog is no more used.
> I have 2 examples (cf. attachements)
>  - In the Excel Renderer module that I changed for the compatibility with templating kit (saveHandler)
>  - In another module, with the using of the class
> I added tracing in my code:
> public class WSTDownloadLinkListDialog extends ParagraphEditDialog{
>    public WSTDownloadLinkListDialog(String name, HttpServletRequest request, HttpServletResponse response, Content configNode) {
>                 super(name, request, response, configNode);
>                 log.info("WSTDownloadLinkListDialog instanciated");
>         }
> And in Excel Renderer module:
> public class ExcelTransformerSaveHandler extends UUIDSaveHandler {
>     protected void processBinary(Content node, String name) throws RepositoryException {
>         super.processBinary(node, name);
>         removePreRenderedProperty(name, node);
>         log.info("processBinary");
>     }
>     protected void processString(Content node, String name, int type, int encoding, String[] values, String valueStr) throws PathNotFoundException, RepositoryException, AccessDeniedException {
>         super.processString(node, name, type, encoding, values, valueStr);
>         final DialogControlImpl control = getControl(name);
>         log.info("pprocessString General");
>         if (control instanceof UUIDDialogControl) {
>             log.info("pprocessString Control");
>             removePreRenderedProperty(name, node);
>         }
>     }
> I can see the dialogs but these classes are never instantiated and the method are never called (constructor for WSTDownloadLinkListDialog ).

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Updated: (MAGNOLIA-2878) Dialog class and saveHandler is no more used/called

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



     [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philipp Bärfuss updated MAGNOLIA-2878:
--------------------------------------

    Fix Version/s: 4.2

> Dialog class and saveHandler is no more used/called
> ---------------------------------------------------
>
>                 Key: MAGNOLIA-2878
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2878
>             Project: Magnolia
>          Issue Type: Bug
>    Affects Versions: 4.1
>            Reporter: Benoît Segaert
>            Assignee: Boris Kraft
>            Priority: Critical
>             Fix For: 4.2
>
>         Attachments: excelrenderer-saveHandler.jpg, module-class.jpg
>
>
> On a new module, the class and saveHandler parameter of a Dialog is no more used.
> I have 2 examples (cf. attachements)
>  - In the Excel Renderer module that I changed for the compatibility with templating kit (saveHandler)
>  - In another module, with the using of the class
> I added tracing in my code:
> public class WSTDownloadLinkListDialog extends ParagraphEditDialog{
>    public WSTDownloadLinkListDialog(String name, HttpServletRequest request, HttpServletResponse response, Content configNode) {
>                 super(name, request, response, configNode);
>                 log.info("WSTDownloadLinkListDialog instanciated");
>         }
> And in Excel Renderer module:
> public class ExcelTransformerSaveHandler extends UUIDSaveHandler {
>     protected void processBinary(Content node, String name) throws RepositoryException {
>         super.processBinary(node, name);
>         removePreRenderedProperty(name, node);
>         log.info("processBinary");
>     }
>     protected void processString(Content node, String name, int type, int encoding, String[] values, String valueStr) throws PathNotFoundException, RepositoryException, AccessDeniedException {
>         super.processString(node, name, type, encoding, values, valueStr);
>         final DialogControlImpl control = getControl(name);
>         log.info("pprocessString General");
>         if (control instanceof UUIDDialogControl) {
>             log.info("pprocessString Control");
>             removePreRenderedProperty(name, node);
>         }
>     }
> I can see the dialogs but these classes are never instantiated and the method are never called (constructor for WSTDownloadLinkListDialog ).

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Issue Comment Edited: (MAGNOLIA-2878) Dialog class and saveHandler is no more used/called

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



    [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24338#action_24338 ]

Boris Kraft edited comment on MAGNOLIA-2878 at 10/16/09 11:31 AM:
------------------------------------------------------------------

This is probably only the case for dialogs assigned to paragraphs. Otherwise save handlers seem to work.

      was (Author: pbaerfuss):
    This is probably only the case for dialogs assigned to paragraphs. Otherwise save handlers seam to work.
 

> Dialog class and saveHandler is no more used/called
> ---------------------------------------------------
>
>                 Key: MAGNOLIA-2878
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2878
>             Project: Magnolia
>          Issue Type: Bug
>    Affects Versions: 4.1
>            Reporter: Benoît Segaert
>            Assignee: Boris Kraft
>            Priority: Critical
>             Fix For: 4.2
>
>         Attachments: excelrenderer-saveHandler.jpg, module-class.jpg
>
>
> On a new module, the class and saveHandler parameter of a Dialog is no more used.
> I have 2 examples (cf. attachements)
>  - In the Excel Renderer module that I changed for the compatibility with templating kit (saveHandler)
>  - In another module, with the using of the class
> I added tracing in my code:
> public class WSTDownloadLinkListDialog extends ParagraphEditDialog{
>    public WSTDownloadLinkListDialog(String name, HttpServletRequest request, HttpServletResponse response, Content configNode) {
>                 super(name, request, response, configNode);
>                 log.info("WSTDownloadLinkListDialog instanciated");
>         }
> And in Excel Renderer module:
> public class ExcelTransformerSaveHandler extends UUIDSaveHandler {
>     protected void processBinary(Content node, String name) throws RepositoryException {
>         super.processBinary(node, name);
>         removePreRenderedProperty(name, node);
>         log.info("processBinary");
>     }
>     protected void processString(Content node, String name, int type, int encoding, String[] values, String valueStr) throws PathNotFoundException, RepositoryException, AccessDeniedException {
>         super.processString(node, name, type, encoding, values, valueStr);
>         final DialogControlImpl control = getControl(name);
>         log.info("pprocessString General");
>         if (control instanceof UUIDDialogControl) {
>             log.info("pprocessString Control");
>             removePreRenderedProperty(name, node);
>         }
>     }
> I can see the dialogs but these classes are never instantiated and the method are never called (constructor for WSTDownloadLinkListDialog ).

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------


[JIRA] Commented: (MAGNOLIA-2878) Dialog class and saveHandler is no more used/called

by JIRA (on behalf of Jan Haderka) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



    [ http://jira.magnolia-cms.com/browse/MAGNOLIA-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24711#action_24711 ]

Benoît Segaert commented on MAGNOLIA-2878:
------------------------------------------

Philipp,

Can we expected a solution for version 4.2? Because I need it for my project.

If you don't have time can you give me some directions where I can looking for in the code?


> Dialog class and saveHandler is no more used/called
> ---------------------------------------------------
>
>                 Key: MAGNOLIA-2878
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2878
>             Project: Magnolia
>          Issue Type: Bug
>    Affects Versions: 4.1
>            Reporter: Benoît Segaert
>            Assignee: Boris Kraft
>            Priority: Critical
>             Fix For: 4.2
>
>         Attachments: excelrenderer-saveHandler.jpg, module-class.jpg
>
>
> On a new module, the class and saveHandler parameter of a Dialog is no more used.
> I have 2 examples (cf. attachements)
>  - In the Excel Renderer module that I changed for the compatibility with templating kit (saveHandler)
>  - In another module, with the using of the class
> I added tracing in my code:
> public class WSTDownloadLinkListDialog extends ParagraphEditDialog{
>    public WSTDownloadLinkListDialog(String name, HttpServletRequest request, HttpServletResponse response, Content configNode) {
>                 super(name, request, response, configNode);
>                 log.info("WSTDownloadLinkListDialog instanciated");
>         }
> And in Excel Renderer module:
> public class ExcelTransformerSaveHandler extends UUIDSaveHandler {
>     protected void processBinary(Content node, String name) throws RepositoryException {
>         super.processBinary(node, name);
>         removePreRenderedProperty(name, node);
>         log.info("processBinary");
>     }
>     protected void processString(Content node, String name, int type, int encoding, String[] values, String valueStr) throws PathNotFoundException, RepositoryException, AccessDeniedException {
>         super.processString(node, name, type, encoding, values, valueStr);
>         final DialogControlImpl control = getControl(name);
>         log.info("pprocessString General");
>         if (control instanceof UUIDDialogControl) {
>             log.info("pprocessString Control");
>             removePreRenderedProperty(name, node);
>         }
>     }
> I can see the dialogs but these classes are never instantiated and the method are never called (constructor for WSTDownloadLinkListDialog ).

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscribe@...>
----------------------------------------------------------------