[JIRA] Created: (STS-724) DefaultValidationMetadataProvider fails to find @Validate annotations on subclasses

DefaultValidationMetadataProvider fails to find @Validate annotations on subclasses
-----------------------------------------------------------------------------------

                 Key: STS-724
                 URL: http://www.stripesframework.org/jira/browse/STS-724
             Project: Stripes
          Issue Type: Bug
          Components: Validation
    Affects Versions: Release 1.5.2
         Environment: Mac OS 10.5, java 1.5.0_20, Tomcat 6.0.18

            Reporter: Pascal Grün
            Priority: Minor


When having an abstract (not necessarily, I think) class GenericActionBean with

public (abstract) Foo getFoo();
public (abstract) void setFoo(Foo foo);

the DefaultValidationMetadataProvider cannot find the correct get/set-method (i.e. it returns the abstract method) and therefore fails to find any annotations that might be on the methods of the implementing child class.

This problem exists ONLY if the child class returns a subclass of Foo or if GenericActionBean is a template class (i.e. GenericActionBean<T>, public abstract T getFoo)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Stripes-development mailing list
Stripes-development@...
https://lists.sourceforge.net/lists/listinfo/stripes-development

     [ http://www.stripesframework.org/jira/browse/STS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ben Gunter updated STS-724:
---------------------------

    Fix Version/s: Release 1.6
                   Release 1.5.3

> DefaultValidationMetadataProvider fails to find @Validate annotations on subclasses
> -----------------------------------------------------------------------------------
>
>                 Key: STS-724
>                 URL: http://www.stripesframework.org/jira/browse/STS-724
>             Project: Stripes
>          Issue Type: Bug
>          Components: Validation
>    Affects Versions: Release 1.5.2
>         Environment: Mac OS 10.5, java 1.5.0_20, Tomcat 6.0.18
>            Reporter: Pascal Grün
>            Priority: Minor
>             Fix For: Release 1.5.3, Release 1.6
>
>
> When having an abstract (not necessarily, I think) class GenericActionBean with
> public (abstract) Foo getFoo();
> public (abstract) void setFoo(Foo foo);
> the DefaultValidationMetadataProvider cannot find the correct get/set-method (i.e. it returns the abstract method) and therefore fails to find any annotations that might be on the methods of the implementing child class.
> This problem exists ONLY if the child class returns a subclass of Foo or if GenericActionBean is a template class (i.e. GenericActionBean<T>, public abstract T getFoo)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Stripes-development mailing list
Stripes-development@...
https://lists.sourceforge.net/lists/listinfo/stripes-development

    [ http://www.stripesframework.org/jira/browse/STS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11846#action_11846 ]

Pascal Grün commented on STS-724:
---------------------------------

Ok, I did a bit more debugging and found out that this isn't actually a Stripes problem but a bug in the JDK itself. The problem has already been filed as a bug report at Sun: http://bugs.sun.com/view_bug.do?bug_id=6794807

As a workaround one can override the method(s) and use the exact same signature (i.e. same return type and parameter types) as in the super class. For templates one could use Object instead of template parameters, I guess.

So, this bug can be closed now, I suppose.

> DefaultValidationMetadataProvider fails to find @Validate annotations on subclasses
> -----------------------------------------------------------------------------------
>
>                 Key: STS-724
>                 URL: http://www.stripesframework.org/jira/browse/STS-724
>             Project: Stripes
>          Issue Type: Bug
>          Components: Validation
>    Affects Versions: Release 1.5.2
>         Environment: Mac OS 10.5, java 1.5.0_20, Tomcat 6.0.18
>            Reporter: Pascal Grün
>            Priority: Minor
>             Fix For: Release 1.5.3, Release 1.6
>
>
> When having an abstract (not necessarily, I think) class GenericActionBean with
> public (abstract) Foo getFoo();
> public (abstract) void setFoo(Foo foo);
> the DefaultValidationMetadataProvider cannot find the correct get/set-method (i.e. it returns the abstract method) and therefore fails to find any annotations that might be on the methods of the implementing child class.
> This problem exists ONLY if the child class returns a subclass of Foo or if GenericActionBean is a template class (i.e. GenericActionBean<T>, public abstract T getFoo)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Stripes-development mailing list
Stripes-development@...
https://lists.sourceforge.net/lists/listinfo/stripes-development

    [ http://www.stripesframework.org/jira/browse/STS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11847#action_11847 ]

Ben Gunter commented on STS-724:
--------------------------------

For 1.5.2, we added a work-around for a similar bug so we'll try to do the same for this one. See STS-664 for more info.

> DefaultValidationMetadataProvider fails to find @Validate annotations on subclasses
> -----------------------------------------------------------------------------------
>
>                 Key: STS-724
>                 URL: http://www.stripesframework.org/jira/browse/STS-724
>             Project: Stripes
>          Issue Type: Bug
>          Components: Validation
>    Affects Versions: Release 1.5.2
>         Environment: Mac OS 10.5, java 1.5.0_20, Tomcat 6.0.18
>            Reporter: Pascal Grün
>            Priority: Minor
>             Fix For: Release 1.5.3, Release 1.6
>
>
> When having an abstract (not necessarily, I think) class GenericActionBean with
> public (abstract) Foo getFoo();
> public (abstract) void setFoo(Foo foo);
> the DefaultValidationMetadataProvider cannot find the correct get/set-method (i.e. it returns the abstract method) and therefore fails to find any annotations that might be on the methods of the implementing child class.
> This problem exists ONLY if the child class returns a subclass of Foo or if GenericActionBean is a template class (i.e. GenericActionBean<T>, public abstract T getFoo)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Stripes-development mailing list
Stripes-development@...
https://lists.sourceforge.net/lists/listinfo/stripes-development

    [ http://www.stripesframework.org/jira/browse/STS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11848#action_11848 ]

Ben Gunter commented on STS-724:
--------------------------------

Pascal, are you positive this is happening with 1.5.2? I've tried everything I can think of to reproduce it, but all my attempts at breaking it are thwarted by the fix for STS-664. If you're sure it's 1.5.2, please submit some code I can use to reproduce it. Thanks.

> DefaultValidationMetadataProvider fails to find @Validate annotations on subclasses
> -----------------------------------------------------------------------------------
>
>                 Key: STS-724
>                 URL: http://www.stripesframework.org/jira/browse/STS-724
>             Project: Stripes
>          Issue Type: Bug
>          Components: Validation
>    Affects Versions: Release 1.5.2
>         Environment: Mac OS 10.5, java 1.5.0_20, Tomcat 6.0.18
>            Reporter: Pascal Grün
>            Priority: Minor
>             Fix For: Release 1.5.3, Release 1.6
>
>
> When having an abstract (not necessarily, I think) class GenericActionBean with
> public (abstract) Foo getFoo();
> public (abstract) void setFoo(Foo foo);
> the DefaultValidationMetadataProvider cannot find the correct get/set-method (i.e. it returns the abstract method) and therefore fails to find any annotations that might be on the methods of the implementing child class.
> This problem exists ONLY if the child class returns a subclass of Foo or if GenericActionBean is a template class (i.e. GenericActionBean<T>, public abstract T getFoo)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Stripes-development mailing list
Stripes-development@...
https://lists.sourceforge.net/lists/listinfo/stripes-development

    [ http://www.stripesframework.org/jira/browse/STS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11849#action_11849 ]

Pascal Grün commented on STS-724:
---------------------------------

Ok, this bug was indeed fixed with 1.5.2, sorry for the hassle!

> DefaultValidationMetadataProvider fails to find @Validate annotations on subclasses
> -----------------------------------------------------------------------------------
>
>                 Key: STS-724
>                 URL: http://www.stripesframework.org/jira/browse/STS-724
>             Project: Stripes
>          Issue Type: Bug
>          Components: Validation
>    Affects Versions: Release 1.5.2
>         Environment: Mac OS 10.5, java 1.5.0_20, Tomcat 6.0.18
>            Reporter: Pascal Grün
>            Priority: Minor
>             Fix For: Release 1.5.3, Release 1.6
>
>
> When having an abstract (not necessarily, I think) class GenericActionBean with
> public (abstract) Foo getFoo();
> public (abstract) void setFoo(Foo foo);
> the DefaultValidationMetadataProvider cannot find the correct get/set-method (i.e. it returns the abstract method) and therefore fails to find any annotations that might be on the methods of the implementing child class.
> This problem exists ONLY if the child class returns a subclass of Foo or if GenericActionBean is a template class (i.e. GenericActionBean<T>, public abstract T getFoo)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Stripes-development mailing list
Stripes-development@...
https://lists.sourceforge.net/lists/listinfo/stripes-development

     [ http://www.stripesframework.org/jira/browse/STS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ben Gunter closed STS-724.
--------------------------

       Resolution: Duplicate
    Fix Version/s:     (was: Release 1.5.3)
                       (was: Release 1.6)

Closing as duplicate of STS-664.

> DefaultValidationMetadataProvider fails to find @Validate annotations on subclasses
> -----------------------------------------------------------------------------------
>
>                 Key: STS-724
>                 URL: http://www.stripesframework.org/jira/browse/STS-724
>             Project: Stripes
>          Issue Type: Bug
>          Components: Validation
>    Affects Versions: Release 1.5.2
>         Environment: Mac OS 10.5, java 1.5.0_20, Tomcat 6.0.18
>            Reporter: Pascal Grün
>            Priority: Minor
>
> When having an abstract (not necessarily, I think) class GenericActionBean with
> public (abstract) Foo getFoo();
> public (abstract) void setFoo(Foo foo);
> the DefaultValidationMetadataProvider cannot find the correct get/set-method (i.e. it returns the abstract method) and therefore fails to find any annotations that might be on the methods of the implementing child class.
> This problem exists ONLY if the child class returns a subclass of Foo or if GenericActionBean is a template class (i.e. GenericActionBean<T>, public abstract T getFoo)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Stripes-development mailing list
Stripes-development@...
https://lists.sourceforge.net/lists/listinfo/stripes-development