[KDE Usability] Review Request: Job progress UI should not use full urls for local paths

View: New views
2 Messages — Rating Filter:   Alert me  

[KDE Usability] Review Request: Job progress UI should not use full urls for local paths

by Bugzilla from agateau@kde.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2055/
-----------------------------------------------------------

Review request for kdelibs and usability.


Summary
-------

Job progress UI uses full urls, even for local paths. This means prefixing them with "file:///", this looks a bit ugly and wastes horizontal space. This patch replaces calls to KUrl::prettyUrl() with KUrl::pathOrUrl(), fixing the problem.


Diffs
-----

  trunk/KDE/kdelibs/kio/kio/job.cpp 1042694

Diff: http://reviewboard.kde.org/r/2055/diff


Testing
-------

Copied files from remote to local system and from local to local as well.


Thanks,

Aurélien

_______________________________________________
kde-usability mailing list
kde-usability@...
https://mail.kde.org/mailman/listinfo/kde-usability

Re: [KDE Usability] Review Request: Job progress UI should not use full urls for local paths

by Bugzilla from faure@kde.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2055/#review2911
-----------------------------------------------------------

Ship it!


Yep. Trivial enough. Go ahead.

- David


On 2009-11-03 16:57:01, Aurélien Gâteau wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2055/
> -----------------------------------------------------------
>
> (Updated 2009-11-03 16:57:01)
>
>
> Review request for kdelibs and usability.
>
>
> Summary
> -------
>
> Job progress UI uses full urls, even for local paths. This means prefixing them with "file:///", this looks a bit ugly and wastes horizontal space. This patch replaces calls to KUrl::prettyUrl() with KUrl::pathOrUrl(), fixing the problem.
>
>
> Diffs
> -----
>
>   trunk/KDE/kdelibs/kio/kio/job.cpp 1042694
>
> Diff: http://reviewboard.kde.org/r/2055/diff
>
>
> Testing
> -------
>
> Copied files from remote to local system and from local to local as well.
>
>
> Thanks,
>
> Aurélien
>
>

_______________________________________________
kde-usability mailing list
kde-usability@...
https://mail.kde.org/mailman/listinfo/kde-usability