-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1637/-----------------------------------------------------------
(Updated 2009-09-19 07:08:10.307114)
Review request for usability.
Changes
-------
Account from "People" is not Lukas Tinkl's account. Ups.
Summary
-------
KDesktopFileActions in KDE 4.4 (trunk currently) was recently modified to offer (un)mounting for /dev/* urls.
Currently we generate links like <a href="/media/..."> and only in case partition is mounted. This doesn't allow KDesktopFileActions to offer (un)mounting.
Changing this actually needs only this small part:
QString media = "file://" + di.deviceNode;
but we stop opening mounted partitions after that.
So I had to implement KSysinfoPart::urlSelected which listens for url clicks and checks if device under clicked path is mounted. If it is, then open it's mount point.
Diffs
-----
/trunk/playground/base/kio_sysinfo/src/ksysinfopart.h 1025347
/trunk/playground/base/kio_sysinfo/src/ksysinfopart.cpp 1025347
/trunk/playground/base/kio_sysinfo/src/sysinfo.cpp 1025351
Diff:
http://reviewboard.kde.org/r/1637/diffTesting
-------
Thanks,
Rafa?
_______________________________________________
kde-usability mailing list
kde-usability@...
https://mail.kde.org/mailman/listinfo/kde-usability
