[NEWS] theming-1.9 branch started

[Christopher Roy Bratusek-2]

Hi all,

the third branch for 1.9 is now online! This one will contain changes
regarding themes. First changes:

- add native (read: all themes) support for also changing the font-color for
  highlighted and clicked titles (previously only active/inactive)

- make changing font-colors work with tabbar-horizontal (tabbar-vertical
  doesn't show any text (yet))

- remove custom font-color changing options from StyleTab (no longer required)

Goal is to make the most of the options available for all themes, rather than
having too much clutter around.

Other options to be included would be frame-width, frame-font (separated from
prompt/message font) and titlebar-height for example.

Also extra functionality is planed, eg: vertical titlebars showing text or
`rich-title' like stuff (rich-title is a wiki-script that allows to modify the
titlebar-text with user-given stuff).

As always: feedback, suggestions and patches welcome :]

Regards,
Chris

[fuchur-2]

Hi,

On Fri, 13 May 2011 19:02:42 +0200
wrote Christopher Roy Bratusek <nano@...>:

>- add native (read: all themes) support for also changing the font-color
>for
>   highlighted and clicked titles (previously only active/inactive)

Why do you replace inactive with clicked? I need a setting for inactive
highlighted (very useful by tabs or/and click focus mode).

--
Regards,
Fuchur

GPG Fingerprint: CA3B 8204 5B3E 6D48 6D53  C116 E5BC 70D5 B8D7 B2B0

[Christopher Roy Bratusek-2]

Am 14.05.2011 05:22, schrieb fuchur:

Hi,

On Fri, 13 May 2011 19:02:42 +0200
wrote Christopher Roy Bratusek nano@...:

- add native (read: all themes) support for also changing the font-color 
for
  highlighted and clicked titles (previously only active/inactive)

Why do you replace inactive with clicked? I need a setting for inactive
highlighted (very useful by tabs or/and click focus mode).

You got it wrong: previously you could only change active and inactive,
now *also* highlighted and clicked (all four now for all themes).

Chris

[fuchur-2]

Hi,

On Sat, 14 May 2011 07:52:19 +0200
wrote Christopher Roy Bratusek <nano@...>:

>Am 14.05.2011 05:22, schrieb fuchur:
>> Hi,
>>
>> On Fri, 13 May 2011 19:02:42 +0200
>> wrote Christopher Roy Bratusek<nano@...>:
>>
>>> - add native (read: all themes) support for also changing the font-color
>>> for
>>>    highlighted and clicked titles (previously only active/inactive)
>> Why do you replace inactive with clicked? I need a setting for inactive
>> highlighted (very useful by tabs or/and click focus mode).
>>
>You got it wrong: previously you could only change active and inactive,
>now *also* highlighted and clicked (all four now for all themes).
>
>Chris

Really?

On Sun, 30 Jan 2011 16:29:00 +0100
wrote Christopher Roy Bratusek <admin@...>:

>Just tested it and I would like to ask you, whether you could do me a favor?:
>Could you add color-effect when hovering a button to DarkTab, too?

You want highlighted the buttons but you remove highlighted fonts for
inactive windows (by focus click mode and tabs). I not really
understand that.

--
Regards,
Fuchur

GPG Fingerprint: CA3B 8204 5B3E 6D48 6D53  C116 E5BC 70D5 B8D7 B2B0

[Christopher Roy Bratusek-2]

Ah ok. Now I see what you mean. The attached patch (= lastest commit) *should* do it, but it doesnt work?

Hmm... according to src/frames.c this is the correct order.

Chris

[more_font_colors.diff]

---

commit 84c584edfc93c9c7ee7e05f388a6d9d6f607299c
Author: Christopher Roy Bratusek <nano@...>
Date:   Sat May 14 19:12:54 2011 +0200

    added options for changing highlight and clicked font-colors for inactive tabs and titlebars

diff --git a/ChangeLog b/ChangeLog
index c67cbc7..5444c9a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -11,6 +11,9 @@
  * themes/StyleTab/theme.jl: updated to use frame-font instead of
  default-font. Remove custom-font-setting option from StyleTab
 
+ * lisp/sawfish/wm/frames.jl: added options for chaning highlight and
+ clicked font-colors for inactive tabs and titlebars
+
 2011-05-13  Christopher Roy Bratusek <nano@...>
  * lisp/sawfish/wm/frames.jl: add possibility to also change the
  font-color for highlighted and clicked frames regardless of theme
diff --git a/lisp/sawfish/wm/frames.jl b/lisp/sawfish/wm/frames.jl
index 547c4e5..251a308 100644
--- a/lisp/sawfish/wm/frames.jl
+++ b/lisp/sawfish/wm/frames.jl
@@ -174,7 +174,9 @@ by the current theme, then FALLBACK-TYPE is used instead.")
                                       (list frame-font-inactive-color
                                             frame-font-active-color
     frame-font-highlight-color
-    frame-font-clicked-color)
+    frame-font-clicked-color
+    frame-font-inactive-highlight-color
+    frame-font-inactive-clicked-color)
                                       t))
               '(title tabbar-horizontal))
       (mapc (lambda (fc) (remove-frame-part-value fc 'foreground t))
@@ -268,6 +270,13 @@ generate.")
     :depends use-custom-font-color
     :after-set (lambda () (update-frame-font-color)))
 
+  (defcustom frame-font-inactive-highlight-color "white"
+    "Font color for inactive highligted frames"
+    :type color
+    :group appearance
+    :depends use-custom-font-color
+    :after-set (lambda () (update-frame-font-color)))
+
   (defcustom frame-font-clicked-color "grey85"
     "Font color for clicked frames"
     :type color
@@ -275,6 +284,13 @@ generate.")
     :depends use-custom-font-color
     :after-set (lambda () (update-frame-font-color)))
 
+  (defcustom frame-font-inactive-clicked-color "grey85"
+    "Font color for inactive clicked frames"
+    :type color
+    :group appearance
+    :depends use-custom-font-color
+    :after-set (lambda () (update-frame-font-color)))
+
 ;;; managing frame types
 
   (define (define-frame-type-mapper fun)

---

[Christopher Roy Bratusek-2]

Am 14.05.2011 20:06, schrieb Christopher Roy Bratusek:

Ah ok. Now I see what you mean. The attached patch (= lastest commit) *should* do it, but it doesnt work?

Hmm... according to src/frames.c this is the correct order.

Chris

Hmm... after some testing I found out, that Sawfish uses (frame-font-inactive-color) for both
inactive and inactive-highlighted. Strange.

Chris

[Christopher Roy Bratusek-2]

OK. Setting frame-font colors for all 6 states from theme-independent
settings works now.

Chris

[Christopher Roy Bratusek-2]

Am 22.05.2011 10:07, schrieb Christopher Roy Bratusek:
> OK. Setting frame-font colors for all 6 states from theme-independent
> settings works now.
>
> Chris
removed frame-font option, instead added the possibility to change font
according to state.

also... border-width/border-color are now available for testing ... I
guess it would be better to use
top-border/right-border/left-border/bottom-border 'width or 'height
instead and have four options.

Any comments?

Chris